[GitHub] blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468498533 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] GabrielBrascher commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
GabrielBrascher commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468498412 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468496153 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2616 This is an

[GitHub] blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468489750 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] GabrielBrascher commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
GabrielBrascher commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468489567 @blueorangutan package This is an automated message from the

[GitHub] GabrielBrascher closed pull request #3187: master smoketest health check

2019-02-28 Thread GitBox
GabrielBrascher closed pull request #3187: master smoketest health check URL: https://github.com/apache/cloudstack/pull/3187 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] GabrielBrascher closed pull request #3189: [4.12 RC2] smoketest health check

2019-02-28 Thread GitBox
GabrielBrascher closed pull request #3189: [4.12 RC2] smoketest health check URL: https://github.com/apache/cloudstack/pull/3189 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468451012 Trillian test result (tid-3411) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] ToonGeneral commented on issue #2583: CPU cores per socket setting not functional

2019-02-28 Thread GitBox
ToonGeneral commented on issue #2583: CPU cores per socket setting not functional URL: https://github.com/apache/cloudstack/issues/2583#issuecomment-468401898 We have this working with: XS 6.5 and CS 4.8 XS 6.5 and CS 4.11 Given the OP said they had the issue with 6.2, I am

[GitHub] GabrielBrascher commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
GabrielBrascher commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468379090 Thanks for the reviews @rafaelweingartner @wido @andrijapanicsb. @wido and @rafaelweingartner I updated the code considering

[GitHub] pbankonier opened a new pull request #3198: Set service offering unique name over api and gui

2019-02-28 Thread GitBox
pbankonier opened a new pull request #3198: Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198 ## Description This adds the possibility to add/change the unique name of system service offerings over the ui and api. The create

[GitHub] pbankonier closed pull request #3198: Set service offering unique name over api and gui

2019-02-28 Thread GitBox
pbankonier closed pull request #3198: Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198 This is an automated message from the Apache Git Service. To respond to the

[GitHub] gmueller-ewerk commented on issue #3186: Add possibility to set KVM MTU size for NIC

2019-02-28 Thread GitBox
gmueller-ewerk commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-468275922 Yes, I will have a look at the issues This is an automated

[GitHub] gmueller-ewerk edited a comment on issue #3186: Add possibility to set KVM MTU size for NIC

2019-02-28 Thread GitBox
gmueller-ewerk edited a comment on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-468275922 Yes, I will have a look at the issues. This is an

[GitHub] ustcweizhou commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-02-28 Thread GitBox
ustcweizhou commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-468269684 @DennisKonrad could you provide more information ? (1) which cloudstack version ? (2) Do you use official systemvm

[GitHub] pbankonier opened a new pull request #3199: Fix ip V4 and ip v4 cidr column sorting in tables

2019-02-28 Thread GitBox
pbankonier opened a new pull request #3199: Fix ip V4 and ip v4 cidr column sorting in tables URL: https://github.com/apache/cloudstack/pull/3199 ## Description This fixes the sorting of ip addresses and ip cidrs. Currently they get evaluated as a numeric value via parseFloat and

[GitHub] GabrielBrascher commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
GabrielBrascher commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468248992 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468249035 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] pbankonier opened a new pull request #3198: Set service offering unique name over api and gui

2019-02-28 Thread GitBox
pbankonier opened a new pull request #3198: Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198 ## Description This adds the possibility to add/change the unique name of system service offerings over the ui and api. The create

[GitHub] rafaelweingartner commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
rafaelweingartner commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#discussion_r261149614 ## File path: scripts/vm/hypervisor/xenserver/vmops ## @@ -1438,14 +1448,31 @@ def

[GitHub] rafaelweingartner commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
rafaelweingartner commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#discussion_r261149392 ## File path: scripts/vm/hypervisor/xenserver/vmops ## @@ -1438,14 +1448,31 @@ def

[GitHub] andrijapanicsb commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
andrijapanicsb commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468203629 Tested with XenServer 6.5sp1 - works fine, rules are added fine - all good. LGTM

[GitHub] wido commented on issue #3186: Add possibility to set KVM MTU size for NIC

2019-02-28 Thread GitBox
wido commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-468200449 @DennisKonrad Good and valid point. The MTU should only be set if specified. Otherwise we should not define it in the XML and leave it up to

[GitHub] wido commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
wido commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#discussion_r261106033 ## File path: scripts/vm/hypervisor/xenserver/vmops ## @@ -1438,14 +1448,31 @@ def

[GitHub] wido commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
wido commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#discussion_r261101107 ## File path: scripts/vm/hypervisor/xenserver/vmops ## @@ -1517,7 +1550,8 @@ def network_rules(session,

[GitHub] DennisKonrad commented on issue #3186: Add possibility to set KVM MTU size for NIC

2019-02-28 Thread GitBox
DennisKonrad commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-468197371 @wido @gmueller-ewerk @svenvogel I also think we should check the min/max values in the frontend (WebUI) and backend

[GitHub] DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-02-28 Thread GitBox
DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-468193938 @fmaximus @svenvogel Hi , does this mean when the code that's responsible for updating the "ips.json" would also

[GitHub] blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468191440 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2615 This is an

[GitHub] blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
blueorangutan commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468185271 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #3197: Fix XenServer Security Groups 'vmops' script

2019-02-28 Thread GitBox
rhtyd commented on issue #3197: Fix XenServer Security Groups 'vmops' script URL: https://github.com/apache/cloudstack/pull/3197#issuecomment-468185184 @blueorangutan package This is an automated message from the Apache Git