[GitHub] [cloudstack] blueorangutan commented on issue #3308: Ignore META key mask if control was pressed.

2019-04-30 Thread GitBox
blueorangutan commented on issue #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488222087 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2724 This is an

[GitHub] [cloudstack] rhtyd commented on issue #3308: Ignore META key mask if control was pressed.

2019-04-30 Thread GitBox
rhtyd commented on issue #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488221325 I found this old jQuery bug that expects metakey to be sent when ctrl key is hit: https://bugs.jquery.com/ticket/11328 This is a Jav

[GitHub] [cloudstack] blueorangutan commented on issue #3308: Ignore META key mask if control was pressed.

2019-04-30 Thread GitBox
blueorangutan commented on issue #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488219876 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] anuragaw opened a new pull request #3308: Ignore META key mask if control was pressed.

2019-04-30 Thread GitBox
anuragaw opened a new pull request #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308 On VMware Zone, hitting CTRL over Console Proxy will send a mask of Meta key as well. This makes Ctrl+A, Ctrl+E and many functionalities to not wo

[GitHub] [cloudstack] anuragaw commented on issue #3308: Ignore META key mask if control was pressed.

2019-04-30 Thread GitBox
anuragaw commented on issue #3308: Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-488219854 @blueorangutan package This is an automated message from the Apache Git

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280010550 ## File path: server/src/main/java/com/cloud/event/Resource.java ## @@ -0,0 +1,227 @@ +// Licensed to the Apache Software Foundati

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009781 ## File path: server/src/main/java/com/cloud/event/ActionEventUtils.java ## @@ -286,23 +295,48 @@ private static long getDomainId(

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r28003 ## File path: server/src/main/java/com/cloud/event/Taxonomies.java ## @@ -0,0 +1,451 @@ +// Licensed to the Apache Software Founda

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280010037 ## File path: server/src/main/java/com/cloud/event/Cadf.java ## @@ -0,0 +1,286 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009938 ## File path: server/src/main/java/com/cloud/event/Cadf.java ## @@ -0,0 +1,286 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009851 ## File path: server/src/main/java/com/cloud/event/Cadf.java ## @@ -0,0 +1,286 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009750 ## File path: server/src/main/java/com/cloud/event/ActionEventUtils.java ## @@ -286,23 +295,48 @@ private static long getDomainId(

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280010486 ## File path: server/src/main/java/com/cloud/event/Cadf.java ## @@ -0,0 +1,286 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280010693 ## File path: server/src/main/java/com/cloud/event/Taxonomies.java ## @@ -0,0 +1,451 @@ +// Licensed to the Apache Software Founda

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009209 ## File path: api/src/main/java/com/cloud/event/EventTypes.java ## @@ -90,7 +90,9 @@ public static final String EVENT_VM_UPDA

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009675 ## File path: server/src/main/java/com/cloud/event/ActionEventUtils.java ## @@ -17,39 +17,42 @@ package com.cloud.event; -imp

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3232: Cadf events

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#discussion_r280009790 ## File path: server/src/main/java/com/cloud/event/ActionEventUtils.java ## @@ -286,23 +295,48 @@ private static long getDomainId(

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3304: server: Fix exception while update domain resource count (#3204)

2019-04-30 Thread GitBox
DaanHoogland commented on a change in pull request #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#discussion_r280008906 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDa

[cloudstack] branch reimplement3303on4.12 updated: missing ;

2019-04-30 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch reimplement3303on4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/reimplement3303on4.12 by this push: new 4a93867 missin

[GitHub] [cloudstack] DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204)

2019-04-30 Thread GitBox
DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-488214271 @rhtyd fwd-merge did not work due to the file being moved (out of git bounds) -

[GitHub] [cloudstack] anuragaw commented on issue #3229: Console Proxy sends redundant CTRL and ALT keys to VMware

2019-04-30 Thread GitBox
anuragaw commented on issue #3229: Console Proxy sends redundant CTRL and ALT keys to VMware URL: https://github.com/apache/cloudstack/issues/3229#issuecomment-488213157 Also observed that `Cmd` (meta key on Macs) has no effect on VMWare and KVM when CPVM console is launched on MacBook Pro

[GitHub] [cloudstack] skattoju4 edited a comment on issue #3282: Fix slow vm creation when large sf snapshot count

2019-04-30 Thread GitBox
skattoju4 edited a comment on issue #3282: Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#issuecomment-488087008 @svenvogel @syed as discussed / tested getUsedBytes is no longer contributing significantly to slowness in VM creation. Fu

[GitHub] [cloudstack] PaulAngus commented on issue #3056: Niche feature configuration is always prominent in UI (SSL Offload)

2019-04-30 Thread GitBox
PaulAngus commented on issue #3056: Niche feature configuration is always prominent in UI (SSL Offload) URL: https://github.com/apache/cloudstack/issues/3056#issuecomment-488099001 It would certainly be nice. I'm sure that the community would very much welcome the feature. But for now th

[GitHub] [cloudstack] skattoju4 commented on issue #3282: Fix slow vm creation when large sf snapshot count

2019-04-30 Thread GitBox
skattoju4 commented on issue #3282: Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#issuecomment-488087008 @svenvogel @syed as discussed / tested getUsedBytes is no longer contributing significantly to slowness in VM creation. Further i

[GitHub] [cloudstack] PaulAngus commented on a change in pull request #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file

2019-04-30 Thread GitBox
PaulAngus commented on a change in pull request #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file URL: https://github.com/apache/cloudstack/pull/3258#discussion_r279390920 ## File path: ui/config.js ## @@

[GitHub] [cloudstack] PaulAngus commented on a change in pull request #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file

2019-04-30 Thread GitBox
PaulAngus commented on a change in pull request #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file URL: https://github.com/apache/cloudstack/pull/3258#discussion_r279391480 ## File path: ui/config.js ## @@

[GitHub] [cloudstack] webermaximilian92 commented on issue #3307: Feature add scss to css compiler

2019-04-30 Thread GitBox
webermaximilian92 commented on issue #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307#issuecomment-487980076 @rafaelweingartner This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler

2019-04-30 Thread GitBox
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487973640 Very sorry I had to create new PR after running in problems with my forked cloudstack after switching my username. https://github.com/apa

[GitHub] [cloudstack] webermaximilian92 closed pull request #3301: Add scss to css compiler

2019-04-30 Thread GitBox
webermaximilian92 closed pull request #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [cloudstack] webermaximilian92 commented on issue #3301: Add scss to css compiler

2019-04-30 Thread GitBox
webermaximilian92 commented on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487973640 Very sorry I had to create new PR after running in problems with my forked cloudstack after switching my username. https://github.com/apache/clo

[GitHub] [cloudstack] webermaximilian92 opened a new pull request #3307: Feature add scss to css compiler

2019-04-30 Thread GitBox
webermaximilian92 opened a new pull request #3307: Feature add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3307 ## Description _Copy of https://github.com/apache/cloudstack/pull/3301 because I run into troubles after changing my username_ This adds an

[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3227: ubuntu16: fix three issues with ubuntu 16.04 hosts

2019-04-30 Thread GitBox
ustcweizhou commented on a change in pull request #3227: ubuntu16: fix three issues with ubuntu 16.04 hosts URL: https://github.com/apache/cloudstack/pull/3227#discussion_r279762470 ## File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourc

[GitHub] [cloudstack] ustcweizhou commented on issue #3178: GUI project pulldown list slowdown on large number of projects

2019-04-30 Thread GitBox
ustcweizhou commented on issue #3178: GUI project pulldown list slowdown on large number of projects URL: https://github.com/apache/cloudstack/issues/3178#issuecomment-487940581 @svenvogel @rhtyd @DagSonsteboSB PR has been created for this issue: https://github.com/apache/cloudstack/pu

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3306: server: reduce execution time while listing project if projects have many resource tags

2019-04-30 Thread GitBox
ustcweizhou opened a new pull request #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306 ## Description If projects have many resource tags, it will take long time to list projects.

[GitHub] [cloudstack] ustcweizhou commented on issue #3296: [4.13] noVNC console

2019-04-30 Thread GitBox
ustcweizhou commented on issue #3296: [4.13] noVNC console URL: https://github.com/apache/cloudstack/pull/3296#issuecomment-487935007 @DennisKonrad python-numpy is required in CPVM. It would be nice to have it pre-installed in systemvm template. However, if CPVM has internet connection

[GitHub] [cloudstack] rafaelweingartner commented on issue #3301: Add scss to css compiler

2019-04-30 Thread GitBox
rafaelweingartner commented on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487917743 Thanks @webermaximilian92. Can you check the licensing issues? https://builds.apache.org/job/cloudstack-pr-analysis/8442/artifact/target/rat.

[GitHub] [cloudstack] DennisKonrad commented on issue #3190: Include 'removed' async jobs to check recurring snapshots

2019-04-30 Thread GitBox
DennisKonrad commented on issue #3190: Include 'removed' async jobs to check recurring snapshots URL: https://github.com/apache/cloudstack/pull/3190#issuecomment-487914674 @rhtyd Hi, we tested this PR thoroughly. I think it's ready to merge LGTM

[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui

2019-04-30 Thread GitBox
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-487914592 @DaanHoogland can you approve? This is an automated message from the A

[GitHub] [cloudstack] svenvogel commented on issue #3199: Fix ip and ip cidr column sorting in tables

2019-04-30 Thread GitBox
svenvogel commented on issue #3199: Fix ip and ip cidr column sorting in tables URL: https://github.com/apache/cloudstack/pull/3199#issuecomment-487913223 @GabrielBrascher @borisstoyanov can you approve that? This is an automa

[GitHub] [cloudstack] DennisKonrad commented on issue #3296: [4.13] noVNC console

2019-04-30 Thread GitBox
DennisKonrad commented on issue #3296: [4.13] noVNC console URL: https://github.com/apache/cloudstack/pull/3296#issuecomment-487907424 @ustcweizhou To migrate from an existing installation, do we need to build a new systemvm template? Or are the changes to the CPVM applied online somehow?

[GitHub] [cloudstack] anuragaw commented on issue #3229: Console Proxy sends redundant CTRL and ALT keys to VMware

2019-04-30 Thread GitBox
anuragaw commented on issue #3229: Console Proxy sends redundant CTRL and ALT keys to VMware URL: https://github.com/apache/cloudstack/issues/3229#issuecomment-487894349 Upon investigation it seems to be broken just for VMWare > Seems to be working fine on XenServer (7.0 tested) - I

[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3304: server: Fix exception while update domain resource count (#3204)

2019-04-30 Thread GitBox
ustcweizhou commented on a change in pull request #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#discussion_r279634207 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDao