[GitHub] [cloudstack] shwstppr commented on a change in pull request #3320: server: fix for inactive service offering for VM

shwstppr commented on a change in pull request #3320: server: fix for inactive service offering for VM URL: https://github.com/apache/cloudstack/pull/3320#discussion_r282751272 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -965,6 +965,9 @@

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3320: server: fix for inactive service offering for VM

anuragaw commented on a change in pull request #3320: server: fix for inactive service offering for VM URL: https://github.com/apache/cloudstack/pull/3320#discussion_r282748432 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -965,6 +965,9 @@

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3325: slf4j version

DaanHoogland opened a new pull request #3325: slf4j version URL: https://github.com/apache/cloudstack/pull/3325 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ]

[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)

DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-491082200 tnx @svanharmelen I will try to reproduce on master to have a look see

[GitHub] [cloudstack] jcsdatera opened a new pull request #3324: [WIP] Add Datera storage plugin

jcsdatera opened a new pull request #3324: [WIP] Add Datera storage plugin URL: https://github.com/apache/cloudstack/pull/3324 Features: 1. Zone-wide and cluster-wide primary storage support 2. VM template caching automatically on Datera, the subsequent VMs can be created

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3323: Fixed: User not allowed to tag project created by him

Spaceman1984 opened a new pull request #3323: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3323 ## Description Fixed issue where a user cannot tag a project. To reproduce: in the UI: log in as a user type

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3322: Fixed: User not allowed to tag project created by him

Spaceman1984 opened a new pull request #3322: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3322 ## Description Fixed issue where a user cannot tag a project. To reproduce: in the UI: log in as a user type

[GitHub] [cloudstack] Spaceman1984 closed pull request #3318: Fixed: User not allowed to tag project created by him

Spaceman1984 closed pull request #3318: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3318 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] Spaceman1984 closed pull request #3322: Fixed: User not allowed to tag project created by him

Spaceman1984 closed pull request #3322: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3322 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] Spaceman1984 commented on issue #3318: Fixed: User not allowed to tag project created by him

Spaceman1984 commented on issue #3318: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3318#issuecomment-490993349 This branch is a bit broken, I think something went wrong when I changed from upstream to my fork. I am closing this pull

[GitHub] [cloudstack] svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)

svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-490976870 @DaanHoogland as discussed previously, here is an issue to track this problem.

[GitHub] [cloudstack] svanharmelen opened a new issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)

svanharmelen opened a new issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Networking ~~~ # CLOUDSTACK VERSION ~~~

[GitHub] [cloudstack] DagSonsteboSB commented on issue #3213: [WIP DO NOT MERGE] server: allow admins to blacklist vm details that users should not see

DagSonsteboSB commented on issue #3213: [WIP DO NOT MERGE] server: allow admins to blacklist vm details that users should not see URL: https://github.com/apache/cloudstack/pull/3213#issuecomment-490973587 LGTM This is an

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3318: Fixed: User not allowed to tag project created by him

Spaceman1984 commented on a change in pull request #3318: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3318#discussion_r282543682 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -215,6

[GitHub] [cloudstack] swill commented on issue #3089: VMs with invalid IDE configuration when using Solidfire as primary storage

swill commented on issue #3089: VMs with invalid IDE configuration when using Solidfire as primary storage URL: https://github.com/apache/cloudstack/issues/3089#issuecomment-490955505 Reference: @skattoju4 & @syed This is

[GitHub] [cloudstack] syed commented on issue #3319: Use virtio for platform emulator strings starting with Windows*

syed commented on issue #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-490921976 I agree with @svenvogel. The first disk should always be IDE. The subsequent disks can be virtio.

[GitHub] [cloudstack] svenvogel edited a comment on issue #3306: server: reduce execution time while listing project if projects have many resource tags

svenvogel edited a comment on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-490885118 @ustcweizhou we will pick up your change ne try to fix the sort of the project list

[GitHub] [cloudstack] svenvogel edited a comment on issue #3306: server: reduce execution time while listing project if projects have many resource tags

svenvogel edited a comment on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-490885118 @ustcweizhou we will pick this up your change ne try to fix the sort of the project

[GitHub] [cloudstack] svenvogel commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

svenvogel commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-490885118 @ustcweizhou we will pick up your change ne try to fix the sort of the project list with

[GitHub] [cloudstack] pbankonier edited a comment on issue #3294: Set default service offering over api and ui

pbankonier edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-490553133 @ustcweizhou @svenvogel @DaanHoogland The motivation behind this was to make it possible to set a default system offering

[GitHub] [cloudstack] shwstppr opened a new pull request #3320: server: fix for inactive service offering for VM

shwstppr opened a new pull request #3320: server: fix for inactive service offering for VM URL: https://github.com/apache/cloudstack/pull/3320 ## Description Fixes #3315 Currently, the code was allowed to change service offering for VM to a deleted or inactive service offering.

[GitHub] [cloudstack] svenvogel commented on issue #3319: Use virtio for platform emulator strings starting with Windows*

svenvogel commented on issue #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-490833736 @ustcweizhou You are right. That should not be the solution. I understand. Let’s investigate and fix that.

[GitHub] [cloudstack] NuxRo commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)

NuxRo commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-490820752 Hello, how's it going so far? Any more corruptions? This is

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use virtio for platform emulator strings starting with Windows*

ustcweizhou commented on issue #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-490771302 @svenvogel the main problem for this PR is, all Windows vm will be running with virtio (no ide any more !!)