[cloudstack] branch master updated: ui: fix for disk offering quickview details, actions (#3391)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 02cf680 ui: fix for disk offering quickview details, actions (#3391)
02cf680 is described below
commit 02cf680bb8852fe28fca51b23e44ebd582b3d62c
Author: Abhishek Kumar
AuthorDate: Fri Jun 14 07:37:31 2019 +0530
ui: fix for disk offering quickview details, actions (#3391)
Fixes #2741
Quickview widget for disk offerings list in the UI was missing offering
details and action items. cloudStack.listDiskOfferings method call for the
details view data provider was not working, therefore, it has been replaced
with direct ajax API call.
Signed-off-by: Abhishek Kumar
---
ui/scripts/configuration.js | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/ui/scripts/configuration.js b/ui/scripts/configuration.js
index 4003154..e9670a6 100644
--- a/ui/scripts/configuration.js
+++ b/ui/scripts/configuration.js
@@ -2403,16 +2403,19 @@
dataProvider: function(args) {
var data = {
+isrecursive: true,
id: args.context.diskOfferings[0].id
};
-var listDiskOfferingsOptions = {
-isRecursive: true,
-data: data
-};
-var diskOfferings =
cloudStack.listDiskOfferings(listDiskOfferingsOptions);
-args.response.success({
-actionFilter: diskOfferingActionfilter,
-data: diskOfferings[0]
+$.ajax({
+url: createURL('listDiskOfferings'),
+dataType: "json",
+data: data,
+success: function(json) {
+var item =
json.listdiskofferingsresponse.diskoffering[0];
+args.response.success({
+data: item
+});
+}
});
}
}
[GitHub] [cloudstack] rhtyd closed issue #2741: QuickView on DiskOfferings not showing actions
rhtyd closed issue #2741: QuickView on DiskOfferings not showing actions URL: https://github.com/apache/cloudstack/issues/2741 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3391: ui: fix for disk offering quickview details, actions
rhtyd merged pull request #3391: ui: fix for disk offering quickview details, actions URL: https://github.com/apache/cloudstack/pull/3391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3401: Support for bhyve hypervisor on FreeBSD
svenvogel commented on issue #3401: Support for bhyve hypervisor on FreeBSD URL: https://github.com/apache/cloudstack/issues/3401#issuecomment-501892441 @darkfiberiru why do you need this hypervisor? there are different ... like kvm, esxi or xen? is it because you want only use bsd and not CentOS or Ubuntu? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] gildegoma commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined
gildegoma commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined URL: https://github.com/apache/cloudstack/issues/3388#issuecomment-501876149 @DaanHoogland I have no preference for one solution over the other one, but I wanted to report and address the following points: 1. This new behaviour was _silently_ introduced in 4.11.0.0. (This change was not part of CLOUDSTACK-10129 [initial] goals, as far as I understood) 1. What are the exact benefits of this new behaviour? 1. If this new behaviour is kept in the future, I'd propose to consider following anti-"technical debt" actions: - [ ] Make the `user.timezone` database field explicitly mandatory (i.e. NOT NULL constraint + default value) instead of the current `UserAccountVO::getTimezone()` override hack - [ ] Remove the obsolete/unused Client-Side code (fetching browser timezone offset, etc.) - [ ] Add spec/test coverage This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3405: kvm: fix qemu hook race condition
blueorangutan commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501849151 Trillian test result (tid-3692) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 24461 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3405-t3692-kvm-centos7.zip Smoke tests completed. 69 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router
ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501836649 @matheusdaluz it might be useful for some other users. so if you want to merge it into master, it would be better to add a global setting to indicate whether the vm tags will be saved in virtual routers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] darkfiberiru commented on issue #3401: Support for bhyve hypervisor on FreeBSD
darkfiberiru commented on issue #3401: Support for bhyve hypervisor on FreeBSD URL: https://github.com/apache/cloudstack/issues/3401#issuecomment-501826415 Any help understanding the scope of work for a third party wanting to contribute the integration would be helpful. I can go reread through the docs and look at other platforms but really my expertise is more in the FreeBSD side then the java integration side that I understand is needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] gildegoma commented on issue #3354: Upon VM removal, VM records not removed from /etc/hosts
gildegoma commented on issue #3354: Upon VM removal, VM records not removed from /etc/hosts URL: https://github.com/apache/cloudstack/issues/3354#issuecomment-501763541 FYI: I did some validation tests against CloudStack 4.11.3.0-RC1, and can confirm that this issue is now elegantly resolved :+1: :heart: :heart: :heart: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] gildegoma commented on issue #3272: VR DHCP lease file not persistent
gildegoma commented on issue #3272: VR DHCP lease file not persistent URL: https://github.com/apache/cloudstack/issues/3272#issuecomment-501763348 FYI: I did some validation tests against CloudStack 4.11.3.0-RC1, and can confirm that this issue is now elegantly resolved :+1: :heart: :heart: :heart: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501742318 @ustcweizhou sorry, i use a modified cloudstack that save the tags in virtual router, it is a good new feature for you guys or not ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501742318 @ustcweizhou sorry, i use a modified cloudstack that save the tags in virtual router, it is a new feature for you guys or not ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501742318 @ustcweizhou sorry, i use a modified cloudstack that save the tags in virtual router, it is a good feature to acs or not ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3378: project id added in test
DaanHoogland commented on a change in pull request #3378: project id added in
test
URL: https://github.com/apache/cloudstack/pull/3378#discussion_r293387009
##
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##
@@ -646,7 +646,12 @@
Ternary
domainIdRecursiveListProject = new Ternary(cmd.getDomainId(), cmd.isRecursive(), null);
-_accountMgr.buildACLSearchParameters(caller, null,
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts,
domainIdRecursiveListProject, listAll, false);
+Long projectId = cmd.getProjectId();
+if (resourceType.equalsIgnoreCase("project") && projectId == null) {
+projectId = Long.parseLong(resourceId);
Review comment:
yes @ustcweizhou but the search parameter is always Long, so we'll have to
either refuse it if it is a uuid or add a different search. right now an
exception is thrown.
I am thinkin g of abandoning this and just fix the test by setting the
projectId in marvin.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3378: project id added in test
ustcweizhou commented on a change in pull request #3378: project id added in
test
URL: https://github.com/apache/cloudstack/pull/3378#discussion_r293378598
##
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##
@@ -646,7 +646,12 @@
Ternary
domainIdRecursiveListProject = new Ternary(cmd.getDomainId(), cmd.isRecursive(), null);
-_accountMgr.buildACLSearchParameters(caller, null,
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts,
domainIdRecursiveListProject, listAll, false);
+Long projectId = cmd.getProjectId();
+if (resourceType.equalsIgnoreCase("project") && projectId == null) {
+projectId = Long.parseLong(resourceId);
Review comment:
@DaanHoogland
resourceId might be a uuid
it is better to have check like
https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L681
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501699613 @svenvogel I tested in my testing environment. it can be fixed by ``` root@s-158-VM:~# diff -u /usr/local/cloud/systemvm/scripts/storage/secondary/createtmplt.sh /usr/local/cloud/systemvm/scripts/storage/secondary/createtmplt.sh.new --- /usr/local/cloud/systemvm/scripts/storage/secondary/createtmplt.sh 2019-06-13 11:34:00.119649777 + +++ /usr/local/cloud/systemvm/scripts/storage/secondary/createtmplt.sh.new 2019-06-13 13:15:11.475953400 + @@ -112,7 +112,7 @@ fi OPTERR=0 -while getopts 't:n:f:' OPTION +while getopts 'vuht:n:f:s:c:d:S:' OPTION do case $OPTION in t) tflag=1 @@ -124,9 +124,6 @@ f) fflag=1 tmpltimg="$OPTARG" ;; - ?) usage - exit 2 - ;; esac done ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3400: Allow normal users to download template when template are not extractable
rhtyd commented on issue #3400: Allow normal users to download template when template are not extractable URL: https://github.com/apache/cloudstack/issues/3400#issuecomment-501682742 I've not tested it, if it's not a valid bug, we can close it after reproduction. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3405: kvm: fix qemu hook race condition
blueorangutan commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501679434 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3405: kvm: fix qemu hook race condition
rhtyd commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501679229 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3405: kvm: fix qemu hook race condition
blueorangutan commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501678235 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3405: kvm: fix qemu hook race condition
DaanHoogland commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501677511 @rhtyd my question is/was: Do we need to send an alarm if the directory doesn't exist? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3405: kvm: fix qemu hook race condition
rhtyd commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501671949 @DaanHoogland we currently have no way to detect and tell the user/admin that VM died due to the hooks race condition. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3405: kvm: fix qemu hook race condition
blueorangutan commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501672015 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3405: kvm: fix qemu hook race condition
rhtyd commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501668831 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3405: kvm: fix qemu hook race condition
rhtyd opened a new pull request #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405 This fixes the qemu hooks `mkdir` race condition which can happen when too many VMs may launch on a KVM host executing the hooks script that tries to `mkdir` for the custom directory. On exception (multiple scripts trying to mkdir), the VM stops. The custom directory need not be created if it does not exist, instead the custom hooks should only execute when there is a custom directory. Feature documentation: http://docs.cloudstack.apache.org/en/4.11.2.0/adminguide/hosts.html#kvm-libvirt-hook-script-include ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3365: KVM: DPDK live migrations
DaanHoogland commented on a change in pull request #3365: KVM: DPDK live
migrations
URL: https://github.com/apache/cloudstack/pull/3365#discussion_r293326526
##
File path: api/src/main/java/com/cloud/agent/api/to/DPDKTO.java
##
@@ -0,0 +1,45 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api.to;
+
+public class DPDKTO {
Review comment:
maybe DpdkTO? an all caps classname is not ideal.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[cloudstack] branch DaanHoogland-patch-2 updated (8462fce -> b47ae14)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 8462fce space add b47ae14 Update QueryManagerImpl.java No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] rhtyd opened a new issue #3404: Improve volume migration without using secondary storage if possible
rhtyd opened a new issue #3404: Improve volume migration without using secondary storage if possible URL: https://github.com/apache/cloudstack/issues/3404 Currently, a volume migration from one primary storage to another primary storage pool happens via the secondary storage (or a caching storage pool if available). It's possible that both the primary storages are reachable from one-another and in which case the migration can happen directly. In case of VMware, (did not test but per tribal knowledge) a snapshot is taken then it is copied to secondary storage then copied the OVA down to new storage, then a volume is deployed from that template. The aim of the issue is to ask if future versions can have the volume migration improved. # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ Volumes, migration ~~~ # CLOUDSTACK VERSION ~~~ 4.9.x, 4.11.x, 4.13.x ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: ui: Fix quick view tooltip title on multiselect list views (#3403)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 29125be ui: Fix quick view tooltip title on multiselect list views
(#3403)
29125be is described below
commit 29125be369ed845168fc0a5941c2dafdb3913646
Author: Nico Wohlfarth
AuthorDate: Thu Jun 13 12:23:29 2019 +0200
ui: Fix quick view tooltip title on multiselect list views (#3403)
Fixed an issue, where the quick view tooltip title would not have been
displayed properly on list views with a multiselect row.
This was because the html content of the first td of a row was used to
render the title of the quick view tooltip, which would not work if the first
columns content was a checkbox.
Now the td with class first will be used for this (this will be the second
column if there is a multiselect column, otherwise it will remain the first
column).
---
ui/scripts/ui/widgets/listView.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/scripts/ui/widgets/listView.js
b/ui/scripts/ui/widgets/listView.js
index 52f3d7b..7162b93 100644
--- a/ui/scripts/ui/widgets/listView.js
+++ b/ui/scripts/ui/widgets/listView.js
@@ -1585,10 +1585,10 @@
$('').html(_l('label.quickview') + ': '),
$('').addClass('title').html(
cloudStack.concat(
-$tr.find('td:first span').html(), 30
+$tr.find('td.first span').html(), 30
)
).attr({
-title: $tr.find('td:first span').html()
+title: $tr.find('td.first span').html()
}),
$('').addClass('icon').html('')
);
[GitHub] [cloudstack] rhtyd merged pull request #3403: ui: Fix quick view tooltip title on multiselect list views
rhtyd merged pull request #3403: ui: Fix quick view tooltip title on multiselect list views URL: https://github.com/apache/cloudstack/pull/3403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (1c963ba -> 873f1f2)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 1c963ba ui: Add more info for creating volume snapshots (#3390) add 873f1f2 ui: Fix labels broken by translate code (#3386) No new revisions were added by this update. Summary of changes: ui/index.html | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)
[GitHub] [cloudstack] rhtyd merged pull request #3386: Fix labels broken by translation code
rhtyd merged pull request #3386: Fix labels broken by translation code URL: https://github.com/apache/cloudstack/pull/3386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3385: UI Translate code removes same-level content
rhtyd closed issue #3385: UI Translate code removes same-level content URL: https://github.com/apache/cloudstack/issues/3385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (8f9f526 -> 1c963ba)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 8f9f526 ui: alignment fixes (#3395) add 1c963ba ui: Add more info for creating volume snapshots (#3390) No new revisions were added by this update. Summary of changes: .../command/user/snapshot/CreateSnapshotCmd.java | 31 +- .../api/command/test/CreateSnapshotCmdTest.java| 29 .../storage/snapshot/SnapshotSchedulerImpl.java| 2 +- ui/scripts/storage.js | 9 ++- 4 files changed, 45 insertions(+), 26 deletions(-)
[GitHub] [cloudstack] rhtyd merged pull request #3390: Add more info for creating volume snapshots
rhtyd merged pull request #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3327: Volume name for failed and successful snapshots
rhtyd closed issue #3327: Volume name for failed and successful snapshots URL: https://github.com/apache/cloudstack/issues/3327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined
DaanHoogland commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined URL: https://github.com/apache/cloudstack/issues/3388#issuecomment-501639800 @gildegoma I wonder if using the browser time offset is really what you want as a lot of multitimezone implementations exist. What would you do to mitigate no timezone vs UTC? /cc @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3232: Cadf events
DaanHoogland commented on issue #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#issuecomment-501640444 @ndalezios , when thesis delivered, can you look at the conflict? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot
blueorangutan commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot URL: https://github.com/apache/cloudstack/pull/3246#issuecomment-501640055 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3390: Add more info for creating volume snapshots
anuragaw commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-501637065 @ustcweizhou - can we directly do a squash and merge into master? Seems redundant given all PRs are merged into master after a squash. Can do it though if you think it would any value here too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#discussion_r293294473 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java ## @@ -81,6 +82,10 @@ @Parameter(name = ApiConstants.INCLUDE_TAGS, type = CommandType.BOOLEAN, description = "Flag to enable display of Tags for a resource") private Boolean includeTags; +@Parameter(name = ApiConstants.OLD_FORMAT, type = CommandType.BOOLEAN, description = "Flag to enable description rendered in old format with no processing") Review comment: should this have a default (of true)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE]
server: return usage description with resource names and UUIDs
URL: https://github.com/apache/cloudstack/pull/3344#discussion_r293295533
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
##
@@ -145,6 +150,9 @@ public void setUsageId(String usageId) {
this.usageId = usageId;
}
+public boolean getOldFormat() {
+return oldFormat != null && oldFormat;
Review comment:
this is a way to make the default be false. It should be in the description
of the Parameter-annotation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot
blueorangutan commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot URL: https://github.com/apache/cloudstack/pull/3246#issuecomment-501633406 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3403: ui: Fix quick view tooltip title on multiselect list views
anuragaw commented on issue #3403: ui: Fix quick view tooltip title on multiselect list views URL: https://github.com/apache/cloudstack/pull/3403#issuecomment-501633549 Tested fine locally too > Based on PR Description and reading style in CSS LGTM. > Will do a quick test locally and get back if I find any issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot
shwstppr commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot URL: https://github.com/apache/cloudstack/pull/3246#issuecomment-501633220 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3378: project id added in test
ustcweizhou commented on a change in pull request #3378: project id added in
test
URL: https://github.com/apache/cloudstack/pull/3378#discussion_r293287184
##
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##
@@ -646,7 +646,9 @@
Ternary
domainIdRecursiveListProject = new Ternary(cmd.getDomainId(), cmd.isRecursive(), null);
-_accountMgr.buildACLSearchParameters(caller, null,
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts,
domainIdRecursiveListProject, listAll, false);
+Long projectId = cmd.getProjectId() == null ? cmd.getResourceId() :
cmd.getProjectId();
Review comment:
```
public String getResourceId() {
return resourceId;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[cloudstack] branch DaanHoogland-patch-2 updated (2fcbb13 -> 8462fce)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 2fcbb13 make resourceId be used as projectId if the latter is missing add 8462fce space No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [cloudstack] richardlawley commented on issue #3386: Fix labels broken by translation code
richardlawley commented on issue #3386: Fix labels broken by translation code URL: https://github.com/apache/cloudstack/pull/3386#issuecomment-501618967 Updated this to remove the fix to the dashboard already fixed in #3326, and changed to keep translate tag self-closing, just wrapped in . New example of what's fixed - (Optional) labels were affected and don't show without the fix.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3390: Add more info for creating volume snapshots
ustcweizhou commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-501604687 code LGTM, did not test it. @anuragaw could you squash the commits ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch DaanHoogland-patch-2 updated (b39d3c4 -> 2fcbb13)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from b39d3c4 Update test_tags.py add 2fcbb13 make resourceId be used as projectId if the latter is missing No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] richardlawley commented on issue #3385: UI Translate code removes same-level content
richardlawley commented on issue #3385: UI Translate code removes same-level content URL: https://github.com/apache/cloudstack/issues/3385#issuecomment-501601114 @anuragaw #3326 only fixes the Dashboard instance - there were about 10 occurrences of the same problem which I fixed in #3386. However, the method you used to fix (wrapping in a label) is better than mine. Will try and alter mine to fix the other occurrences. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3401: Support for bhyve hypervisor on FreeBSD
svenvogel commented on issue #3401: Support for bhyve hypervisor on FreeBSD URL: https://github.com/apache/cloudstack/issues/3401#issuecomment-501597825 @darkfiberiru thanks for the issue. i think there is no plan to integrate it. @andrijapanic is this correct? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3385: UI Translate code removes same-level content
anuragaw commented on issue #3385: UI Translate code removes same-level content URL: https://github.com/apache/cloudstack/issues/3385#issuecomment-501597123 This should be fixed on latest master @richardlawley https://github.com/apache/cloudstack/pull/3326 CC/ @rhtyd , @rafaelweingartner , @PaulAngus This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3403: Fix quick view tooltip title on multiselect list views
svenvogel commented on issue #3403: Fix quick view tooltip title on multiselect list views URL: https://github.com/apache/cloudstack/pull/3403#issuecomment-501595950 @shwstppr @anuragaw can you take a look? :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] NicoWohlfarth opened a new pull request #3403: Fix quick view tooltip title on multiselect list views
NicoWohlfarth opened a new pull request #3403: Fix quick view tooltip title on multiselect list views URL: https://github.com/apache/cloudstack/pull/3403 ## Description Fixed an issue, where the quick view tooltip title would not have been displayed properly on list views with a multiselect row. This was because the html content of the first `td` of a row was used to render the title of the quick view tooltip, which would not work if the first columns content was a checkbox. Now the `td` with class `first` will be used for this (this will be the second column if there is a multiselect column, otherwise it will remain the first column). ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots: Before  After  ## How Has This Been Tested? Deployed to local environment and tested functionality. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume
blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-501586088 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2886 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router
ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501583954 > @ustcweizhou yes, you added tags to vm ? @matheusdaluz yes. I added tags, no change in virtual routers. then stop/start the vm, still did not see any change. I also read the code and did not find any code to add the resource tags to metadata. strange. https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/router/CommandSetupHelper.java#L1008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3218: vmware: don't use redundant worker VM to extract volume
borisstoyanov commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-501579569 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume
blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-501579687 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501565543 Trillian test result (tid-3690) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34340 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3371-t3690-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_accounts.py Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py Intermittent failure detected: /marvin/tests/smoke/test_async_job.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py Intermittent failure detected: /marvin/tests/smoke/test_network.py Intermittent failure detected: /marvin/tests/smoke/test_password_server.py Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_projects.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 34 look OK, 37 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py test_DeleteDomain | `Error` | 1.41 | test_accounts.py test_forceDeleteDomain | `Error` | 1.40 | test_accounts.py ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.79 | test_accounts.py ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1571.53 | test_accounts.py test_01_create_iso_with_checksum_sha1 | `Error` | 5.20 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 5.15 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 5.16 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 5.17 | test_iso.py test_01_create_iso | `Failure` | 1514.48 | test_iso.py ContextSuite context=TestISO>:setup | `Error` | 3029.95 | test_iso.py ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py test_query_async_job_result | `Error` | 0.00 | test_async_job.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_list_vms_metrics | `Error` | 0.18 | test_metrics_api.py test_deploy_vm_from_iso | `Error` | 0.00 | test_deploy_vm_iso.py ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00
