[GitHub] [cloudstack] anuragaw commented on a change in pull request #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on a change in pull request #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298461145 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@

[GitHub] [cloudstack] blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506610849 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506610744 @blueorangutan test centos7 vmware-65u2 This is an automated message

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298460473 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@

[GitHub] [cloudstack] blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506610056 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-49 This is

[GitHub] [cloudstack] blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506605862 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506605778 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506605483 You assessment was correct @rhtyd . I have verified the changes on untagged and VLANs with specific IDs and it seems accurate. For

[GitHub] [cloudstack] rhtyd commented on issue #3374: KVM: Enhancements for direct download feature

2019-06-27 Thread GitBox
rhtyd commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-506599922 @nvazquez can you add support for ipv6 downloads This is an automated

[GitHub] [cloudstack] anuragaw commented on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
anuragaw commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506593515 Agree with @rhtyd. I would prefer to postpone any major restructuring to after 4.13 as well unless it's an urgent necessity. Please

[GitHub] [cloudstack] ustcweizhou commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
ustcweizhou commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506508969 @rhtyd if it still fails, I will look into it tomorrow. This

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506505233 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506504907 @blueorangutan test This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506500729 Trillian test result (tid-41) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33954

[GitHub] [cloudstack] rhtyd edited a comment on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
rhtyd edited a comment on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506447817 In the present form renaming ui folder just because it feels like may not be encouraged because it will cause conflicts for so

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506447817 In the present form renaming ui folder just because it feels like may not be encouraged because it will cause conflicts for so many

[GitHub] [cloudstack] pbankonier edited a comment on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
pbankonier edited a comment on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506406420 > Can you explain why move the ui directory to client? I found this location more appropriate, because the frontend

[GitHub] [cloudstack] pbankonier commented on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
pbankonier commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506406420 > Can you explain why move the ui directory to client? I found this location more appropriate, because the frontend

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506398641 Can you explain why move the ui directory to client? This is an

[GitHub] [cloudstack] svenvogel commented on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
svenvogel commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506384070 @anuragaw @shwstppr can you take a look? This is an automated

[GitHub] [cloudstack] pbankonier opened a new pull request #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
pbankonier opened a new pull request #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434 ## Description The following things are done in this PR: - Add the **compiling of the scss sources to css to the maven build for the

[GitHub] [cloudstack] pbankonier closed pull request #3433: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
pbankonier closed pull request #3433: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3433 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] pbankonier opened a new pull request #3433: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
pbankonier opened a new pull request #3433: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3433 ## Description The following things are done in this PR: - Add the **compiling of the scss sources to css to the maven build for the

[GitHub] [cloudstack] rhtyd merged pull request #3431: Readd custom css

2019-06-27 Thread GitBox
rhtyd merged pull request #3431: Readd custom css URL: https://github.com/apache/cloudstack/pull/3431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[cloudstack] branch master updated: ui: re-add custom css (#3431)

2019-06-27 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 044e4e4 ui: re-add custom css (#3431)

[GitHub] [cloudstack] svenvogel edited a comment on issue #3431: Readd custom css

2019-06-27 Thread GitBox
svenvogel edited a comment on issue #3431: Readd custom css URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506345180 @rhtyd yes i test it locally and it works. LGTM This is an automated message from the

[GitHub] [cloudstack] svenvogel commented on issue #3431: Readd custom css

2019-06-27 Thread GitBox
svenvogel commented on issue #3431: Readd custom css URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506345180 @rhtyd yes i test it locally and it works. This is an automated message from the Apache Git

[GitHub] [cloudstack] svenvogel commented on issue #3431: Readd custom css

2019-06-27 Thread GitBox
svenvogel commented on issue #3431: Readd custom css URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506321207 @anuragaw i see the same like you. This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rhtyd commented on issue #3431: Readd custom css

2019-06-27 Thread GitBox
rhtyd commented on issue #3431: Readd custom css URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506309466 Can someone confirm testing? This does not need to have smoketests as it is purely UI change. This

[GitHub] [cloudstack] rhtyd commented on issue #3432: Remove additional line from config as storagepool isn't available for users

2019-06-27 Thread GitBox
rhtyd commented on issue #3432: Remove additional line from config as storagepool isn't available for users URL: https://github.com/apache/cloudstack/pull/3432#issuecomment-506308796 LGTM This is an automated message from

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506308486 Copy @rhtyd This is an automated message from the Apache Git

[GitHub] [cloudstack] andrijapanicsb merged pull request #3432: Remove additional line from config as storagepool isn't available for users

2019-06-27 Thread GitBox
andrijapanicsb merged pull request #3432: Remove additional line from config as storagepool isn't available for users URL: https://github.com/apache/cloudstack/pull/3432 This is an automated message from the Apache Git

[cloudstack] branch master updated: Remove additional line from config as storagepool isn't available for users

2019-06-27 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new d967993 Remove additional line from

[GitHub] [cloudstack] andrijapanicsb commented on issue #3432: Remove additional line from config as storagepool isn't available for users

2019-06-27 Thread GitBox
andrijapanicsb commented on issue #3432: Remove additional line from config as storagepool isn't available for users URL: https://github.com/apache/cloudstack/pull/3432#issuecomment-506307665 LGTM, just the cleanup. Merging.

[GitHub] [cloudstack] anuragaw commented on issue #3432: Remove additional line from config as storagepool isn't available for users

2019-06-27 Thread GitBox
anuragaw commented on issue #3432: Remove additional line from config as storagepool isn't available for users URL: https://github.com/apache/cloudstack/pull/3432#issuecomment-506307543 @andrijapanic , @rhtyd , @shwstppr - additional line removal for cleanup that was pointed out.

[GitHub] [cloudstack] anuragaw opened a new pull request #3432: Remove additional line from config as storagepool isn't available for users

2019-06-27 Thread GitBox
anuragaw opened a new pull request #3432: Remove additional line from config as storagepool isn't available for users URL: https://github.com/apache/cloudstack/pull/3432 Follow up left line from #3429 Storage pool isn't available to users so delete it as it's confusing. ##

Jenkins build is back to normal : cloudstack-apidocs-master #3170

2019-06-27 Thread Apache Jenkins Server
See

[GitHub] [cloudstack] svenvogel commented on issue #3431: Readd custom css

2019-06-27 Thread GitBox
svenvogel commented on issue #3431: Readd custom css URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506301129 @anuragaw @shwstppr can you take a look? This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd closed issue #2768: HTML code displayed in Setup Network wizard when adding zone

2019-06-27 Thread GitBox
rhtyd closed issue #2768: HTML code displayed in Setup Network wizard when adding zone URL: https://github.com/apache/cloudstack/issues/2768 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd commented on issue #2768: HTML code displayed in Setup Network wizard when adding zone

2019-06-27 Thread GitBox
rhtyd commented on issue #2768: HTML code displayed in Setup Network wizard when adding zone URL: https://github.com/apache/cloudstack/issues/2768#issuecomment-506296902 LGTM, I'm unable to reproduce as well. Closing this.

Build failed in Jenkins: cloudstack-apidocs-master #3169

2019-06-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on ubuntu-eu2 (ubuntu trusty) in workspace

[GitHub] [cloudstack] rhtyd merged pull request #3427: engine/schema: add guest-os support and mappings for XenServer 7.6

2019-06-27 Thread GitBox
rhtyd merged pull request #3427: engine/schema: add guest-os support and mappings for XenServer 7.6 URL: https://github.com/apache/cloudstack/pull/3427 This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506294455 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[cloudstack] branch master updated: engine/schema: add guest-os support and mappings for XenServer 7.6 (#3427)

2019-06-27 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 23a8b74 engine/schema: add guest-os support

[GitHub] [cloudstack] rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506294382 @blueorangutan test This is an automated message from the Apache Git

[GitHub] [cloudstack] pbankonier opened a new pull request #3431: Readd custom css

2019-06-27 Thread GitBox
pbankonier opened a new pull request #3431: Readd custom css URL: https://github.com/apache/cloudstack/pull/3431 ## Description This readds the custom.css file to overwrite the default cloudstack styles. Currently this is only possible by adding them to the custom.scss in the

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-06-27 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r298082407 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

[GitHub] [cloudstack] anuragaw commented on issue #2768: HTML code displayed in Setup Network wizard when adding zone

2019-06-27 Thread GitBox
anuragaw commented on issue #2768: HTML code displayed in Setup Network wizard when adding zone URL: https://github.com/apache/cloudstack/issues/2768#issuecomment-506263395 I am unable to reproduce the issue on latest master on Ubuntu Chrome. @borisstoyanov - can you please see if it

[GitHub] [cloudstack] pbankonier closed pull request #3428: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
pbankonier closed pull request #3428: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3428 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] pbankonier commented on issue #3428: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
pbankonier commented on issue #3428: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3428#issuecomment-506255874 I will split the bugfix and the build changes in two PRs. This is

[GitHub] [cloudstack] andrijapanicsb commented on issue #3240: api: instance and template details are free text

2019-06-27 Thread GitBox
andrijapanicsb commented on issue #3240: api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-506252128 LGTM This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

2019-06-27 Thread GitBox
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-506249928 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-48

[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

2019-06-27 Thread GitBox
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-506242650 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] shwstppr commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

2019-06-27 Thread GitBox
shwstppr commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-506242496 @blueorangutan package This is an

Jenkins build is back to normal : cloudstack-apidocs-master #3168

2019-06-27 Thread Apache Jenkins Server
See

[GitHub] [cloudstack] rhtyd commented on issue #3428: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
rhtyd commented on issue #3428: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3428#issuecomment-506236802 There are many conflicts, will this break UI building/usage and introduce a new dependency (npm etc.)?

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506232127 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-47 This is an

[GitHub] [cloudstack] rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-06-27 Thread GitBox
rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506230436 Just to confirm this does not break returning of tags in the API response, just the mechanics

[GitHub] [cloudstack] rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-06-27 Thread GitBox
rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506229693 Can you review and test this @anuragaw

Build failed in Jenkins: cloudstack-apidocs-master #3167

2019-06-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on ubuntu-eu2 (ubuntu trusty) in workspace

[GitHub] [cloudstack] rhtyd commented on issue #3041: Decision making logic of which Secondary storage to be used

2019-06-27 Thread GitBox
rhtyd commented on issue #3041: Decision making logic of which Secondary storage to be used URL: https://github.com/apache/cloudstack/issues/3041#issuecomment-506227264 Ping @anuragaw This is an automated message from the

[GitHub] [cloudstack] rhtyd commented on issue #3178: GUI project pulldown list slowdown on large number of projects

2019-06-27 Thread GitBox
rhtyd commented on issue #3178: GUI project pulldown list slowdown on large number of projects URL: https://github.com/apache/cloudstack/issues/3178#issuecomment-506227420 Ping @anuragaw This is an automated message

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506226397 cc @PaulAngus - do you think for public network overlapping vlan-trunking/range be allowed to be added by the admin?

[GitHub] [cloudstack] rhtyd merged pull request #3429: Update config file with tables that users can see

2019-06-27 Thread GitBox
rhtyd merged pull request #3429: Update config file with tables that users can see URL: https://github.com/apache/cloudstack/pull/3429 This is an automated message from the Apache Git Service. To respond to the message,

[cloudstack] branch master updated (5847453 -> 95a509a)

2019-06-27 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 5847453 api: snapshot, snapshotpolicy tag support (#3228) add 95a509a ui: Update config file with tables

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506225348 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

2019-06-27 Thread GitBox
rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506225239 @blueorangutan package This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298038048 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298037550 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506218732 ping for review - @rhtyd , @shwstppr , @andrijapanic , @PaulAngus

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506218577 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] anuragaw opened a new pull request #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw opened a new pull request #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430 Regression was introduced in

[GitHub] [cloudstack] anuragaw commented on issue #3114: One can no longer add multiple Public IP ranges, which share the same subnet.

2019-06-27 Thread GitBox
anuragaw commented on issue #3114: One can no longer add multiple Public IP ranges, which share the same subnet. URL: https://github.com/apache/cloudstack/issues/3114#issuecomment-506216073 Traced back the bug introduction to