[GitHub] [cloudstack] shwstppr opened a new pull request #3992: cks: use public links for templates and binaries iso for smoke tests

2020-03-25 Thread GitBox
shwstppr opened a new pull request #3992: cks: use public links for templates 
and binaries iso for smoke tests
URL: https://github.com/apache/cloudstack/pull/3992
 
 
   ## Description
   Use public links for templates and binaries iso for CKS smoke tests
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-03-25 Thread GitBox
blueorangutan commented on issue #3991: Multiple dynamic VM Scaling APIs can 
create duplicate usage events for the same time 
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-604211788
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1088


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-03-25 Thread GitBox
blueorangutan commented on issue #3991: Multiple dynamic VM Scaling APIs can 
create duplicate usage events for the same time 
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-604208057
 
 
   @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] harikrishna-patnala commented on issue #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-03-25 Thread GitBox
harikrishna-patnala commented on issue #3991: Multiple dynamic VM Scaling APIs 
can create duplicate usage events for the same time 
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-604207749
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-03-25 Thread GitBox
blueorangutan commented on issue #3991: Multiple dynamic VM Scaling APIs can 
create duplicate usage events for the same time 
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-604205764
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1087


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-03-25 Thread GitBox
blueorangutan commented on issue #3991: Multiple dynamic VM Scaling APIs can 
create duplicate usage events for the same time 
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-604204269
 
 
   @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] harikrishna-patnala commented on issue #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-03-25 Thread GitBox
harikrishna-patnala commented on issue #3991: Multiple dynamic VM Scaling APIs 
can create duplicate usage events for the same time 
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-604204150
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] harikrishna-patnala opened a new pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-03-25 Thread GitBox
harikrishna-patnala opened a new pull request #3991: Multiple dynamic VM 
Scaling APIs can create duplicate usage events for the same time 
URL: https://github.com/apache/cloudstack/pull/3991
 
 
   
   
   ## Description
   Submitting multiple dynamic VM Scaling API commands for the same instance 
can result in two usage events in the same second causing a compound key 
violation in usage service
   
   Root cause:
   Even though dynamic scaling job is handled in vmworkjob queue which ensures 
serilizing multiple jobs but the database updating and generating usage events 
are out of the job queue.
   
   Solution:
   Moved all updations into the job queue
   
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated: compute: VM deployment wizard (#146)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new 86845be  compute: VM deployment wizard (#146)
86845be is described below

commit 86845be4813e9bd50b6278bd0d02deb5c10fd411
Author: Hoang Nguyen 
AuthorDate: Thu Mar 26 04:18:39 2020 +0700

compute: VM deployment wizard (#146)

A mostly functional vm deployment wizard.

Signed-off-by: Abhishek Kumar 
Signed-off-by: Rohit Yadav 
---
 src/locales/en.json|   2 +-
 src/utils/device.js|   7 +-
 src/views/AutogenView.vue  |   2 +-
 src/views/compute/DeployVM.vue | 806 +
 src/views/compute/KubernetesServiceTab.vue |   2 +-
 .../compute/wizard/AffinityGroupSelection.vue  |  51 +-
 src/views/compute/wizard/ComputeSelection.vue  |  62 +-
 src/views/compute/wizard/DiskOfferingSelection.vue | 108 ++-
 src/views/compute/wizard/DiskSizeSelection.vue |  17 +-
 src/views/compute/wizard/NetworkConfiguration.vue  |  65 +-
 src/views/compute/wizard/NetworkSelection.vue  |  76 +-
 src/views/compute/wizard/NetworksCreation.vue  | 150 
 src/views/compute/wizard/SshKeyPairSelection.vue   |  80 +-
 src/views/compute/wizard/TemplateIsoRadioGroup.vue | 136 +++-
 src/views/compute/wizard/TemplateIsoSelection.vue  | 161 ++--
 src/views/iam/SSLCertificateTab.vue|   2 +-
 src/views/image/IsoZones.vue   |   2 +-
 src/views/image/TemplateZones.vue  |   2 +-
 src/views/network/VpcTab.vue   |   2 +-
 19 files changed, 1242 insertions(+), 491 deletions(-)

diff --git a/src/locales/en.json b/src/locales/en.json
index 6511211..d4ddbff 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -1103,7 +1103,7 @@
 "sshKeyPairs": "SSH keypairs",
 "wednesday": "Wednesday",
 "noselect": "No thanks",
-"groupname": "Add to group",
+"group": "Group",
 "keyboard": "Keyboard language",
 "userdata": "Userdata",
 "label.back": "Back",
diff --git a/src/utils/device.js b/src/utils/device.js
index 731270d..ce6deab 100644
--- a/src/utils/device.js
+++ b/src/utils/device.js
@@ -42,9 +42,8 @@ export const deviceEnquire = function (callback) {
 }
   }
 
-  // screen and (max-width: 1087.99px)
   enquireJs
-.register('screen and (max-width: 576px)', matchMobile)
-.register('screen and (min-width: 576px) and (max-width: 1280px)', 
matchTablet)
-.register('screen and (min-width: 1281px)', matchDesktop)
+.register('screen and (max-width: 800px)', matchMobile)
+.register('screen and (min-width: 800px) and (max-width: 1366px)', 
matchTablet)
+.register('screen and (min-width: 1367px)', matchDesktop)
 }
diff --git a/src/views/AutogenView.vue b/src/views/AutogenView.vue
index 8887a5e..871c380 100644
--- a/src/views/AutogenView.vue
+++ b/src/views/AutogenView.vue
@@ -235,7 +235,7 @@
 :pageSize="pageSize"
 :total="itemCount"
 :showTotal="total => `Total ${total} items`"
-:pageSizeOptions="['10', '20', '40', '80', '100']"
+:pageSizeOptions="['10', '20', '40', '80', '100', '500']"
 @change="changePage"
 @showSizeChange="changePageSize"
 showSizeChanger
diff --git a/src/views/compute/DeployVM.vue b/src/views/compute/DeployVM.vue
index eb0a5f7..f1a4c9e 100644
--- a/src/views/compute/DeployVM.vue
+++ b/src/views/compute/DeployVM.vue
@@ -25,131 +25,216 @@
 @submit="handleSubmit"
 layout="vertical"
   >
-
-  
-
-  
-
-
-
-  
-
-  
-
-  
-
-  
-
+
+  
+
+  
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+
+  
+  
+
+  
+
+  
+  
+
+  
+
+  
+
+
+  
+  
+
+  
+
+
+  
+

[cloudstack-primate] branch master updated (5043403 -> 24afe1c)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from 5043403  compute: add CKS support (#247)
 add 24afe1c  iam: allow custom account field input in add account form 
(#220)

No new revisions were added by this update.

Summary of changes:
 src/views/AutogenView.vue | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)



[GitHub] [cloudstack] blueorangutan commented on issue #3956: maven quality tool plugins

2020-03-25 Thread GitBox
blueorangutan commented on issue #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-604050076
 
 
   Trillian test result (tid-1302)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28513 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3956-t1302-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_supported_versions.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 0.34 | 
test_kubernetes_supported_versions.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
blueorangutan commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-604035896
 
 
   Trillian test result (tid-1299)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29376 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3988-t1299-xenserver-71.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 0.19 | 
test_kubernetes_supported_versions.py
   test_01_scale_vm | `Failure` | 14.33 | test_scale_vm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
blueorangutan commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-604035327
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
DaanHoogland commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-604034808
 
 
   @blueorangutan test centos7 vmware-67u3


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
blueorangutan commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-604032556
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
DaanHoogland commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-604032092
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
andrijapanicsb commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-604028742
 
 
   @shwstppr can you please take a look into the failing test if related at all?
   
   thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3954: Cloudstack Management Improper shutdown - causes mgmt to not start after reboot of server

2020-03-25 Thread GitBox
DaanHoogland commented on issue #3954: Cloudstack Management Improper shutdown 
- causes mgmt to not start after reboot of server
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-604027611
 
 
   fixed by #3973


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland closed issue #3954: Cloudstack Management Improper shutdown - causes mgmt to not start after reboot of server

2020-03-25 Thread GitBox
DaanHoogland closed issue #3954: Cloudstack Management Improper shutdown - 
causes mgmt to not start after reboot of server
URL: https://github.com/apache/cloudstack/issues/3954
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated (9b74a3a18 -> da865f0)

2020-03-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 9b74a3a18 maven quality tool plugins (#3956)
 add d93c245  systemd dependency on db (#3973)
 add da865f0  Merge release branch 4.13 to master

No new revisions were added by this update.

Summary of changes:
 packaging/systemd/cloudstack-agent.service  |  4 
 packaging/systemd/cloudstack-management.service |  8 +++-
 packaging/systemd/cloudstack-usage.service  | 11 +--
 3 files changed, 20 insertions(+), 3 deletions(-)



[GitHub] [cloudstack] blueorangutan commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
blueorangutan commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-604025259
 
 
   Trillian test result (tid-1300)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27892 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3988-t1300-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_supported_versions.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 0.15 | 
test_kubernetes_supported_versions.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch 4.13 updated: systemd dependency on db (#3973)

2020-03-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.13 by this push:
 new d93c245  systemd dependency on db (#3973)
d93c245 is described below

commit d93c2459a4afeff631604b8eb2b0c955f90af783
Author: dahn 
AuthorDate: Wed Mar 25 19:57:12 2020 +0100

systemd dependency on db (#3973)
---
 packaging/systemd/cloudstack-agent.service  |  4 
 packaging/systemd/cloudstack-management.service |  8 +++-
 packaging/systemd/cloudstack-usage.service  | 11 +--
 3 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/packaging/systemd/cloudstack-agent.service 
b/packaging/systemd/cloudstack-agent.service
index 72e99fe..e04d672 100644
--- a/packaging/systemd/cloudstack-agent.service
+++ b/packaging/systemd/cloudstack-agent.service
@@ -15,6 +15,10 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# Do not modify this file as your changes will be lost in the next CSM update.
+# If you need to add specific dependencies to this service unit do it in the
+# /etc/systemd/system/cloudstack-management.service.d/ directory
+
 [Unit]
 Description=CloudStack Agent
 Documentation=http://www.cloudstack.org/
diff --git a/packaging/systemd/cloudstack-management.service 
b/packaging/systemd/cloudstack-management.service
index 1f4ded3..b979f7f 100644
--- a/packaging/systemd/cloudstack-management.service
+++ b/packaging/systemd/cloudstack-management.service
@@ -16,10 +16,16 @@
 # under the License.
 
 # Systemd unit file for CloudStack Management server
+# Do not modify this file as your changes will be lost in the next CSM update.
+# If you need to add specific dependencies to this service unit do it in the
+# /etc/systemd/system/cloudstack-management.service.d/ directory
+# If you know that either mysql or mariadb is running on this system is a good 
idea to
+# add a Requires dependency there. Check systemd documentation for details
 
 [Unit]
 Description=CloudStack Management Server
-After=syslog.target network.target
+After=syslog.target network.target mariadb.service mysqld.service mysql.service
+Wants=mariadb.service mysqld.service mysql.service
 
 [Service]
 UMask=0022
diff --git a/packaging/systemd/cloudstack-usage.service 
b/packaging/systemd/cloudstack-usage.service
index 8d9dff2..c23814e 100644
--- a/packaging/systemd/cloudstack-usage.service
+++ b/packaging/systemd/cloudstack-usage.service
@@ -15,11 +15,18 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# Systemd unit file for CloudStack Management server
+# Do not modify this file as your changes will be lost in the next CSM update.
+# If you need to add specific dependencies to this service unit do it in the
+# /etc/systemd/system/cloudstack-management.service.d/ directory
+# If you know that either mysql or mariadb is running on this system is a good 
idea to
+# add a Requires dependency there. Check systemd documentation for details
+
 [Unit]
 Description=CloudStack Usage Server
 Documentation=http://www.cloudstack.org/
-Wants=network.target network-online.target
-After=network.target network-online.target
+Wants=network.target network-online.target mariadb.service mysqld.service 
mysql.service
+After=network.target network-online.target mariadb.service mysqld.service 
mysql.service
 
 [Service]
 Type=simple



[GitHub] [cloudstack] DaanHoogland merged pull request #3973: systemd dependency on db

2020-03-25 Thread GitBox
DaanHoogland merged pull request #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3980: Fix String.format unused/misused arguments

2020-03-25 Thread GitBox
GabrielBrascher commented on issue #3980: Fix String.format unused/misused 
arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604024689
 
 
   @DaanHoogland agreed, this one is not critical and can wait without any 
problem. Let's first focus on blockers for master and 4.13.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3973: systemd dependency on db

2020-03-25 Thread GitBox
blueorangutan commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-604023383
 
 
   Trillian test result (tid-1298)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30852 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3973-t1298-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 259.31 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 274.54 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 408.08 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3980: Fix String.format unused/misused arguments

2020-03-25 Thread GitBox
DaanHoogland commented on issue #3980: Fix String.format unused/misused 
arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604022841
 
 
   @GabrielBrascher if it need sto go in both 4.13, but it is not critical and 
we really need to get the critical stuff done, we can create .-releases for 
this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
nvazquez commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-604008212
 
 
   The rolling maintenance service is included as part of the cloudstack-agent 
package, it was mistakinly added as a package to enable by the dh_system_enable 
call. The fix is simply removing the call to enable the not existing package 
from the rules script


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3973: systemd dependency on db

2020-03-25 Thread GitBox
blueorangutan commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-604004905
 
 
   Trillian test result (tid-1297)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28532 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3973-t1297-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 206.10 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 171.89 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 237.42 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
blueorangutan commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-604002756
 
 
   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
andrijapanicsb commented on issue #3984: Remove rolling-maintenance service 
from debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-604002156
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland closed pull request #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
DaanHoogland closed pull request #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez opened a new pull request #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
nvazquez opened a new pull request #3984: Remove rolling-maintenance service 
from debian rules
URL: https://github.com/apache/cloudstack/pull/3984
 
 
   ## Description
   The cloudstack-rolling-maintenance service fails on ubuntu while packaging.
   
   Fixes: #3981 
   
   ## Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   ~/cloudstack/packaging# ./build-deb.sh
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3981: Cannot build packages with latest master on Ubuntu 18.04

2020-03-25 Thread GitBox
nvazquez commented on issue #3981: Cannot build packages with latest master on 
Ubuntu 18.04
URL: https://github.com/apache/cloudstack/issues/3981#issuecomment-604000811
 
 
   @andrijapanicsb PR 3984 tested and working as expeected, waiting for review 
and approval


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
nvazquez commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-603998555
 
 
   Update: finally built environment with ubuntu 18 KVM hosts and verified the 
rolling maintenance service works as expected 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3973: systemd dependency on db

2020-03-25 Thread GitBox
blueorangutan commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-603993628
 
 
   Trillian test result (tid-1296)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27432 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3973-t1296-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Smoke tests completed. 75 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 273.81 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 210.71 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 333.89 | 
test_privategw_acl.py
   test_01_scale_vm | `Failure` | 13.31 | test_scale_vm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] deargopinath commented on a change in pull request #3982: Updated 3 error messages to replace the word 'matches' with 'match'

2020-03-25 Thread GitBox
deargopinath commented on a change in pull request #3982: Updated 3 error 
messages to replace the word 'matches' with 'match'
URL: https://github.com/apache/cloudstack/pull/3982#discussion_r398002330
 
 

 ##
 File path: 
server/src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java
 ##
 @@ -428,13 +428,13 @@ private ServiceOfferingVO 
getUnmanagedInstanceServiceOffering(final UnmanagedIns
 serviceOffering = 
serviceOfferingDao.getComputeOffering(serviceOffering, parameters);
 } else {
 if (!cpu.equals(serviceOffering.getCpu()) && 
!instance.getPowerState().equals(UnmanagedInstanceTO.PowerState.PowerOff)) {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
String.format("Service offering (%s) %d CPU cores does not matches VM CPU cores 
%d  and VM is not in powered off state (Power state: %s)", 
serviceOffering.getUuid(), serviceOffering.getCpu(), cpu, 
instance.getPowerState()));
+throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
String.format("Service offering (%s) %d CPU cores does not match VM CPU cores 
%d  and VM is not in powered off state (Power state: %s)", 
serviceOffering.getUuid(), serviceOffering.getCpu(), cpu, 
instance.getPowerState()));
 
 Review comment:
   Hi Gabriel,  Thank you very much for the review. I made the 2 changes as per 
the review. I will submit the pull request shortly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
nvazquez commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-603943967
 
 
   Yes, ready for review. I haven't updated as was having failures non related 
to the PR to build an ubuntu18 environment. Would be good to test in ubuntu 16 
as well


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
weizhouapache commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-603941261
 
 
   > @nvazquez are we good here?
   > @weizhouapache can you review also please/LGTM it?
   
   is this ready for review/approve ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland closed pull request #3973: systemd dependency on db

2020-03-25 Thread GitBox
DaanHoogland closed pull request #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland opened a new pull request #3973: systemd dependency on db

2020-03-25 Thread GitBox
DaanHoogland opened a new pull request #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973
 
 
   ## Description
   
   
   
   
   
   
   
   
   Fixes: #3954
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
andrijapanicsb commented on issue #3984: Remove rolling-maintenance service 
from debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-603904058
 
 
   @nvazquez are we good here?
   @weizhouapache can you review also please/LGTM it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
andrijapanicsb commented on issue #3984: Remove rolling-maintenance service 
from debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-603904525
 
 
   anybody tested on Ubuntu 16 (any need to do so)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3981: Cannot build packages with latest master on Ubuntu 18.04

2020-03-25 Thread GitBox
andrijapanicsb commented on issue #3981: Cannot build packages with latest 
master on Ubuntu 18.04
URL: https://github.com/apache/cloudstack/issues/3981#issuecomment-603898957
 
 
   @nvazquez what's the update here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
blueorangutan commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-603825002
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1086


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated (51aa9ef -> 5043403)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from 51aa9ef  storage: add basic B support (#64)
 add 5043403  compute: add CKS support (#247)

No new revisions were added by this update.

Summary of changes:
 src/assets/icons/kubernetes.svg|  66 +++
 src/components/view/InfoCard.vue   |   3 +-
 src/config/section/compute.js  |  75 +++-
 src/config/section/image.js|  34 ++
 src/locales/en.json|  19 +-
 src/views/compute/CreateKubernetesCluster.vue  | 442 +
 src/views/compute/KubernetesServiceTab.vue | 432 
 src/views/compute/ScaleKubernetesCluster.vue   | 210 ++
 src/views/compute/UpgradeKubernetesCluster.vue | 186 +
 src/views/image/AddKubernetesSupportedVersion.vue  | 243 +++
 .../image/UpdateKubernetesSupportedVersion.vue | 168 
 11 files changed, 1867 insertions(+), 11 deletions(-)
 create mode 100644 src/assets/icons/kubernetes.svg
 create mode 100644 src/views/compute/CreateKubernetesCluster.vue
 create mode 100644 src/views/compute/KubernetesServiceTab.vue
 create mode 100644 src/views/compute/ScaleKubernetesCluster.vue
 create mode 100644 src/views/compute/UpgradeKubernetesCluster.vue
 create mode 100644 src/views/image/AddKubernetesSupportedVersion.vue
 create mode 100644 src/views/image/UpdateKubernetesSupportedVersion.vue



[GitHub] [cloudstack] blueorangutan commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
blueorangutan commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-603814158
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-03-25 Thread GitBox
nvazquez commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-603813730
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3980: Fix String.format unused/misused arguments

2020-03-25 Thread GitBox
GabrielBrascher commented on issue #3980: Fix String.format unused/misused 
arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-603802857
 
 
   @DaanHoogland @andrijapanicsb should I aim this PR to 4.13 or let's leave it 
for later? Not critical but it still messing with a few log messages.
   
   You are the RM for 4.13.1/4.14.0, so I leave such decision to you guys ;-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated (b15749a -> 51aa9ef)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from b15749a  config: add event timeline support
 add 51aa9ef  storage: add basic B support (#64)

No new revisions were added by this update.

Summary of changes:
 src/components/view/DetailsTab.vue |  5 
 src/components/view/InfoCard.vue   | 32 -
 src/config/section/compute.js  | 59 ++
 src/config/section/offering.js | 20 +
 src/config/section/storage.js  | 52 +
 src/locales/en.json|  4 ++-
 6 files changed, 158 insertions(+), 14 deletions(-)



[GitHub] [cloudstack] borisstoyanov closed issue #3978: systemvms do not come up on vmware

2020-03-25 Thread GitBox
borisstoyanov closed issue #3978: systemvms do not come up on vmware
URL: https://github.com/apache/cloudstack/issues/3978
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3978: systemvms do not come up on vmware

2020-03-25 Thread GitBox
borisstoyanov commented on issue #3978: systemvms do not come up on vmware
URL: https://github.com/apache/cloudstack/issues/3978#issuecomment-603785892
 
 
   fixed in #3985 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated (577eb66 -> b15749a)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from 577eb66  store: reset internal data on login/logout
 add b15749a  config: add event timeline support

No new revisions were added by this update.

Summary of changes:
 src/config/section/event.js | 5 +
 1 file changed, 5 insertions(+)



[cloudstack-primate] branch master updated (1d930ff -> 577eb66)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from 1d930ff  zone: fix lint issue in wizard
 add 577eb66  store: reset internal data on login/logout

No new revisions were added by this update.

Summary of changes:
 src/store/getters.js  |  1 -
 src/store/modules/user.js | 20 ++--
 src/utils/util.js |  6 --
 3 files changed, 14 insertions(+), 13 deletions(-)



[cloudstack] branch master updated (08699aa -> 9b74a3a18)

2020-03-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 08699aa  NPE fix for System VM's start Command (#3985)
 add 9b74a3a18 maven quality tool plugins (#3956)

No new revisions were added by this update.

Summary of changes:
 pom.xml  | 238 ---
 tools/checkstyle/pom.xml |  15 +++
 2 files changed, 197 insertions(+), 56 deletions(-)



[GitHub] [cloudstack] DaanHoogland merged pull request #3956: maven quality tool plugins

2020-03-25 Thread GitBox
DaanHoogland merged pull request #3956: maven quality tool plugins
URL: https://github.com/apache/cloudstack/pull/3956
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3982: Updated 3 error messages to replace the word 'matches' with 'match'

2020-03-25 Thread GitBox
GabrielBrascher commented on a change in pull request #3982: Updated 3 error 
messages to replace the word 'matches' with 'match'
URL: https://github.com/apache/cloudstack/pull/3982#discussion_r397756642
 
 

 ##
 File path: 
server/src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java
 ##
 @@ -428,13 +428,13 @@ private ServiceOfferingVO 
getUnmanagedInstanceServiceOffering(final UnmanagedIns
 serviceOffering = 
serviceOfferingDao.getComputeOffering(serviceOffering, parameters);
 } else {
 if (!cpu.equals(serviceOffering.getCpu()) && 
!instance.getPowerState().equals(UnmanagedInstanceTO.PowerState.PowerOff)) {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
String.format("Service offering (%s) %d CPU cores does not matches VM CPU cores 
%d  and VM is not in powered off state (Power state: %s)", 
serviceOffering.getUuid(), serviceOffering.getCpu(), cpu, 
instance.getPowerState()));
+throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
String.format("Service offering (%s) %d CPU cores does not match VM CPU cores 
%d  and VM is not in powered off state (Power state: %s)", 
serviceOffering.getUuid(), serviceOffering.getCpu(), cpu, 
instance.getPowerState()));
 
 Review comment:
   Additionally, considering the fact that **CPU cores** is plural (of a _CPU 
core_) it should be "CPU core**s do** not **match**"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3982: Updated 3 error messages to replace the word 'matches' with 'match'

2020-03-25 Thread GitBox
GabrielBrascher commented on a change in pull request #3982: Updated 3 error 
messages to replace the word 'matches' with 'match'
URL: https://github.com/apache/cloudstack/pull/3982#discussion_r397756101
 
 

 ##
 File path: 
server/src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java
 ##
 @@ -428,13 +428,13 @@ private ServiceOfferingVO 
getUnmanagedInstanceServiceOffering(final UnmanagedIns
 serviceOffering = 
serviceOfferingDao.getComputeOffering(serviceOffering, parameters);
 } else {
 if (!cpu.equals(serviceOffering.getCpu()) && 
!instance.getPowerState().equals(UnmanagedInstanceTO.PowerState.PowerOff)) {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
String.format("Service offering (%s) %d CPU cores does not matches VM CPU cores 
%d  and VM is not in powered off state (Power state: %s)", 
serviceOffering.getUuid(), serviceOffering.getCpu(), cpu, 
instance.getPowerState()));
+throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
String.format("Service offering (%s) %d CPU cores does not match VM CPU cores 
%d  and VM is not in powered off state (Power state: %s)", 
serviceOffering.getUuid(), serviceOffering.getCpu(), cpu, 
instance.getPowerState()));
 
 Review comment:
   Can you please remove the extra blank space at `CPU cores %d  and VM`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint

2020-03-25 Thread GitBox
DaanHoogland commented on issue #3986: Change listVpcOfferings endpoint and 
createVpcOffering endpoint
URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-603772244
 
 
   hope you manage @radu-stefanache . point to keep in mind uis that we can not 
ever allow altering offerings as they might be in use elsewhere and by other 
people in other locations in the system and unpredictable things happen if you 
allow that. 
   happy coding


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
blueorangutan commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-603771564
 
 
   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
DaanHoogland commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-603771152
 
 
   just to be sure
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] radu-todirica commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint

2020-03-25 Thread GitBox
radu-todirica commented on issue #3986: Change listVpcOfferings endpoint and 
createVpcOffering endpoint
URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-603762821
 
 
   Thanks @weizhouapache and @DaanHoogland for your feedback. I will do the 
changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
andrijapanicsb commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-603760934
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
weizhouapache commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-603757679
 
 
   > @ustcweizhou as you've added zulu-11 as the dependency/to be installed, do 
you think this should fail if previously the proper repo/key is not added (per 
your instructions in this PR) ?
   
   @andrijapanicsb if other java11 package can be( or has been) installed, 
cloudstack installation/upgrade will not fail. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint

2020-03-25 Thread GitBox
weizhouapache commented on issue #3986: Change listVpcOfferings endpoint and 
createVpcOffering endpoint
URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-603755062
 
 
   > @weizhouapache i agree that offerings should not be editable as they can 
be in use, but what is the harm in adding the offering to the create API?
   
   @DaanHoogland  I am ok with adding router offering to createVpcOffering, 
similar as createNetworkOffering.
   
   However, the network/vpc will be shutdown if we change a network/vpc to 
another offering. It would be nice to create a new VR before we destroy current 
running VR, like @rhtyd did when restart Network/vpc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3973: systemd dependency on db

2020-03-25 Thread GitBox
andrijapanicsb commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-603749724
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3973: systemd dependency on db

2020-03-25 Thread GitBox
blueorangutan commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-603749918
 
 
   @andrijapanicsb a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
rhtyd commented on issue #3988: Add support for zulu-11 in cloudstack 4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-603748426
 
 
   Packaging is okay, we can do a normal install/upgrade on Ubuntu for testing. 
If you see the change it's simply adding an optional package name if openjdk-11 
is not available @DaanHoogland @andrijapanicsb 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3990: Under arm64 host environment VM console does not display properly

2020-03-25 Thread GitBox
rhtyd commented on issue #3990: Under arm64 host environment VM console does 
not display properly
URL: https://github.com/apache/cloudstack/issues/3990#issuecomment-603747988
 
 
   @zhao21943266 you may google that I've not explored that myself the exact 
steps. I'll be updating new templates against Debian10 once 4.14 is out.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated (fdcfb06 -> 1d930ff)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from fdcfb06  infra: add zone wizard (#167)
 add 1d930ff  zone: fix lint issue in wizard

No new revisions were added by this update.

Summary of changes:
 src/views/infra/zone/ZoneWizardLaunchZone.vue | 1 -
 1 file changed, 1 deletion(-)



[GitHub] [cloudstack] andrijapanicsb commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
andrijapanicsb commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-603745646
 
 
   @ustcweizhou as you've added zulu-11 as the dependency/to be installed, do 
you think this should fail if previously the proper repo/key is not added (per 
your instructions in this PR) ?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated (085135d -> fdcfb06)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from 085135d  autogenview: fill edit form field values (#227)
 add fdcfb06  infra: add zone wizard (#167)

No new revisions were added by this update.

Summary of changes:
 src/locales/en.json|  162 +-
 src/utils/request.js   |2 +-
 src/views/infra/zone/AdvancedGuestTrafficForm.vue  |  216 ++
 src/views/infra/zone/IpAddressRangeForm.vue|  258 +++
 src/views/infra/zone/StaticInputsForm.vue  |  277 +++
 src/views/infra/zone/ZoneWizard.vue|  192 +-
 src/views/infra/zone/ZoneWizardAddResources.vue|  898 
 src/views/infra/zone/ZoneWizardLaunchZone.vue  | 2168 
 .../infra/zone/ZoneWizardNetworkSetupStep.vue  |  444 
 .../zone/ZoneWizardPhysicalNetworkSetupStep.vue|  501 +
 src/views/infra/zone/ZoneWizardZoneDetailsStep.vue |  599 ++
 src/views/infra/zone/ZoneWizardZoneTypeStep.vue|  153 ++
 vue.config.js  |3 +-
 13 files changed, 5862 insertions(+), 11 deletions(-)
 create mode 100644 src/views/infra/zone/AdvancedGuestTrafficForm.vue
 create mode 100644 src/views/infra/zone/IpAddressRangeForm.vue
 create mode 100644 src/views/infra/zone/StaticInputsForm.vue
 create mode 100644 src/views/infra/zone/ZoneWizardAddResources.vue
 create mode 100644 src/views/infra/zone/ZoneWizardLaunchZone.vue
 create mode 100644 src/views/infra/zone/ZoneWizardNetworkSetupStep.vue
 create mode 100644 src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue
 create mode 100644 src/views/infra/zone/ZoneWizardZoneDetailsStep.vue
 create mode 100644 src/views/infra/zone/ZoneWizardZoneTypeStep.vue



[GitHub] [cloudstack] DaanHoogland commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint

2020-03-25 Thread GitBox
DaanHoogland commented on issue #3986: Change listVpcOfferings endpoint and 
createVpcOffering endpoint
URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-603727204
 
 
   @weizhouapache i agree that offerings should not be editable as they can be 
in use, but what is the harm in adding the offering to the create API?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3988: Add support for zulu-11 in cloudstack 4.14

2020-03-25 Thread GitBox
DaanHoogland commented on issue #3988: Add support for zulu-11 in cloudstack 
4.14
URL: https://github.com/apache/cloudstack/pull/3988#issuecomment-603724240
 
 
   great @weizhouapache formaly we need another tester but in view of the code 
I am not bothered, @andrijapanicsb ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated: NPE fix for System VM's start Command (#3985)

2020-03-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 08699aa  NPE fix for System VM's start Command (#3985)
08699aa is described below

commit 08699aa69076b6479bf9544f1375917e51be6a36
Author: pavanaravapalli 
AuthorDate: Wed Mar 25 14:31:13 2020 +0530

NPE fix for System VM's start Command (#3985)

Co-authored-by: Pavan Kumar Aravapalli 
---
 .../main/java/com/cloud/hypervisor/guru/VMwareGuru.java |  2 +-
 .../hypervisor/vmware/resource/VmwareResource.java  |  4 ++--
 .../java/com/cloud/hypervisor/HypervisorGuruBase.java   | 17 ++---
 3 files changed, 17 insertions(+), 6 deletions(-)

diff --git 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java
 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java
index 4e8acad..59b27bd 100644
--- 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java
+++ 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java
@@ -294,7 +294,7 @@ public class VMwareGuru extends HypervisorGuruBase 
implements HypervisorGuru, Co
 }
 }
 
-details.put(VmDetailConstants.BOOT_MODE, to.getBootType());
+details.put(VmDetailConstants.BOOT_MODE, to.getBootMode());
 String diskDeviceType = 
details.get(VmDetailConstants.ROOT_DISK_CONTROLLER);
 if (userVm) {
 if (diskDeviceType == null) {
diff --git 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
index 5a1459d..cc732f4 100644
--- 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
+++ 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@ -1724,7 +1724,7 @@ public class VmwareResource implements 
StoragePoolResource, ServerResource, Vmwa
 String dataDiskController = 
vmSpec.getDetails().get(VmDetailConstants.DATA_DISK_CONTROLLER);
 String rootDiskController = 
vmSpec.getDetails().get(VmDetailConstants.ROOT_DISK_CONTROLLER);
 DiskTO rootDiskTO = null;
-String bootMode = ApiConstants.BootType.BIOS.toString();
+String bootMode = "bios";
 if (vmSpec.getDetails().containsKey(VmDetailConstants.BOOT_MODE)) {
 bootMode = vmSpec.getDetails().get(VmDetailConstants.BOOT_MODE);
 }
@@ -2286,7 +2286,7 @@ public class VmwareResource implements 
StoragePoolResource, ServerResource, Vmwa
 }
 }
 
-if 
(!bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
+if (StringUtils.isNotBlank(bootMode) && 
!bootMode.equalsIgnoreCase("bios")) {
 vmConfigSpec.setFirmware("efi");
 if 
(vmSpec.getDetails().containsKey(ApiConstants.BootType.UEFI.toString()) && 
"secure".equalsIgnoreCase(vmSpec.getDetails().get(ApiConstants.BootType.UEFI.toString(
 {
 VirtualMachineBootOptions bootOptions = new 
VirtualMachineBootOptions();
diff --git a/server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java 
b/server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
index 0c3263a..2ae35fc 100644
--- a/server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
+++ b/server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
@@ -26,6 +26,7 @@ import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.backup.Backup;
 import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
 import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.collections.MapUtils;
 import org.apache.log4j.Logger;
 
 import com.cloud.agent.api.Command;
@@ -172,9 +173,19 @@ public abstract class HypervisorGuruBase extends 
AdapterBase implements Hypervis
 offering.getRamSize() * 1024l * 1024l, null, null, 
vm.isHaEnabled(), vm.limitCpuUse(), vm.getVncPassword());
 to.setBootArgs(vmProfile.getBootArgs());
 
-String bootType = (String)vmProfile.getParameter(new 
VirtualMachineProfile.Param("BootType"));
-if (StringUtils.isNotBlank(bootType)) {
-to.setBootType(bootType);
+Map map = 
vmProfile.getParameters();
+if (MapUtils.isNotEmpty(map)) {
+if (map.containsKey(VirtualMachineProfile.Param.BootMode)) {
+if (StringUtils.isNotBlank((String) 
map.get(VirtualMachineProfile.Param.BootMode))) {
+to.setBootMode((String) 
map.get(VirtualMachineProfile.Param.BootMode));
+}
+}
+
+if (map.containsKey(VirtualMachineProfile.Param.BootType)) {

[GitHub] [cloudstack] DaanHoogland merged pull request #3985: NPE fix for System VM's start Command

2020-03-25 Thread GitBox
DaanHoogland merged pull request #3985:  NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] harikrishna-patnala edited a comment on issue #3031: VMware basic zone VR fails to start and get private IP

2020-03-25 Thread GitBox
harikrishna-patnala edited a comment on issue #3031: VMware basic zone VR fails 
to start and get private IP
URL: https://github.com/apache/cloudstack/issues/3031#issuecomment-603698469
 
 
   Working on this to fix the issue. I could point out the exact place where 
nic configuring is being skipped and made the code changes accordingly in PR 
https://github.com/apache/cloudstack/pull/3977
   
   ![Screen Shot 2020-03-25 at 12 52 32 
PM](https://user-images.githubusercontent.com/3348673/77515184-15ed9000-6e9e-11ea-8aa0-e262e12e5d46.png)
   
   ![Screen Shot 2020-03-25 at 12 25 54 
PM](https://user-images.githubusercontent.com/3348673/77514122-40d6e480-6e9c-11ea-82f6-6f16141eb471.png)
   
   With that eth1 on VR is configured with private IP but VR is still stuck in 
starting state because it is not able to run checkSshCommand on port 3922
   ![Screen Shot 2020-03-25 at 12 50 33 
PM](https://user-images.githubusercontent.com/3348673/77515209-230a7f00-6e9e-11ea-939d-378e88860631.png)
   
   
   2020-03-25 06:57:18,683 INFO  [c.c.h.v.r.VmwareResource] 
(DirectAgent-336:ctx-7579bce4 10.2.3.159, job-37/job-38, cmd: CheckSshCommand) 
(logid:b696c8c5) **Trying to connect to 10.2.5.224**
   2020-03-25 06:57:18,686 INFO  [c.c.h.v.r.VmwareResource] 
(DirectAgent-336:ctx-7579bce4 10.2.3.159, job-37/job-38, cmd: CheckSshCommand) 
(logid:b696c8c5) **Could not connect to 10.2.5.224 due to 
java.net.ConnectException: Connection refused**
   
   VR Iptables has input chain configured on eth1 3922 port and packets are 
hitting.
   
   Can someone help me debugging further on what is missing in terms of 
connectivity
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] harikrishna-patnala commented on issue #3031: VMware basic zone VR fails to start and get private IP

2020-03-25 Thread GitBox
harikrishna-patnala commented on issue #3031: VMware basic zone VR fails to 
start and get private IP
URL: https://github.com/apache/cloudstack/issues/3031#issuecomment-603698469
 
 
   Working on this to fix the issue. I could point out the exact place where 
nic configuring is being skipped and made the code changes accordingly in PR 
https://github.com/apache/cloudstack/pull/3977
   
   
   ![Screen Shot 2020-03-25 at 12 25 54 
PM](https://user-images.githubusercontent.com/3348673/77514122-40d6e480-6e9c-11ea-82f6-6f16141eb471.png)
   
   With that eth1 on VR is configured with private IP but VR is still stuck in 
starting state because it is not able to run checkSshCommand on port 3922
   
   2020-03-25 06:57:18,683 INFO  [c.c.h.v.r.VmwareResource] 
(DirectAgent-336:ctx-7579bce4 10.2.3.159, job-37/job-38, cmd: CheckSshCommand) 
(logid:b696c8c5) **Trying to connect to 10.2.5.224**
   2020-03-25 06:57:18,686 INFO  [c.c.h.v.r.VmwareResource] 
(DirectAgent-336:ctx-7579bce4 10.2.3.159, job-37/job-38, cmd: CheckSshCommand) 
(logid:b696c8c5) **Could not connect to 10.2.5.224 due to 
java.net.ConnectException: Connection refused**
   
   VR Iptables has input chain configured on eth1 3922 port and packets are 
hitting.
   
   Can someone help me debugging further on what is missing in terms of 
connectivity
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] zhao21943266 commented on issue #3990: Under arm64 host environment VM console does not display properly

2020-03-25 Thread GitBox
zhao21943266 commented on issue #3990: Under arm64 host environment VM console 
does not display properly
URL: https://github.com/apache/cloudstack/issues/3990#issuecomment-603695053
 
 
   @rhtyd Hello, I tested that the image console of Debian 10 can display 
normally. Can you tell me how to manually start the Debian 9 system template 
console. Thank


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] zhao21943266 commented on issue #3990: Under arm64 host environment VM console does not display properly

2020-03-25 Thread GitBox
zhao21943266 commented on issue #3990: Under arm64 host environment VM console 
does not display properly
URL: https://github.com/apache/cloudstack/issues/3990#issuecomment-603683336
 
 
   @rhtyd Thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated (84bede2 -> db2e213)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 84bede2  Updated upgrade paths (#3972)
 add 2e3390f  server: export full response view for zones response when 
caller is root admin (#3989)
 new db2e213  Merge remote-tracking branch 'origin/4.13'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 server/src/main/java/com/cloud/api/query/QueryManagerImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13'

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit db2e2136ddf11dbc5dfb133008269930414203b3
Merge: 84bede2 2e3390f
Author: Rohit Yadav 
AuthorDate: Wed Mar 25 12:54:21 2020 +0530

Merge remote-tracking branch 'origin/4.13'

 server/src/main/java/com/cloud/api/query/QueryManagerImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)




[GitHub] [cloudstack] rhtyd merged pull request #3989: server: export full response view for zones response for root admin

2020-03-25 Thread GitBox
rhtyd merged pull request #3989: server: export full response view for zones 
response for root admin
URL: https://github.com/apache/cloudstack/pull/3989
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch 4.13 updated: server: export full response view for zones response when caller is root admin (#3989)

2020-03-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.13 by this push:
 new 2e3390f  server: export full response view for zones response when 
caller is root admin (#3989)
2e3390f is described below

commit 2e3390f06e11400237d68929e4095376b13574d8
Author: Rohit Yadav 
AuthorDate: Wed Mar 25 12:53:41 2020 +0530

server: export full response view for zones response when caller is root 
admin (#3989)

The listZonesMetrics does not return same keys are listZones as the
default response view is restricted. This fixes that by ensuring that
for root admin full response view is used.

Signed-off-by: Rohit Yadav 
---
 server/src/main/java/com/cloud/api/query/QueryManagerImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java 
b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
index c815be8..d55aea4 100644
--- a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
+++ b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
@@ -2881,7 +2881,7 @@ public class QueryManagerImpl extends 
MutualExclusiveIdsManagerBase implements Q
 ListResponse response = new ListResponse();
 
 ResponseView respView = ResponseView.Restricted;
-if (cmd instanceof ListZonesCmdByAdmin) {
+if (cmd instanceof ListZonesCmdByAdmin || 
CallContext.current().getCallingAccount().getType() == 
Account.ACCOUNT_TYPE_ADMIN) {
 respView = ResponseView.Full;
 }
 



[GitHub] [cloudstack] rhtyd commented on issue #3990: Under arm64 host environment VM console does not display properly

2020-03-25 Thread GitBox
rhtyd commented on issue #3990: Under arm64 host environment VM console does 
not display properly
URL: https://github.com/apache/cloudstack/issues/3990#issuecomment-603682273
 
 
   @zhao21943266 the custom arm64 systemvmtemplate I had built was based on 
Debian9 where the console is disabled by default (to save RAM) which is why you 
don't see it. You may manually enable it to see it for systemvms/VRs, and for 
the guest VMs the console is enabled for Debian 10 guest template: 
http://dl.rohityadav.cloud/cloudstack-rpi/template/
   
   Closing on this remark as this is not really a bug and the arm64 support is 
rather new and experimental (just my own experiment than something that is 
fully supported by the project).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd closed issue #3990: Under arm64 host environment VM console does not display properly

2020-03-25 Thread GitBox
rhtyd closed issue #3990: Under arm64 host environment VM console does not 
display properly
URL: https://github.com/apache/cloudstack/issues/3990
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3973: systemd dependency on db

2020-03-25 Thread GitBox
blueorangutan commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-603681237
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1085


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] Spaceman1984 commented on issue #3973: systemd dependency on db

2020-03-25 Thread GitBox
Spaceman1984 commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-603675929
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3973: systemd dependency on db

2020-03-25 Thread GitBox
blueorangutan commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-603676139
 
 
   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] Spaceman1984 removed a comment on issue #3954: Cloudstack Management Improper shutdown - causes mgmt to not start after reboot of server

2020-03-25 Thread GitBox
Spaceman1984 removed a comment on issue #3954: Cloudstack Management Improper 
shutdown - causes mgmt to not start after reboot of server
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-603675524
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] Spaceman1984 commented on issue #3954: Cloudstack Management Improper shutdown - causes mgmt to not start after reboot of server

2020-03-25 Thread GitBox
Spaceman1984 commented on issue #3954: Cloudstack Management Improper shutdown 
- causes mgmt to not start after reboot of server
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-603675524
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] zhao21943266 opened a new issue #3990: Under arm64 host environment VM console does not display properly

2020-03-25 Thread GitBox
zhao21943266 opened a new issue #3990: Under arm64 host environment VM console 
does not display properly
URL: https://github.com/apache/cloudstack/issues/3990
 
 
   
   Run cloudstack and agent in arm64 Ubuntu. At present, both the host and SVM 
are running. View the virtual machine through the console and it cannot be 
displayed. The prompt "guest has not initialized the display (yet)" is the same 
as that of opening the console through virt manager;The virtual machine is 
running normally and can enter the virtual machine through the virsh console 
f460826a-bb58-49ff-b446-955773abc513。
   # ISSUE TYPE
   
* Bug Report
   
   
   # COMPONENT NAME
   
   ~~~
   view console
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.13.1.0
   ~~~
   
   # CONFIGURATION
   
   console proxy
   # OS / ENVIRONMENT
   
   
   Ubuntu 18.04
   # SUMMARY
   
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   
   ~~~
   
   
   # ACTUAL RESULTS
   
   
![image](https://user-images.githubusercontent.com/52068346/77508699-40dbe200-6ea6-11ea-9cc6-abcdc3796a60.png)
   
![image](https://user-images.githubusercontent.com/52068346/77508758-69fc7280-6ea6-11ea-92ee-23e8a7cf5939.png)
   
   
   ~~~
   
   
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services