[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643081171 Packaging result: ✔centos7 ✔debian. JID-1358 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-06-11 Thread GitBox
harikrishna-patnala commented on pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643080537 @rhtyd, This was tested by @borisstoyanov. we can merge this after a final review if required.

[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-643078553 Packaging result: ✖centos7 ✔debian. JID-1354 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643078555 Packaging result: ✔centos7 ✔debian. JID-1355 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-06-11 Thread GitBox
blueorangutan commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-643078557 Packaging result: ✔centos7 ✔debian. JID-1357 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc

2020-06-11 Thread GitBox
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643078554 Packaging result: ✔centos7 ✔debian. JID-1356 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4073: Display network name for IP in shared networks

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4073: URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643078059 Packaging result: ✔centos7 ✔debian. JID-1352 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-643078058 Packaging result: ✖centos7 ✖debian. JID-1353 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-643076604 Packaging result: ✔centos7 ✖debian. JID-1350 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4075: Search VR using redundant state

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-643076603 Packaging result: ✖centos7 ✔debian. JID-1351 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643071719 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

2020-06-11 Thread GitBox
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643071390 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #3881: Deploy VM add host gpu device available check

2020-06-11 Thread GitBox
rhtyd commented on pull request #3881: URL: https://github.com/apache/cloudstack/pull/3881#issuecomment-643066810 I tried to close and re-open the PR to rekick Travis... @div8cn I'm unable to reopen the PR, it says the source repo has been deleted. Can you check and re-submit the PR if

[GitHub] [cloudstack] rhtyd commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-06-11 Thread GitBox
rhtyd commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-643066463 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[cloudstack] branch master updated (9beec48 -> a9175d3)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 9beec48 docker: upgrade to ubuntu 18.04 and fix two issues (#3955) add 8b234bd kvm: fix

[cloudstack] branch 4.14 updated (43cb781 -> 4659cff)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 43cb781 Merge remote-tracking branch 'origin/4.13' into 4.14 add 8b234bd kvm: fix CloudRuntimeException in

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 4659cff59703458af8a817e17b176aaff1648445 Merge: 43cb781 8b234bd Author: Rohit Yadav AuthorDate: Fri Jun 12 10:38:30

[GitHub] [cloudstack] rhtyd commented on pull request #3730: Update VR's scripts from python2 to python3

2020-06-11 Thread GitBox
rhtyd commented on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-643067101 @GabrielBrascher any update for us, you still working on this? Thanks. This is an automated message from the

[GitHub] [cloudstack] rhtyd commented on pull request #3595: [WIP DO NOT MERGE] KVM dynamic VM scaling

2020-06-11 Thread GitBox
rhtyd commented on pull request #3595: URL: https://github.com/apache/cloudstack/pull/3595#issuecomment-643067266 Okay @nvazquez keep me posted when this is ready for review. Thanks. This is an automated message from the

[GitHub] [cloudstack] rhtyd closed pull request #3881: Deploy VM add host gpu device available check

2020-06-11 Thread GitBox
rhtyd closed pull request #3881: URL: https://github.com/apache/cloudstack/pull/3881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-06-11 Thread GitBox
blueorangutan commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-643066680 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc

2020-06-11 Thread GitBox
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643066450 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd closed pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-06-11 Thread GitBox
rhtyd closed pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #3900: systemvm: configurable root disk size based on new systemvm template definition

2020-06-11 Thread GitBox
rhtyd commented on pull request #3900: URL: https://github.com/apache/cloudstack/pull/3900#issuecomment-643066572 @ustcweizhou do we want this for master/4.15+? Can you fix conflicts? This is an automated message from the

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-06-11 Thread GitBox
ustcweizhou opened a new pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902 ## Description This PR aims to fix the issue below 1. Create a network offering for isolated network, services: Dns/Dhcp/Userdata, and enable it 2. create a isolated

[cloudstack] branch 4.13 updated: kvm: fix CloudRuntimeException in volume stats for migrated volume (#3949)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.13 by this push: new 8b234bd kvm: fix CloudRuntimeException in

[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc

2020-06-11 Thread GitBox
rhtyd commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643066318 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd merged pull request #3949: Fix: catch CloudRuntimeException in LibvirtGetVolumeStatsCommandWrapper.java

2020-06-11 Thread GitBox
rhtyd merged pull request #3949: URL: https://github.com/apache/cloudstack/pull/3949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-06-11 Thread GitBox
rhtyd commented on pull request #3955: URL: https://github.com/apache/cloudstack/pull/3955#issuecomment-643065675 This cannot be checked without docker building the dockerfile, we've enough +1/lgtm/thumbsup so I'll merge this.

[cloudstack] branch master updated (6e47c49 -> 9beec48)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 6e47c49 server: Fix String.format arguments (#3980) add 9beec48 docker: upgrade to ubuntu 18.04 and fix

[GitHub] [cloudstack] rhtyd merged pull request #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-06-11 Thread GitBox
rhtyd merged pull request #3955: URL: https://github.com/apache/cloudstack/pull/3955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #3976: [Do not merge] Enable sending hypervior host name via metadata - VR and Config Drive

2020-06-11 Thread GitBox
rhtyd commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-643065386 @borisstoyanov @vladimirpetrov has this passed testing, is it ready for review and merge? Thanks. This is an

[GitHub] [cloudstack] rhtyd commented on pull request #3980: Fix String.format unused/misused arguments

2020-06-11 Thread GitBox
rhtyd commented on pull request #3980: URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-643065113 This is purely logging change, Travis has passed we don't need explicit smoketests for this. This is an

[GitHub] [cloudstack] rhtyd merged pull request #3980: Fix String.format unused/misused arguments

2020-06-11 Thread GitBox
rhtyd merged pull request #3980: URL: https://github.com/apache/cloudstack/pull/3980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[cloudstack] branch master updated (9727548 -> 6e47c49)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 9727548 kvm: Add support for DPDK trunk interfaces (#4048) add 6e47c49 server: Fix String.format arguments

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3980: Fix String.format unused/misused arguments

2020-06-11 Thread GitBox
blueorangutan removed a comment on pull request #3980: URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-605387706 Trillian test result (tid-1330) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58457 seconds Marvin logs:

[GitHub] [cloudstack] rhtyd commented on pull request #3982: Updated 3 error messages to replace the word 'matches' with 'match'

2020-06-11 Thread GitBox
rhtyd commented on pull request #3982: URL: https://github.com/apache/cloudstack/pull/3982#issuecomment-643064753 Let's merge this once Travis passes Fixes #3642 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling

2020-06-11 Thread GitBox
blueorangutan commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-643064253 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd edited a comment on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-06-11 Thread GitBox
rhtyd edited a comment on pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643064218 @harikrishna-patnala @borisstoyanov - is this ready for merge post-testing, if we do a final review?

[GitHub] [cloudstack] rhtyd commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-06-11 Thread GitBox
rhtyd commented on pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643064218 @harikrishna-patnala @borisstoyanov - is this ready for merge post-testing, if we a final review? This is an

[GitHub] [cloudstack] rhtyd closed pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-06-11 Thread GitBox
rhtyd closed pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling

2020-06-11 Thread GitBox
rhtyd commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-643063895 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-643063430 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643063507 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm

2020-06-11 Thread GitBox
rhtyd commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-643063586 @ustcweizhou please check and address Travis failures This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

2020-06-11 Thread GitBox
rhtyd commented on a change in pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001#discussion_r439205308 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -1321,6 +1321,11 @@ private HypervisorType

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-11 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643063124 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-643063240 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4003: Logging framework to use only log4j

2020-06-11 Thread GitBox
blueorangutan removed a comment on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-641691692 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-643063177 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4003: Logging framework to use only log4j

2020-06-11 Thread GitBox
rhtyd commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-643063307 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4007: Restarting all networks that needs a restart in a VPC

2020-06-11 Thread GitBox
blueorangutan removed a comment on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-641544436 Trillian test result (tid-1653) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60402 seconds Marvin logs:

[GitHub] [cloudstack] rhtyd commented on pull request #4007: Restarting all networks that needs a restart in a VPC

2020-06-11 Thread GitBox
rhtyd commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-643063051 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2020-06-11 Thread GitBox
rhtyd commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-643062751 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

2020-06-11 Thread GitBox
rhtyd commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-643062600 Is this ready for review, and can it be merged after review @davidjumani @borisstoyanov ? This is an

[cloudstack] branch master updated (195385f -> 9727548)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 195385f ui: Allow set IPv6 when deploying advanced network Zone with SG via UI (#4083) add 9727548 kvm:

[GitHub] [cloudstack] rhtyd merged pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

2020-06-11 Thread GitBox
rhtyd merged pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

2020-06-11 Thread GitBox
rhtyd commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-643062351 Travis has passed, our smoketests test only kvm with bridge driver. Merging based on this. This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #4073: Display network name for IP in shared networks

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4073: URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643061449 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-11 Thread GitBox
rhtyd commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-643061308 Thanks @sureshanaparti I'll do another review pass and ping you. This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #4075: Search VR using redundant state

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-643061192 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd closed pull request #4073: Display network name for IP in shared networks

2020-06-11 Thread GitBox
rhtyd closed pull request #4073: URL: https://github.com/apache/cloudstack/pull/4073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #4073: Display network name for IP in shared networks

2020-06-11 Thread GitBox
rhtyd commented on pull request #4073: URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643061185 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4075: Search VR using redundant state

2020-06-11 Thread GitBox
rhtyd commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-643061078 Business layer change, explicit smoketests not necessary as Travis passed. @blueorangutan package

[GitHub] [cloudstack] rhtyd merged pull request #4083: Allow set IPv6 when deploying advanced network Zone with SG via UI

2020-06-11 Thread GitBox
rhtyd merged pull request #4083: URL: https://github.com/apache/cloudstack/pull/4083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[cloudstack] branch master updated (9361fef -> 195385f)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 9361fef Merge remote-tracking branch 'origin/4.14' add 195385f ui: Allow set IPv6 when deploying advanced

[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-643060512 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-643060324 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4084: Added nfs minor version support on SSVM

2020-06-11 Thread GitBox
rhtyd commented on a change in pull request #4084: URL: https://github.com/apache/cloudstack/pull/4084#discussion_r439202556 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java ## @@ -831,8 +832,12 @@ protected

[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4122: URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643060393 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-11 Thread GitBox
rhtyd commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-643060179 Is this ready for review @nvazquez ? This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] rhtyd commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-11 Thread GitBox
rhtyd commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-643060060 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rhtyd commented on pull request #4085: Fix duplicate user entries for vpn usage

2020-06-11 Thread GitBox
rhtyd commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-643060225 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-643060041 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

2020-06-11 Thread GitBox
rhtyd commented on pull request #4122: URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643059963 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4132: Fix delete network with no services

2020-06-11 Thread GitBox
rhtyd commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-643059845 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643059824 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2020-06-11 Thread GitBox
rhtyd commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643059727 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[cloudstack] branch master updated (e02801b -> 9361fef)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from e02801b xenserver: add support for XCP-ng 7/8 to create it's heartbeat LVM properly (#4109) add f433db9

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 9361fef20fc1e1028675240ce3fc1e93b3971d21 Merge: e02801b 43cb781 Author: Rohit Yadav AuthorDate: Fri Jun 12 10:01:42

[cloudstack] branch 4.14 updated (50f0488 -> 43cb781)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 50f0488 Merge remote-tracking branch 'origin/4.13' into 4.14 add f433db9 ui: Invalid character encountered

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 43cb781d3b284993b107bde532f68e668a061df3 Merge: 50f0488 f433db9 Author: Rohit Yadav AuthorDate: Fri Jun 12 09:59:36

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: [Do not merge] Enable sending hypervior host name via metadata - VR and Config Drive

2020-06-11 Thread GitBox
blueorangutan commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-643052235 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] Pearl1594 commented on pull request #3976: [Do not merge] Enable sending hypervior host name via metadata - VR and Config Drive

2020-06-11 Thread GitBox
Pearl1594 commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-643052043 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

2020-06-11 Thread GitBox
sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r439191916 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql ## @@ -18,3 +18,81 @@ --; -- Schema upgrade from 4.14.0.0

[GitHub] [cloudstack] rhtyd edited a comment on issue #4143: The internal instance name is returned for non-root admin in listVirtualMachineMetrics API

2020-06-11 Thread GitBox
rhtyd edited a comment on issue #4143: URL: https://github.com/apache/cloudstack/issues/4143#issuecomment-643018505 Np @onitake - not really because root admin should be able to know more infrastructure specific information, for example the host where the VM is running on but not to the

[GitHub] [cloudstack] rhtyd commented on issue #4143: The internal instance name is returned for non-root admin in listVirtualMachineMetrics API

2020-06-11 Thread GitBox
rhtyd commented on issue #4143: URL: https://github.com/apache/cloudstack/issues/4143#issuecomment-643018505 Np @onitake - not really because root admin should be able to know more infrastructure specific information, for example the host where the VM is running on but not to the normal

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-642941492 Trillian test result (tid-1674) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48018 seconds Marvin logs:

[GitHub] [cloudstack] div8cn opened a new pull request #4144: Fix Usage failed to get pid

2020-06-11 Thread GitBox
div8cn opened a new pull request #4144: URL: https://github.com/apache/cloudstack/pull/4144 ## Description cloudstack-usage use System.getProperty("pid") to get the process PID System.getProperty cannot get the Pid, which will cause the service to stay in the config

[GitHub] [cloudstack] onitake commented on issue #4143: The internal instance name is returned for non-root admin in listVirtualMachineMetrics API

2020-06-11 Thread GitBox
onitake commented on issue #4143: URL: https://github.com/apache/cloudstack/issues/4143#issuecomment-642713882 Sorry @rhtyd , I didn't see that you were talking about two different API calls. My point wasn't about the asymmetry between listVirtualMachineMetrics and listVirtualMachines,

[GitHub] [cloudstack] rhtyd merged pull request #4142: Invalid character encountered in file ui/l10n/pt_BR.js at line 1134 for encoding UTF-8.

2020-06-11 Thread GitBox
rhtyd merged pull request #4142: URL: https://github.com/apache/cloudstack/pull/4142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[cloudstack] branch 4.13 updated: ui: Invalid character encountered in file ui/l10n/pt_BR.js at line 1134 for encoding UTF-8. (#4142)

2020-06-11 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.13 by this push: new f433db9 ui: Invalid character encountered in

[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2020-06-11 Thread GitBox
ggoodrich-ipp commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-642671150 > @ggoodrich-ipp can you fix the conflicts, thanks. Conflicts resolved. This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling

2020-06-11 Thread GitBox
blueorangutan commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-642615520 Packaging result: ✔centos7 ✔debian. JID-1349 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rhtyd commented on issue #4143: The internal instance name is returned for non-root admin in listVirtualMachineMetrics API

2020-06-11 Thread GitBox
rhtyd commented on issue #4143: URL: https://github.com/apache/cloudstack/issues/4143#issuecomment-642613162 @onitake you're repeating the bug-report, sorry I didn't get your point? This is an automated message from the

[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

2020-06-11 Thread GitBox
blueorangutan commented on pull request #4122: URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-642613279 Packaging result: ✔centos7 ✔debian. JID-1348 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] weizhouapache commented on pull request #4019: server: Move restoreVM to vm work job queue

2020-06-11 Thread GitBox
weizhouapache commented on pull request #4019: URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-642605420 rebased with latest 4.14 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] weizhouapache commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

2020-06-11 Thread GitBox
weizhouapache commented on pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-642603642 @rhtyd @DaanHoogland I missed Daan's comment. steps for manual test (1) login as root admin, (2) dedicate a host H to account A (3) migrate a vm of

[GitHub] [cloudstack] blueorangutan commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling

2020-06-11 Thread GitBox
blueorangutan commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-64262 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration

2020-06-11 Thread GitBox
rhtyd commented on pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-642598944 Ping @ustcweizhou - can you respond to Daan's comment? This is an automated message from the Apache Git

  1   2   >