[cloudstack] branch master updated (36ef850 -> ba6e2ac)

2020-07-29 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 36ef850 Merge remote-tracking branch 'origin/4.14' add ba6e2ac plugins: Redfish Client & Redfish OOBM

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-29 Thread GitBox
andrijapanicsb commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-665762139 The failed test in this last env, the "test_01_redundant_vpc_site2site_vpn" from the "test_vpc_vpn.py" is passing fine when repeated manually (via margin) - i.e.

[GitHub] [cloudstack] DaanHoogland commented on pull request #4035: Document how to pass CIDRs lists API calls

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4035: URL: https://github.com/apache/cloudstack/pull/4035#issuecomment-665520825 textual changes only no furhter testing needed. This is an automated message from the Apache Git

[GitHub] [cloudstack] ravening opened a new pull request #4230: Enable resetting config values to default value

2020-07-29 Thread GitBox
ravening opened a new pull request #4230: URL: https://github.com/apache/cloudstack/pull/4230 ## Description Provide reset button to zone,cluster,domain,account, primary and secondary storage so that config values can be reset to the default value ## Types of changes

[GitHub] [cloudstack] DaanHoogland commented on pull request #4047: Look for active templates for VR deployment

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-665506324 as per your description @ravening, "If the template from which VR is created got deleted, the state is set to inactive and removed to null.", it seems the 'real' bug

[GitHub] [cloudstack] DaanHoogland commented on pull request #3997: New API endpoint: UpdateVlanIpRange

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #3997: URL: https://github.com/apache/cloudstack/pull/3997#issuecomment-665510566 @kioie is this ready for review/ testing again? And do you intent to move this forward before 4.15?

[GitHub] [cloudstack] gaaray2k commented on issue #4153: Remote Access VPN does not work

2020-07-29 Thread GitBox
gaaray2k commented on issue #4153: URL: https://github.com/apache/cloudstack/issues/4153#issuecomment-665621027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] DaanHoogland commented on issue #4229: Creating a network offering

2020-07-29 Thread GitBox
DaanHoogland commented on issue #4229: URL: https://github.com/apache/cloudstack/issues/4229#issuecomment-665546509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] wido commented on pull request #4111: API-call to declare host as dead

2020-07-29 Thread GitBox
wido commented on pull request #4111: URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-665742105 Suggestions: - Unavailable - Degraded - Offline - Defect - Inactive This is an automated message

[GitHub] [cloudstack] weizhouapache commented on pull request #4019: server: Move restoreVM to vm work job queue

2020-07-29 Thread GitBox
weizhouapache commented on pull request #4019: URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-665507567 > code looks good @weizhouapache but two questions: > > 1. I see the test was deleted and not replaced. any directive on other than manual testing (it might be

[GitHub] [cloudstack] andrijapanicsb commented on issue #4153: Remote Access VPN does not work

2020-07-29 Thread GitBox
andrijapanicsb commented on issue #4153: URL: https://github.com/apache/cloudstack/issues/4153#issuecomment-665632509 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on pull request #4205: WIP - Integrate tungsten with cloudstack

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4205: URL: https://github.com/apache/cloudstack/pull/4205#issuecomment-665598103 Nice to see this moving on. Please let us know as soon as you need review or other feedback, @radu-todirica

[GitHub] [cloudstack] DaanHoogland commented on issue #4217: How can I use LVM volume storage for my private CloudStack

2020-07-29 Thread GitBox
DaanHoogland commented on issue #4217: URL: https://github.com/apache/cloudstack/issues/4217#issuecomment-665532055 there is [the users list](mailto:us...@cloudstack.apache.org>) for these questions. hope that helps. This

[GitHub] [cloudstack] DaanHoogland commented on pull request #4215: Enable account settings to be visible under domain settings

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4215: URL: https://github.com/apache/cloudstack/pull/4215#issuecomment-665526708 This quite a functional change @ravening . Did you test settings for domains linked to ldap? I read in your description that you are (kind of) mixing account level

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4212: Migrate/Stop VMs with local storage when preparing host for maintenance

2020-07-29 Thread GitBox
DaanHoogland commented on a change in pull request #4212: URL: https://github.com/apache/cloudstack/pull/4212#discussion_r462174163 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -5619,7 +5619,7 @@ public VirtualMachine migrateVirtualMachine(Long

[GitHub] [cloudstack] blueorangutan commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-29 Thread GitBox
blueorangutan commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-665796142 Trillian test result (tid-2223) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33746 seconds Marvin logs:

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4207: Human readable sizes in logs

2020-07-29 Thread GitBox
Spaceman1984 commented on a change in pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#discussion_r462165542 ## File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java ## @@ -0,0 +1,53 @@ +// +// Licensed to the Apache Software

[GitHub] [cloudstack] ravening commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

2020-07-29 Thread GitBox
ravening commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-665579509 > @ravening when creating an offering in the domain admins domain, are those automatically visible in subdomains and in parent domain(-chain)? it will be visible only

[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-665766362 Trillian test result (tid-2221) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38742 seconds Marvin logs:

[GitHub] [cloudstack] rhtyd closed pull request #4225: vmware: volume utilisation is always zero

2020-07-29 Thread GitBox
rhtyd closed pull request #4225: URL: https://github.com/apache/cloudstack/pull/4225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] DaanHoogland merged pull request #4035: Document how to pass CIDRs lists API calls

2020-07-29 Thread GitBox
DaanHoogland merged pull request #4035: URL: https://github.com/apache/cloudstack/pull/4035 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4220: URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-665569508 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] andrijapanicsb commented on issue #4227: confused about User Permission

2020-07-29 Thread GitBox
andrijapanicsb commented on issue #4227: URL: https://github.com/apache/cloudstack/issues/4227#issuecomment-665799984 @gaaray2k the correct place for QUESTIONS is the mailing list - you'll get better help there. - USER = just username/password (or API/SECRET key)

[GitHub] [cloudstack] blueorangutan commented on pull request #4226: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4226: URL: https://github.com/apache/cloudstack/pull/4226#issuecomment-665726754 Trillian test result (tid-2217) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39959 seconds Marvin logs:

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4225: vmware: volume utilisation is always zero

2020-07-29 Thread GitBox
Spaceman1984 commented on pull request #4225: URL: https://github.com/apache/cloudstack/pull/4225#issuecomment-665738409 @rhtyd I had a look at this, the physical size is reflecting correctly, but that utilization field is a bit strange on the front end, seems like the value should be

[GitHub] [cloudstack] wido commented on pull request #4175: Redfish Client & Redfish OOBM Driver

2020-07-29 Thread GitBox
wido commented on pull request #4175: URL: https://github.com/apache/cloudstack/pull/4175#issuecomment-665553410 @DaanHoogland The problem is that for Redfish testing (and IPMI) you need a physical machine do test this on.

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs

2020-07-29 Thread GitBox
Spaceman1984 commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-665508759 @rhtyd, I checked the commas vs dots in the conversion, looks like it changes based on the locale and JDK version.

[GitHub] [cloudstack] DaanHoogland commented on issue #4211: VM HA does not work when server is stopped gracefully

2020-07-29 Thread GitBox
DaanHoogland commented on issue #4211: URL: https://github.com/apache/cloudstack/issues/4211#issuecomment-665518391 This doesn't sound familiar @weizhouapache . To recap, - a hosts is HA enabled? (genuine question , here) - a vm with a ha enabled offering is created on it. - the

[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #4227: confused about User Permission

2020-07-29 Thread GitBox
andrijapanicsb edited a comment on issue #4227: URL: https://github.com/apache/cloudstack/issues/4227#issuecomment-665799984 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] DaanHoogland commented on pull request #4111: API-call to declare host as dead

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4111: URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-665535646 Like your thinking, mr operator ;). one reservation @GabrielBrascher; is the word 'dead' the best to use here? the life/dead metaphore for hosts might incite

[GitHub] [cloudstack] DaanHoogland commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-665577184 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] ravening commented on pull request #4215: Enable account settings to be visible under domain settings

2020-07-29 Thread GitBox
ravening commented on pull request #4215: URL: https://github.com/apache/cloudstack/pull/4215#issuecomment-665547798 > This quite a functional change @ravening . > Did you test settings for domains linked to ldap? > I read in your description that you are (kind of) mixing account

[GitHub] [cloudstack] DaanHoogland commented on issue #4227: confused about User Permission

2020-07-29 Thread GitBox
DaanHoogland commented on issue #4227: URL: https://github.com/apache/cloudstack/issues/4227#issuecomment-665793646 @gaaray2k I think your question makes sense, even when not understanding it completely; you want the resource count to be on domain level, or shared over the domain admin

[GitHub] [cloudstack] Spaceman1984 edited a comment on pull request #4207: Human readable sizes in logs

2020-07-29 Thread GitBox
Spaceman1984 edited a comment on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-665508759 @rhtyd, I checked the commas vs dots in the conversion, looks like it changes based on the locale.

[GitHub] [cloudstack] gaaray2k commented on issue #4229: Creating a network offering

2020-07-29 Thread GitBox
gaaray2k commented on issue #4229: URL: https://github.com/apache/cloudstack/issues/4229#issuecomment-665561519 Which requirements have to be met?. If I create an offering and choose the options that I want, shouldn't it just work?

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as dead

2020-07-29 Thread GitBox
GabrielBrascher commented on pull request #4111: URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-665738632 @DaanHoogland your observation makes sense, I will look for a better word ;) Thanks for the input!

[GitHub] [cloudstack] ravening commented on pull request #4047: Look for active templates for VR deployment

2020-07-29 Thread GitBox
ravening commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-665551768 > as per your description @ravening, "If the template from which VR is created got deleted, the state > is set to inactive and removed to null.", it seems the 'real' bug

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4207: Human readable sizes in logs

2020-07-29 Thread GitBox
rhtyd commented on a change in pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#discussion_r462184183 ## File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java ## @@ -50,4 +51,14 @@ public void parseMatchJsonTest() {

[GitHub] [cloudstack] DaanHoogland commented on pull request #4175: Redfish Client & Redfish OOBM Driver

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4175: URL: https://github.com/apache/cloudstack/pull/4175#issuecomment-665547812 > Do you mean [@TestTemplate](https://junit.org/junit5/docs/5.0.2/api/org/junit/jupiter/api/TestTemplate.html) from JUnit5? no, nice link though,

[GitHub] [cloudstack] rhtyd commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api

2020-07-29 Thread GitBox
rhtyd commented on pull request #4220: URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-665569219 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[cloudstack-primate] branch master updated: components: Adding quick-view options to list view (#458)

2020-07-29 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new 41aa289 components: Adding

[cloudstack] branch master updated (7e3b61b -> c856614)

2020-07-29 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 7e3b61b Merge branch '4.14' add c856614 Document how to pass CIDRs lists API calls (#4035) No new

[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-665057020 @sureshanaparti do you approve the changes? This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] DaanHoogland commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4020: URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-665082680 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rvalle closed issue #4223: wrong bridge interfaces

2020-07-29 Thread GitBox
rvalle closed issue #4223: URL: https://github.com/apache/cloudstack/issues/4223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'

2020-07-29 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 36ef85012f69af59657c87ad88184769549d8792 Merge: c856614 eec5602 Author: Rohit Yadav AuthorDate: Wed Jul 29 14:08:02

[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #4194: enable update tags on disk offerings

2020-07-29 Thread GitBox
rafaelweingartner commented on a change in pull request #4194: URL: https://github.com/apache/cloudstack/pull/4194#discussion_r461945911 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@ -3183,7 +3184,7 @@ public DiskOffering

[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-07-29 Thread GitBox
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-665425178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] blueorangutan commented on pull request #4165: Allow renaming cluster, host, and storage

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4165: URL: https://github.com/apache/cloudstack/pull/4165#issuecomment-664785902 Trillian test result (tid-2205) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 66215 seconds Marvin logs:

[cloudstack] branch master updated (c856614 -> 36ef850)

2020-07-29 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c856614 Document how to pass CIDRs lists API calls (#4035) add e225db4 ca: Removed check on client mode

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4078: Cleanup download urls when SSVM destroyed

2020-07-29 Thread GitBox
DaanHoogland commented on a change in pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#discussion_r461600605 ## File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/UploadManagerImpl.java ## @@ -307,12

[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run

2020-07-29 Thread GitBox
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-665425111 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4226: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
Spaceman1984 opened a new pull request #4226: URL: https://github.com/apache/cloudstack/pull/4226 ## Description The SSL engine defaults to "Server mode" when doing handshaking. This PR removes the check on the mode which was causing tests to fail. This behavior was

[GitHub] [cloudstack] ravening opened a new pull request #4228: Dont add host back after agent service restart

2020-07-29 Thread GitBox
ravening opened a new pull request #4228: URL: https://github.com/apache/cloudstack/pull/4228 ## Description Fixes #4218 If a host is removed from cloudstack, it will be added back if we restart the agent service on the host. It should not be added back if manualy

[GitHub] [cloudstack] blueorangutan commented on pull request #4144: Fix Usage failed to get pid

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4144: URL: https://github.com/apache/cloudstack/pull/4144#issuecomment-665077347 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on pull request #4144: Fix Usage failed to get pid

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4144: URL: https://github.com/apache/cloudstack/pull/4144#issuecomment-665076769 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] andrijapanicsb opened a new issue #4224: test_vpc_redundant sometimes fails

2020-07-29 Thread GitBox
andrijapanicsb opened a new issue #4224: URL: https://github.com/apache/cloudstack/issues/4224 Pasting below the runinfo.txt related parts - these are making it hard to see if the tests are not robust enough, or if there is some kind of failure on the ACS side. Could someone please

[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs

2020-07-29 Thread GitBox
rhtyd commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-665472945 @Spaceman1984 failures related to vm lifecycle seen here as well, I suspect it may be related to the fix you added in #4226

[GitHub] [cloudstack] gaaray2k opened a new issue #4227: confused aboutUser Permission

2020-07-29 Thread GitBox
gaaray2k opened a new issue #4227: URL: https://github.com/apache/cloudstack/issues/4227 I am a little confused as to how user accounts work on CS. right now I have an account called A which is domain admin in domain lab.com . if I add another user in account A, it gets the same "domain

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664677157 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4144: Fix Usage failed to get pid

2020-07-29 Thread GitBox
DaanHoogland commented on a change in pull request #4144: URL: https://github.com/apache/cloudstack/pull/4144#discussion_r461636110 ## File path: usage/src/main/java/com/cloud/usage/UsageManagerImpl.java ## @@ -275,7 +277,14 @@ public boolean configure(String name, Map

[GitHub] [cloudstack] blueorangutan commented on pull request #4213: Search vm snapshots using tags

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4213: URL: https://github.com/apache/cloudstack/pull/4213#issuecomment-664762505 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4207: Human readable sizes in logs

2020-07-29 Thread GitBox
rhtyd commented on a change in pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#discussion_r462080672 ## File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java ## @@ -0,0 +1,53 @@ +// +// Licensed to the Apache Software Foundation

[GitHub] [cloudstack] rhtyd commented on pull request #4225: vmware: volume utilisation is always zero

2020-07-29 Thread GitBox
rhtyd commented on pull request #4225: URL: https://github.com/apache/cloudstack/pull/4225#issuecomment-665015182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-29 Thread GitBox
blueorangutan removed a comment on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664193373 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] blueorangutan commented on pull request #4226: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4226: URL: https://github.com/apache/cloudstack/pull/4226#issuecomment-665052216 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] ravening commented on issue #4209: use X-forward-for address instead of the load balancer ip.

2020-07-29 Thread GitBox
ravening commented on issue #4209: URL: https://github.com/apache/cloudstack/issues/4209#issuecomment-665208650 we are using haproxy as a loadbalancer and when transparent mode is enabled, it uses XFF address instead of loadbalancer ip. This will be fixed in

[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-664838452 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] Pearl1594 commented on pull request #4213: Search vm snapshots using tags

2020-07-29 Thread GitBox
Pearl1594 commented on pull request #4213: URL: https://github.com/apache/cloudstack/pull/4213#issuecomment-664762152 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4214: URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-664627461 Trillian test result (tid-2196) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50718 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-07-29 Thread GitBox
blueorangutan commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-664857096 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-665425548 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-07-29 Thread GitBox
DaanHoogland commented on a change in pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#discussion_r461593221 ## File path: server/src/main/java/com/cloud/network/guru/ExternalGuestNetworkGuru.java ## @@ -261,6 +265,17 @@ public NicProfile

[GitHub] [cloudstack] rhtyd merged pull request #4226: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
rhtyd merged pull request #4226: URL: https://github.com/apache/cloudstack/pull/4226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664602670 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] rhtyd commented on pull request #4222: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
rhtyd commented on pull request #4222: URL: https://github.com/apache/cloudstack/pull/4222#issuecomment-664748427 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland commented on pull request #4149: set python explicit during transistion

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4149: URL: https://github.com/apache/cloudstack/pull/4149#issuecomment-664840747 @GabrielBrascher then you have to change your version to the one you did install, or not set it at all. I have to switch between 2 and 3 as well. That is exactly the

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4222: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
Spaceman1984 commented on pull request #4222: URL: https://github.com/apache/cloudstack/pull/4222#issuecomment-665016249 > I had some issues on master, where the test checks for true `Assert.assertTrue(e.getUseClientMode()); `, not `assertFalse`. will this be forwarded to master as well?

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs

2020-07-29 Thread GitBox
Spaceman1984 commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-664977855 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2020-07-29 Thread GitBox
DaanHoogland commented on a change in pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#discussion_r461380678 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java ## @@

[GitHub] [cloudstack] rvalle commented on issue #4223: wrong bridge interfaces

2020-07-29 Thread GitBox
rvalle commented on issue #4223: URL: https://github.com/apache/cloudstack/issues/4223#issuecomment-664593182 ok @GabrielBrascher let me check... I have configured - guest.network.device - public.network.device - private.network.device I have not configured

[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4194: enable update tags on disk offerings

2020-07-29 Thread GitBox
RodrigoDLopez commented on a change in pull request #4194: URL: https://github.com/apache/cloudstack/pull/4194#discussion_r461859143 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@ -3183,7 +3184,7 @@ public DiskOffering

[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-665084642 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] rhtyd opened a new pull request #4225: vmware: volume utilisation is always zero

2020-07-29 Thread GitBox
rhtyd opened a new pull request #4225: URL: https://github.com/apache/cloudstack/pull/4225 - This fixes issues of virtual size to be twice in case the disk is a linked-clone root disk. The virtual size of root disk (first in chain) must be used. - Fixes to report the physical size for

[GitHub] [cloudstack] GabrielBrascher commented on issue #4223: wrong bridge interfaces

2020-07-29 Thread GitBox
GabrielBrascher commented on issue #4223: URL: https://github.com/apache/cloudstack/issues/4223#issuecomment-664597022 I thought that this was the case. All looking good then :-) This is an automated message from the Apache

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3730: Update VR's scripts from python2 to python3

2020-07-29 Thread GitBox
GabrielBrascher commented on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-664590843 Sorry for the late reply, @rhtyd. I just fixed conflicts and ported to the current master. I am now performing tests and if all goes right I shall have this PR

[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4213: Search vm snapshots using tags

2020-07-29 Thread GitBox
RodrigoDLopez commented on a change in pull request #4213: URL: https://github.com/apache/cloudstack/pull/4213#discussion_r461837337 ## File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ## @@ -229,11 +238,32 @@ public boolean stop() {

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4226: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
Spaceman1984 commented on pull request #4226: URL: https://github.com/apache/cloudstack/pull/4226#issuecomment-665051451 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-665425488 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] rhtyd commented on pull request #4226: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
rhtyd commented on pull request #4226: URL: https://github.com/apache/cloudstack/pull/4226#issuecomment-665412298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] blueorangutan commented on pull request #4225: vmware: volume utilisation is always zero

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4225: URL: https://github.com/apache/cloudstack/pull/4225#issuecomment-665015464 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on pull request #4222: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
blueorangutan commented on pull request #4222: URL: https://github.com/apache/cloudstack/pull/4222#issuecomment-664728845 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2020-07-29 Thread GitBox
DaanHoogland commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-665083905 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4175: Redfish Client & Redfish OOBM Driver

2020-07-29 Thread GitBox
GabrielBrascher commented on pull request #4175: URL: https://github.com/apache/cloudstack/pull/4175#issuecomment-665250531 @DaanHoogland you are right, docs should be updated indeed. I will work on that as well. > and can we create a template for nested testing Do you mean

[GitHub] [cloudstack] borisstoyanov commented on pull request #4128: Role based users in Projects

2020-07-29 Thread GitBox
borisstoyanov commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-664910401 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4226: Removed check on SSLEngine client mode

2020-07-29 Thread GitBox
RodrigoDLopez commented on pull request #4226: URL: https://github.com/apache/cloudstack/pull/4226#issuecomment-665270280 Code LGTM. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] weizhouapache commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-07-29 Thread GitBox
weizhouapache commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-664626019 > @weizhouapache - related to the Ubuntu 20 changes (your original PR was closed, and Rohit cherry-picked the changes to this PR) - please feel free to test Ubuntu 20

[GitHub] [cloudstack] andrijapanicsb commented on issue #4224: test_vpc_redundant sometimes fails

2020-07-29 Thread GitBox
andrijapanicsb commented on issue #4224: URL: https://github.com/apache/cloudstack/issues/4224#issuecomment-664882291 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] gaaray2k opened a new issue #4229: Creating a network offering

2020-07-29 Thread GitBox
gaaray2k opened a new issue #4229: URL: https://github.com/apache/cloudstack/issues/4229 when I create a new network offering I give it a name and fill out all the require fields. I then enable the new offering but the new network offering doesnt show up when creating a new network. am I

[GitHub] [cloudstack] rhtyd merged pull request #4214: Bug fixes for primate

2020-07-29 Thread GitBox
rhtyd merged pull request #4214: URL: https://github.com/apache/cloudstack/pull/4214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   >