[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672568463 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
nvazquez commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672568141 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-672560586 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4053: Secondary Storage Usage Improvements
Pearl1594 commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-672560434 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
blueorangutan commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-672550926 Trillian test result (tid-2370) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39612 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4239-t2370-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1810.31 | test_kubernetes_supported_versions.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-672533028 Trillian test result (tid-2367) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45371 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4131-t2367-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1808.05 | test_kubernetes_supported_versions.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672502101 Trillian test result (tid-2369) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39110 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4248-t2369-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 73 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_07_reboot_ssvm | `Failure` | 25.34 | test_ssvm.py ContextSuite context=TestTemplates>:setup | `Error` | 8.04 | test_templates.py test_01_snapshot_usage | `Error` | 117.11 | test_usage.py test_11_migrate_vm | `Error` | 73.73 | test_vm_life_cycle.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672406575 Packaging result: ✖centos7 ✖debian. JID-1716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672406572 Packaging result: ✔centos7 ✔debian. JID-1717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-672392803 Trillian test result (tid-2364) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44721 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2364-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 82 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1809.79 | test_kubernetes_supported_versions.py test_hostha_kvm_host_degraded | `Error` | 5.78 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Error` | 214.92 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672377347 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672376270 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4256: Fix comparison using nullable objects
blueorangutan commented on pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#issuecomment-672376789 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
rhtyd commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672376451 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
rhtyd commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672375829 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4260: cks: fix for null hypervisor type
blueorangutan commented on pull request #4260: URL: https://github.com/apache/cloudstack/pull/4260#issuecomment-672375766 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4256: Fix comparison using nullable objects
rhtyd commented on pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#issuecomment-672375683 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4260: cks: fix for null hypervisor type
rhtyd commented on pull request #4260: URL: https://github.com/apache/cloudstack/pull/4260#issuecomment-672375589 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3730: Update SystemVM scripts from python2 to python3
blueorangutan commented on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-672368433 Packaging result: ✔centos7 ✔debian. JID-1715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #3138: StrongSwan with several rightsubnet's - ikev1
andrijapanicsb commented on issue #3138: URL: https://github.com/apache/cloudstack/issues/3138#issuecomment-672353164 it seems that Cisco ASA does not support multiple connections per CHILD_SA, so a comma separated list of right subnets would not work, and a separate CHILD_SA for each connection (right subnet) is needed, as in the begining of the this thread - this PR looks good https://github.com/apache/cloudstack/pull/4137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-672346280 Trillian test result (tid-2357) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52233 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4053-t2357-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 81 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1807.53 | test_kubernetes_supported_versions.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 411.01 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 344.84 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3855.47 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3730: Update SystemVM scripts from python2 to python3
blueorangutan commented on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-672337645 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #3730: Update SystemVM scripts from python2 to python3
GabrielBrascher commented on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-672337382 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4260: cks: fix for null hypervisor type
blueorangutan commented on pull request #4260: URL: https://github.com/apache/cloudstack/pull/4260#issuecomment-672327791 Packaging result: ✔centos7 ✔debian. JID-1714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-672322362 Trillian test result (tid-2356) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50837 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2356-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 81 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1807.73 | test_kubernetes_supported_versions.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 379.47 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3831.93 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4260: cks: fix for null hypervisor type
blueorangutan commented on pull request #4260: URL: https://github.com/apache/cloudstack/pull/4260#issuecomment-672294629 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4260: cks: fix for null hypervisor type
shwstppr commented on pull request #4260: URL: https://github.com/apache/cloudstack/pull/4260#issuecomment-672294349 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr opened a new pull request #4260: cks: fix for null hypervisor type
shwstppr opened a new pull request #4260: URL: https://github.com/apache/cloudstack/pull/4260 Fixes #4241, failure to deploy VM when vm.instancename.flag is set to true ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
andrijapanicsb commented on a change in pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#discussion_r468868061 ## File path: agent/bindir/rolling-maintenance.in ## @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/python3 Review comment: i.e. 20:50:23,239 rolling-maintenance INFO **b**'preflight stage' (from the log) or "output": "**b**'This is Maintenance Stage'**\n**", (from the API output) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks
blueorangutan commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-672282032 Trillian test result (tid-2354) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47725 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4040-t2354-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 81 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1808.14 | test_kubernetes_supported_versions.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 351.41 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
andrijapanicsb commented on a change in pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#discussion_r468867041 ## File path: agent/bindir/rolling-maintenance.in ## @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/python3 Review comment: On line 79 and 83/84 - the error is thrown "Unexpected error on systemd service: write() argument must be str, not bytes". This needs to be fixed, and also, the output given in the API and also inside the rolling-maintenance.log (on the KVM host) is prepended with letter **b**, and appended with**\n** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd
shwstppr commented on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-672280958 @sm97 can you please try deploying k8s cluster after setting `vm.instancename.flag` to false. Issue here doesn't seem to be with CKS itself, the code in UserVmManagerImpl.java seems to be checking the wrong variable for hypervisor type at line 3764 https://github.com/apache/cloudstack/blob/6f96b3b2b391a9b7d085f76bcafa3989d9832b4e/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L3764 I'll add a fix for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672267241 Packaging result: ✖centos7 ✔debian. JID-1713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672243787 @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan removed a comment on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672185280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
harikrishna-patnala commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672243136 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala removed a comment on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
harikrishna-patnala removed a comment on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672183913 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-67496 Packaging result: ✔centos7 ✔debian. JID-1712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
blueorangutan commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-672211519 Trillian test result (tid-2350) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53524 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4137-t2350-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 80 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1807.91 | test_kubernetes_supported_versions.py test_02_vpc_privategw_static_routes | `Failure` | 318.60 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 323.60 | test_privategw_acl.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 481.23 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3904.61 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4255: Prevent null pointer on listPublicIpAddress cmd
blueorangutan commented on pull request #4255: URL: https://github.com/apache/cloudstack/pull/4255#issuecomment-672197197 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4255: Prevent null pointer on listPublicIpAddress cmd
DaanHoogland commented on pull request #4255: URL: https://github.com/apache/cloudstack/pull/4255#issuecomment-672196848 redundant vpc would not have much ado with listIps but to be sure @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4255: Prevent null pointer on listPublicIpAddress cmd
blueorangutan commented on pull request #4255: URL: https://github.com/apache/cloudstack/pull/4255#issuecomment-672193997 Trillian test result (tid-2355) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38953 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4255-t2355-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 396.60 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672185280 @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
harikrishna-patnala commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672183913 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ravening opened a new pull request #4259: Reserve memory for host
ravening opened a new pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259 ## Description By default cloudstack reserves 1Gb of RAM in hosts using _dom0_memory field. Add a global setting "host.reserved.mem.mb" which can used to either increase or decrese the amount of memory which can be reserved ## Types of changes - [X] Enhancement (improves an existing feature and functionality) ## Screenshots (if appropriate): ## How Has This Been Tested? Total capacity and RAM of each host before setting the global setting ``` mysql> select total_capacity,used_capacity from op_host_capacity where capacity_type=0\G *** 1. row *** total_capacity: 7297130496 used_capacity: 6174015488 *** 2. row *** total_capacity: 7297130496 used_capacity: 0 *** 3. row *** total_capacity: 7297130496 used_capacity: 0 3 rows in set (0.00 sec) mysql> select dom0_memory,ram from host where type="Routing" and removed is null\G *** 1. row *** dom0_memory: 1073741824 ram: 7297130496 *** 2. row *** dom0_memory: 1073741824 ram: 7297130496 *** 3. row *** dom0_memory: 1073741824 ram: 7297130496 3 rows in set (0.01 sec) ``` setting global setting `host.reserved.mem.mb` to 4096 ``` mysql> select total_capacity,used_capacity from op_host_capacity where capacity_type=0\G *** 1. row *** total_capacity: 4075905024 used_capacity: 6174015488 *** 2. row *** total_capacity: 4075905024 used_capacity: 0 *** 3. row *** total_capacity: 4075905024 used_capacity: 0 3 rows in set (0.00 sec) mysql> select dom0_memory,ram from host where type="Routing" and removed is null\G *** 1. row *** dom0_memory: 4294967296 ram: 4075905024 *** 2. row *** dom0_memory: 4294967296 ram: 4075905024 *** 3. row *** dom0_memory: 4294967296 ram: 4075905024 3 rows in set (0.00 sec) ``` Corresponding entry in `agent.properties` `host.reserved.mem.mb=4096` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
blueorangutan commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-672044296 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
davidjumani commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-672043868 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672012271 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
rhtyd commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-672011884 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-671977513 Trillian test result (tid-2348) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36125 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4248-t2348-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 70 look OK, 13 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_00_deploy_vm_root_resize | `Failure` | 248.91 | test_deploy_vm_root_resize.py test_01_add_delete_kubernetes_supported_version | `Error` | 1807.92 | test_kubernetes_supported_versions.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_07_reboot_ssvm | `Failure` | 47.02 | test_ssvm.py ContextSuite context=TestTemplates>:setup | `Error` | 9.14 | test_templates.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 12.08 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 66.13 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 74.97 | test_usage.py test_01_snapshot_usage | `Error` | 176.43 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 231.46 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 239.28 | test_usage.py ContextSuite context=TestVpnUsage>:setup | `Error` | 248.07 | test_usage.py test_01_deploy_vm_on_specific_host | `Error` | 75.00 | test_vm_deployment_planner.py test_02_deploy_vm_on_specific_cluster | `Error` | 7.34 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 6.34 | test_vm_deployment_planner.py test_05_deploy_vm_on_cluster_override_pod | `Error` | 7.37 | test_vm_deployment_planner.py ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py test_change_service_offering_for_vm_with_snapshots | `Error` | 7.35 | test_vm_snapshots.py ContextSuite context=TestVmSnapshot>:setup | `Error` | 21.41 | test_vm_snapshots.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 6.71 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Error` | 9.81 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 63.49 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 78.68 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 8.77 | test_vpc_redundant.py test_01_VPC_nics_after_destroy | `Error` | 6.70 | test_vpc_router_nics.py test_02_VPC_default_routes | `Failure` | 82.08 | test_vpc_router_nics.py test_01_redundant_vpc_site2site_vpn | `Failure` | 9.49 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Failure` | 192.77 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | `Failure` | 5.26 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Failure` | 46.50 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-671958732 @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-671958051 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4258: List networks using networkofferingid
blueorangutan commented on pull request #4258: URL: https://github.com/apache/cloudstack/pull/4258#issuecomment-671918158 Packaging result: ✔centos7 ✔debian. JID-1711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-671913484 Packaging result: ✔centos7 ✔debian. JID-1710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4251: Handle with VM snapshot events
RodrigoDLopez commented on pull request #4251: URL: https://github.com/apache/cloudstack/pull/4251#issuecomment-671905213 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4258: List networks using networkofferingid
davidjumani commented on pull request #4258: URL: https://github.com/apache/cloudstack/pull/4258#issuecomment-671896076 Code LGTM. Need to run a few tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4258: List networks using networkofferingid
blueorangutan commented on pull request #4258: URL: https://github.com/apache/cloudstack/pull/4258#issuecomment-671895616 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4258: List networks using networkofferingid
davidjumani commented on pull request #4258: URL: https://github.com/apache/cloudstack/pull/4258#issuecomment-671895329 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4239: Disabling managing firewall - cloudstack-setup-management
davidjumani commented on a change in pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#discussion_r468514496
##
File path: python/lib/cloudutils/syscfg.py
##
@@ -201,15 +201,15 @@ def check(self):
if not hostname.isSuccess():
raise CloudInternalException("Checking hostname ...
[Failed]\nPlease edit /etc/hosts, add a Fully Qualified Domain Name as your
hostname\n")
return True
-
+
class sysConfigServerRedhat(sysConfigServer):
def __init__(self, glbEnv):
super(sysConfigServerRedhat, self).__init__(glbEnv)
self.svo = serviceOpsRedhat()
-self.services = [firewallConfigServer(self)]
Review comment:
@rhtyd I was able to deploy a kvm env for basic testing, and everything
seems to work. Will look into why it failed this time
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4239: Disabling managing firewall - cloudstack-setup-management
rhtyd commented on a change in pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#discussion_r468513457
##
File path: python/lib/cloudutils/syscfg.py
##
@@ -201,15 +201,15 @@ def check(self):
if not hostname.isSuccess():
raise CloudInternalException("Checking hostname ...
[Failed]\nPlease edit /etc/hosts, add a Fully Qualified Domain Name as your
hostname\n")
return True
-
+
class sysConfigServerRedhat(sysConfigServer):
def __init__(self, glbEnv):
super(sysConfigServerRedhat, self).__init__(glbEnv)
self.svo = serviceOpsRedhat()
-self.services = [firewallConfigServer(self)]
Review comment:
@davidjumani I think we should revert the previous behaviour and simply
print the statement. Otherwise, env will not deploy. Previously the
cloudstack-setup-management would open firewall, now that you've changed it -
either (a) document this and fix trillian to open the ports both CentOS/Ubuntu
envs, or (b) just print the line for information sake.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
rhtyd commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671892228 @davidjumani env fails to deploy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez closed pull request #4257: remove the unnecessary check for tags when migrating volumes
RodrigoDLopez closed pull request #4257: URL: https://github.com/apache/cloudstack/pull/4257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-671891611 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-671891070 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671889024 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
rhtyd commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671888427 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671881292 Packaging result: ✔centos7 ✔debian. JID-1709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4200: Allow domain admins to create offering without mentioning domainid
ravening commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-671869938 > > Same applies for child1 > > I think this is a bug, `isrecursive` should not traverse up, only down. > > > if you dont pass isrecursive=true and try listing offerings for child11 then you will see all the parent domain offerings. @DaanHoogland `isrecursive` is traversing down as expected. Problem happens when this flag is true and function is called with child domain id as first parameter and parent domain id as second parameter. If `isrecursive` is true, it checks if the second parameter is the child domain of first parameter. Since we are passing parent domain as the second parameter, the condition will be false and it will never display the offerings belonging to parent domain This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671864568 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
rhtyd commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671864029 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4254: Name public network appropriately to avoid conflicts
rhtyd commented on pull request #4254: URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671862884 @Pearl1594 or @Spaceman1984 can you investigate two intermittently failing marvin tests (the migrate vm and ssvm reboot test cases) on master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ravening opened a new pull request #4258: List networks using networkofferingid
ravening opened a new pull request #4258:
URL: https://github.com/apache/cloudstack/pull/4258
## Description
Add extra parameter for listNetworks command to list
all networks using networkofferingid
## Types of changes
- [X] Enhancement (improves an existing feature and functionality)
## Screenshots (if appropriate):
## How Has This Been Tested?
```
(local) mgt01 > list networks
networkofferingid=85051f32-93a4-4277-8895-a9232e4885f5 filter=name
{
"count": 4,
"network": [
{
"name": "tier23"
},
{
"name": "tier13"
},
{
"name": "tier22"
},
{
"name": "tier12"
}
]
}
(local) mgt01 >
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-671852081 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4128: Role based users in Projects
rhtyd commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-671851501 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on pull request #4207: Human readable sizes in logs
alexandremattioli commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-671844548 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on issue #4246: plugPublicNic forgot to sort the nic devices before plug a new public network
Spaceman1984 commented on issue #4246: URL: https://github.com/apache/cloudstack/issues/4246#issuecomment-671842382 @rhtyd, I'm on this one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Spaceman1984 commented on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-671839554 > @DaanHoogland @Spaceman1984 - my concern is that whether removing privategateway also remove the nic/configuration from the VPC VR or not? Based on code, I think it will solve the issue or removing it from the DB. @Spaceman1984 did you test the case by adding privategateway with some static routes (also deploy VMs as VR programming is lazy) and check if VPC VR has a new nic and then removing it removes it both from VR and DB? @rhtyd I have confirmed that it works as expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on issue #4146: Kubernetes Service: Unable to add new Kubernetes cluster
PaulAngus commented on issue #4146: URL: https://github.com/apache/cloudstack/issues/4146#issuecomment-671836238 @stack1313 where did your coreos template come from? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4256: Fix comparison using nullable objects
blueorangutan commented on pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#issuecomment-671835141 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4256: Fix comparison using nullable objects
rhtyd commented on pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#issuecomment-671834662 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-671833131 Packaging result: ✔centos7 ✔debian. JID-1708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
blueorangutan commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671828557 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
davidjumani commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671828307 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated (246fae1 -> e943534)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 246fae1 vpc: Fixing Edit ACL (#572) add e943534 docs: Adding development docs (#569) No new revisions were added by this update. Summary of changes: README.md | 3 + docs/action.md | 20 - docs/config.md | 63 -- docs/detailview.md | 8 -- docs/development.md | 232 docs/listview.md| 3 - 6 files changed, 235 insertions(+), 94 deletions(-) delete mode 100644 docs/action.md delete mode 100644 docs/config.md delete mode 100644 docs/detailview.md create mode 100644 docs/development.md delete mode 100644 docs/listview.md
[cloudstack-primate] branch master updated: vpc: Fixing Edit ACL (#572)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 246fae1 vpc: Fixing Edit ACL (#572)
246fae1 is described below
commit 246fae1d81e9b20eac64bcc797da7b9cd798dd49
Author: davidjumani
AuthorDate: Tue Aug 11 14:34:25 2020 +0530
vpc: Fixing Edit ACL (#572)
---
src/views/network/AclListRulesTab.vue | 81 +--
1 file changed, 40 insertions(+), 41 deletions(-)
diff --git a/src/views/network/AclListRulesTab.vue
b/src/views/network/AclListRulesTab.vue
index 909d4f2..8219b01 100644
--- a/src/views/network/AclListRulesTab.vue
+++ b/src/views/network/AclListRulesTab.vue
@@ -46,7 +46,7 @@
-{{ $t('label.number') }}
+{{ $t('label.rule.number') }}
{{ acl.number }}
@@ -136,7 +136,7 @@
-
+
@@ -167,12 +167,12 @@
-
+
-
+
-
+
@@ -396,7 +396,7 @@ export default {
setTimeout(() => {
this.ruleForm.setFieldsValue({
number: acl.number,
- cidr: acl.cidrlist,
+ cidrlist: acl.cidrlist,
action: acl.action,
protocol: acl.protocol,
startport: acl.startport,
@@ -406,6 +406,32 @@ export default {
})
}, 200)
},
+getDataFromForm (values) {
+ const data = {
+cidrlist: values.cidrlist || '',
+number: values.number || '',
+protocol: values.protocol || '',
+traffictype: values.traffictype || '',
+action: values.action || '',
+reason: values.reason || ''
+ }
+
+ if (values.protocol === 'tcp' || values.protocol === 'udp' ||
values.protocol === 'protocolnumber') {
+data.startport = values.startport || ''
+data.endport = values.endport || ''
+ }
+
+ if (values.protocol === 'icmp') {
+data.icmptype = values.icmptype || -1
+data.icmpcode = values.icmpcode || -1
+ }
+
+ if (values.protocol === 'protocolnumber') {
+data.protocol = values.protocolnumber
+ }
+
+ return data
+},
handleEditRule (e) {
e.preventDefault()
this.ruleForm.validateFields((err, values) => {
@@ -413,18 +439,12 @@ export default {
this.fetchLoading = true
this.ruleModalVisible = false
-api('updateNetworkACLItem', {}, 'POST', {
- id: this.selectedAcl.id,
- cidrlist: values.cidr,
- number: values.number,
- protocol: values.protocol,
- traffictype: values.traffictype,
- action: values.action,
- reason: values.reason,
- startport: values.startport,
- endport: values.endport,
- partialupgrade: false
-}).then(response => {
+
+const data = this.getDataFromForm(values)
+data.id = this.selectedAcl.id
+data.partialupgrade = false
+
+api('updateNetworkACLItem', {}, 'POST', data).then(response => {
this.$store.dispatch('AddAsyncJob', {
title: this.$t('label.edit.acl.rule'),
jobid: response.createnetworkaclresponse.jobid,
@@ -515,29 +535,8 @@ export default {
this.fetchLoading = true
this.ruleModalVisible = false
-const data = {
- aclid: this.resource.id,
- cidrlist: values.cidr || '',
- number: values.number || '',
- protocol: values.protocol || '',
- traffictype: values.traffictype || '',
- action: values.action || '',
- reason: values.reason || ''
-}
-
-if (values.protocol === 'tcp' || values.protocol === 'udp' ||
values.protocol === 'protocolnumber') {
- data.startport = values.startport || ''
- data.endport = values.endport || ''
-}
-
-if (values.protocol === 'icmp') {
- data.icmptype = values.icmptype || -1
- data.icmpcode = values.icmpcode || -1
-}
-
-if (values.protocol === 'protocolnumber') {
- data.protocol = values.protocolnumber
-}
+const data = this.getDataFromForm(values)
+data.aclid = this.resource.id
api('createNetworkACL', {}, 'POST', data).then(() => {
this.$notification.success({
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-671810807 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-671810207 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
blueorangutan commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671808019 Packaging result: ✔centos7 ✔debian. JID-1707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4228: Dont add host back after agent service restart
ravening commented on a change in pull request #4228: URL: https://github.com/apache/cloudstack/pull/4228#discussion_r468411269 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@ -410,6 +410,10 @@ public final static ConfigKey IOPS_MAX_WRITE_LENGTH = new ConfigKey(Long.class, "vm.disk.iops.maximum.write.length", "Advanced", "0", "Maximum IOPS write burst duration (seconds). If '0' (zero) then does not check for maximum burst length.", true, ConfigKey.Scope.Global, null); +public static final ConfigKey AddHostOnServiceRestart = new ConfigKey(Boolean.class, "add.host.on.service.restart", "Advanced", "true", Review comment: @GabrielBrascher I made the necessary changes. Please review again This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4141: [New feature] Load balancer customization (haproxy-based)
blueorangutan commented on pull request #4141: URL: https://github.com/apache/cloudstack/pull/4141#issuecomment-671804819 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4141: [New feature] Load balancer customization (haproxy-based)
DaanHoogland commented on pull request #4141: URL: https://github.com/apache/cloudstack/pull/4141#issuecomment-671804215 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4141: [New feature] Load balancer customization (haproxy-based)
blueorangutan commented on pull request #4141: URL: https://github.com/apache/cloudstack/pull/4141#issuecomment-671803098 Packaging result: ✔centos7 ✔debian. JID-1706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-671797378 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
DaanHoogland commented on pull request #4236: URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-671796826 kick travis in the This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4213: Search vm snapshots using tags
blueorangutan commented on pull request #4213: URL: https://github.com/apache/cloudstack/pull/4213#issuecomment-671797275 Packaging result: ✔centos7 ✔debian. JID-1705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4053: Secondary Storage Usage Improvements
Pearl1594 commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-671797104 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-671796705 Packaging result: ✔centos7 ✔debian. JID-1704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4236: resolves issues Multiple Public Subnets static NAT
DaanHoogland closed pull request #4236: URL: https://github.com/apache/cloudstack/pull/4236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671786226 @vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
vladimirpetrov commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671785636 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
