[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563807267 [SF] Trillian Build Failed (tid-6591) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563806353 @shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
shwstppr commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563806088 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1563798423 [LL]Trillian test result (tid-6544) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47715 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7508: guestos: add Windows Server 2022

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7508: URL: https://github.com/apache/cloudstack/pull/7508#issuecomment-1563775334 [LL]Trillian test result (tid-6543) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45154 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7484: HAproxy based load balancer Customisation

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7484: URL: https://github.com/apache/cloudstack/pull/7484#issuecomment-1563747934 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6154 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563746595 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6153 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7484: HAproxy based load balancer Customisation

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7484: URL: https://github.com/apache/cloudstack/pull/7484#issuecomment-1563713955 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563712706 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7484: HAproxy based load balancer Customisation

2023-05-25 Thread via GitHub
rohityadavcloud commented on PR #7484: URL: https://github.com/apache/cloudstack/pull/7484#issuecomment-1563712705 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
rohityadavcloud commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563711664 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7509: cks: enable by default

2023-05-25 Thread via GitHub
rohityadavcloud commented on code in PR #7509: URL: https://github.com/apache/cloudstack/pull/7509#discussion_r1206152492 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterService.java: ## @@ -38,7 +38,7 @@ public interface

[cloudstack] branch main updated: Fix acquire console session issue (#7558)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 2457d202ddf Fix acquire console session issue

[GitHub] [cloudstack] rohityadavcloud merged pull request #7558: Fix acquire console session issue

2023-05-25 Thread via GitHub
rohityadavcloud merged PR #7558: URL: https://github.com/apache/cloudstack/pull/7558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[cloudstack] branch main updated: refactor: remove duplicate inject (#7548)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 0c13024329e refactor: remove duplicate inject

[GitHub] [cloudstack] rohityadavcloud merged pull request #7548: refactor: remove duplicate inject

2023-05-25 Thread via GitHub
rohityadavcloud merged PR #7548: URL: https://github.com/apache/cloudstack/pull/7548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7548: refactor: remove duplicate inject

2023-05-25 Thread via GitHub
rohityadavcloud commented on PR #7548: URL: https://github.com/apache/cloudstack/pull/7548#issuecomment-1563707464 Failures due to env, tests lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #7548: refactor: remove duplicate inject

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7548: URL: https://github.com/apache/cloudstack/pull/7548#issuecomment-1563664511 [SF] Trillian test result (tid-6580) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56524 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7558: Fix acquire console session issue

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7558: URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1563643320 [SF] Trillian test result (tid-6578) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58701 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1563589506 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6152 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1563587935 [LL]Trillian test result (tid-6541) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42501 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1563581720 [LL]Trillian test result (tid-6539) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42116 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7541: ui,api: make description option for createKubernetesCluster

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7541: URL: https://github.com/apache/cloudstack/pull/7541#issuecomment-1563567122 [SF] Trillian test result (tid-6579) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52071 seconds Marvin logs:

[GitHub] [cloudstack] vishesh92 commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
vishesh92 commented on PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1563526286 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1563526848 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7489: Flexible tags for hosts and storage pools

2023-05-25 Thread via GitHub
github-actions[bot] commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1563511025 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7408: Allow volume live storage migration in ScaleIO

2023-05-25 Thread via GitHub
github-actions[bot] commented on PR #7408: URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1563510991 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205950709 ## ui/src/views/compute/KubernetesServiceTab.vue: ## @@ -25,17 +25,14 @@ - + Review Comment: you can rollback the

[GitHub] [cloudstack] pdion891 commented on pull request #6639: Update GPU support for V100,T4,A5500.

2023-05-25 Thread via GitHub
pdion891 commented on PR #6639: URL: https://github.com/apache/cloudstack/pull/6639#issuecomment-1563343482 @rohityadavcloud yes, but at this point it would make sense to update it with recent GPU model. I will rebase this PR and add some more GPU to it. -- This is an automated

[GitHub] [cloudstack] jbampton opened a new pull request, #7562: Add basic `.editorconfig` file to help maintain consistent coding styles

2023-05-25 Thread via GitHub
jbampton opened a new pull request, #7562: URL: https://github.com/apache/cloudstack/pull/7562 ### Description This PR adds a simple `EditorConfig` file. I used only three settings to start with. Lots of great projects already use EditorConfig:

[GitHub] [cloudstack] blueorangutan commented on pull request #7558: Fix acquire console session issue

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7558: URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1563327076 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6151 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7558: Fix acquire console session issue

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7558: URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1563255979 @nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] nvazquez commented on pull request #7558: Fix acquire console session issue

2023-05-25 Thread via GitHub
nvazquez commented on PR #7558: URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1563253996 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1563250569 [LL]Trillian test result (tid-6540) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 23713 seconds Marvin logs:

[cloudstack-terraform-provider] branch main updated: Fix spelling (#59)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git The following commit(s) were added to refs/heads/main by this push: new 5e3e753 Fix spelling (#59)

[cloudstack] branch main updated (47af4327455 -> ce44ff41486)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 47af4327455 Merge remote-tracking branch 'origin/4.18' add 8849e0f464c server: fix volume detach operation when

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit ce44ff4148676138a103c6a2e6a68845e5046ee0 Merge: 47af4327455 4138ca7c5d0 Author: Rohit Yadav AuthorDate: Thu May 25

[cloudstack] branch 4.18 updated (8849e0f464c -> 4138ca7c5d0)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 8849e0f464c server: fix volume detach operation when no vm host (#7526) add 4138ca7c5d0 systemvmtemplate: fix

[cloudstack-kubernetes-provider] branch main updated: Fix spelling (#49)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git The following commit(s) were added to refs/heads/main by this push: new a0469bcd Fix spelling (#49)

[GitHub] [cloudstack] shwstppr commented on pull request #7509: cks: enable by default

2023-05-25 Thread via GitHub
shwstppr commented on PR #7509: URL: https://github.com/apache/cloudstack/pull/7509#issuecomment-1563160667 @weizhouapache test updates the config and restarts MS only when the config is false. If the config is made dynamic then restart won't be needed. Config was not made dynamic

[GitHub] [cloudstack] Kwakye-Emmanuel commented on issue #7371: how can we migrate vm from proxmox to cloudstack??

2023-05-25 Thread via GitHub
Kwakye-Emmanuel commented on issue #7371: URL: https://github.com/apache/cloudstack/issues/7371#issuecomment-1563136715 ok, please show me On Thu, May 25, 2023 at 3:27 PM leolage ***@***.***> wrote: > Hi, I can show you how to transfer a qcow image of a virtual machine to >

[cloudstack-cloudmonkey] branch main updated: Fix spelling in `README.md` (#135)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git The following commit(s) were added to refs/heads/main by this push: new 97a284d Fix spelling in `README.md`

[GitHub] [cloudstack] weizhouapache commented on pull request #7509: cks: enable by default

2023-05-25 Thread via GitHub
weizhouapache commented on PR #7509: URL: https://github.com/apache/cloudstack/pull/7509#issuecomment-1563066544 as far as remember, smoke test test_kubernetes_clusters.py updates the globals setting and restarts the mangement server. If the setting is dynamic, restarting mgmt server is

[GitHub] [cloudstack] blueorangutan commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1563052272 @DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-25 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1563050541 @blueorangutan LLtest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #6473: Fix backup dates

2023-05-25 Thread via GitHub
blueorangutan commented on PR #6473: URL: https://github.com/apache/cloudstack/pull/6473#issuecomment-1563030099 [LL]Trillian test result (tid-6537) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 23895 seconds Marvin logs:

[GitHub] [cloudstack] DaanHoogland commented on pull request #7526: server: fix volume detach operation when no vm host

2023-05-25 Thread via GitHub
DaanHoogland commented on PR #7526: URL: https://github.com/apache/cloudstack/pull/7526#issuecomment-1562942909 tested according to https://github.com/apache/cloudstack/issues/7525#issue-1707304990 and verified no extra disks attached to the VM. -- This is an automated message from the

[GitHub] [cloudstack] DaanHoogland merged pull request #7526: server: fix volume detach operation when no vm host

2023-05-25 Thread via GitHub
DaanHoogland merged PR #7526: URL: https://github.com/apache/cloudstack/pull/7526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[cloudstack] branch 4.18 updated (2b3e2e48a07 -> 8849e0f464c)

2023-05-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 2b3e2e48a07 ui: show zones and offerings to users (#7557) add 8849e0f464c server: fix volume detach operation

[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1562899053 Trillian test result (tid-6532) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 100666 seconds Marvin logs:

[GitHub] [cloudstack] benj-n closed pull request #7535: Ensure cloudstack-usage debian package is installed after cloudstack-management

2023-05-25 Thread via GitHub
benj-n closed pull request #7535: Ensure cloudstack-usage debian package is installed after cloudstack-management URL: https://github.com/apache/cloudstack/pull/7535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] blueorangutan commented on pull request #6809: Reserve memory for host

2023-05-25 Thread via GitHub
blueorangutan commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1562878567 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6150 -- This is an

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 47af43274559474cf83cba5f01291033b6e4bc05 Merge: 48af4625a22 2b3e2e48a07 Author: Rohit Yadav AuthorDate: Thu May 25

[cloudstack] branch main updated (48af4625a22 -> 47af4327455)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 48af4625a22 Fix end of file precommit for TemplateServiceImplTest.java (#7561) add 2b3e2e48a07 ui: show zones

[GitHub] [cloudstack] codecov[bot] commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall

2023-05-25 Thread via GitHub
codecov[bot] commented on PR #7559: URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562810833 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7559?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging

[GitHub] [cloudstack] codecov[bot] commented on pull request #7551: pre-commit: apply `end-of-file-fixer` to all files

2023-05-25 Thread via GitHub
codecov[bot] commented on PR #7551: URL: https://github.com/apache/cloudstack/pull/7551#issuecomment-1562807249 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7551?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7509: cks: enable by default

2023-05-25 Thread via GitHub
DaanHoogland commented on code in PR #7509: URL: https://github.com/apache/cloudstack/pull/7509#discussion_r1205421428 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterService.java: ## @@ -38,7 +38,7 @@ public interface

[GitHub] [cloudstack] DaanHoogland commented on pull request #7509: cks: enable by default

2023-05-25 Thread via GitHub
DaanHoogland commented on PR #7509: URL: https://github.com/apache/cloudstack/pull/7509#issuecomment-1562788737 > LGTM, may need some discussion with the community @weizhouapache , is there any ramification on enabling it, like performance degradation? I don t see why we couldn't

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205416033 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -783,15 +843,16 @@ public void

[GitHub] [cloudstack] blueorangutan commented on pull request #6809: Reserve memory for host

2023-05-25 Thread via GitHub
blueorangutan commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1562785460 @soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] soreana commented on pull request #6809: Reserve memory for host

2023-05-25 Thread via GitHub
soreana commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1562784146 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
vishesh92 commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205408466 ## engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql: ## @@ -135,3 +135,7 @@ CREATE VIEW `cloud`.`async_job_view` AS UPDATE

[cloudstack] branch 4.18 updated: ui: show zones and offerings to users (#7557)

2023-05-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 2b3e2e48a0 ui: show zones and offerings to users

[GitHub] [cloudstack] DaanHoogland merged pull request #7557: ui: show zones and offerings to users

2023-05-25 Thread via GitHub
DaanHoogland merged PR #7557: URL: https://github.com/apache/cloudstack/pull/7557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] DaanHoogland commented on pull request #7557: ui: show zones and offerings to users

2023-05-25 Thread via GitHub
DaanHoogland commented on PR #7557: URL: https://github.com/apache/cloudstack/pull/7557#issuecomment-1562759579 tested in qa again: as regular user I see ![image](https://github.com/apache/cloudstack/assets/2486961/9fb98c4e-92b5-46c4-b239-2de9913ce4a2)

[GitHub] [cloudstack] weizhouapache commented on pull request #7561: Fix end of file precommit for TemplateServiceImplTest.java

2023-05-25 Thread via GitHub
weizhouapache commented on PR #7561: URL: https://github.com/apache/cloudstack/pull/7561#issuecomment-1562719728 small fix, not smoke tests required. merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[cloudstack] branch main updated: Fix end of file precommit for TemplateServiceImplTest.java (#7561)

2023-05-25 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 48af4625a22 Fix end of file precommit for

[GitHub] [cloudstack] weizhouapache merged pull request #7561: Fix end of file precommit for TemplateServiceImplTest.java

2023-05-25 Thread via GitHub
weizhouapache merged PR #7561: URL: https://github.com/apache/cloudstack/pull/7561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] blueorangutan commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1562714189 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6149 -- This is an

[GitHub] [cloudstack] weizhouapache commented on pull request #7561: Fix end of file precommit for TemplateServiceImplTest.java

2023-05-25 Thread via GitHub
weizhouapache commented on PR #7561: URL: https://github.com/apache/cloudstack/pull/7561#issuecomment-1562675048 @vishesh92 can you rebase with 4.18 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] nvazquez commented on pull request #7558: Fix acquire console session issue

2023-05-25 Thread via GitHub
nvazquez commented on PR #7558: URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1562668878 Thanks @shwstppr - I have refactored the logic to add the missing annotation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7558: Fix acquire console session issue

2023-05-25 Thread via GitHub
nvazquez commented on code in PR #7558: URL: https://github.com/apache/cloudstack/pull/7558#discussion_r1205319874 ## engine/schema/src/main/java/com/cloud/vm/dao/ConsoleSessionDaoImpl.java: ## @@ -60,9 +65,20 @@ public int expungeSessionsOlderThanDate(Date date) {

[GitHub] [cloudstack] nvazquez commented on pull request #7558: Fix acquire console session issue

2023-05-25 Thread via GitHub
nvazquez commented on PR #7558: URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1562668086 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] vishesh92 opened a new pull request, #7561: Fix end of file precommit for TemplateServiceImplTest.java

2023-05-25 Thread via GitHub
vishesh92 opened a new pull request, #7561: URL: https://github.com/apache/cloudstack/pull/7561 ### Description pre-commit github action is breaking currently. This PR fixes the end of file in

[GitHub] [cloudstack] blueorangutan commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1562629967 Trillian Build Failed (tid-6589) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1562629513 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6148 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1562627071 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[GitHub] [cloudstack] blueorangutan commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1562627007 @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-25 Thread via GitHub
rohityadavcloud commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1562625750 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-25 Thread via GitHub
rohityadavcloud commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1562625348 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1562624111 Trillian Build Failed (tid-6584) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7508: guestos: add Windows Server 2022

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7508: URL: https://github.com/apache/cloudstack/pull/7508#issuecomment-1562624585 Trillian Build Failed (tid-6585) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1562621313 @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7479: cks: k8s cluster on vpc tier

2023-05-25 Thread via GitHub
rohityadavcloud commented on PR #7479: URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1562620689 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7508: guestos: add Windows Server 2022

2023-05-25 Thread via GitHub
rohityadavcloud commented on PR #7508: URL: https://github.com/apache/cloudstack/pull/7508#issuecomment-1562619942 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[cloudstack] branch main updated (b0d7a20d5d2 -> 8ff0071becf)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from b0d7a20d5d2 CONTRIBUTING.md: remove unneeded whitespace from start of code blocks (#7553) add 8ff0071becf

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7541: ui,api: make description option for createKubernetesCluster

2023-05-25 Thread via GitHub
rohityadavcloud commented on PR #7541: URL: https://github.com/apache/cloudstack/pull/7541#issuecomment-1562617213 Merged based on Github actions smoketests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] rohityadavcloud merged pull request #7541: ui,api: make description option for createKubernetesCluster

2023-05-25 Thread via GitHub
rohityadavcloud merged PR #7541: URL: https://github.com/apache/cloudstack/pull/7541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205223919 ## engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql: ## @@ -135,3 +135,7 @@ CREATE VIEW `cloud`.`async_job_view` AS UPDATE

[cloudstack-go] branch main updated: Fix generation for UUID type (#60)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git The following commit(s) were added to refs/heads/main by this push: new 1b7c54e Fix generation for UUID type (#60)

[cloudstack-go] branch main updated: Fix spelling (#62)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git The following commit(s) were added to refs/heads/main by this push: new 20cbd1c Fix spelling (#62) 20cbd1c is

[GitHub] [cloudstack] blueorangutan commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1562535274 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[GitHub] [cloudstack] weizhouapache commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
weizhouapache commented on PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1562532598 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-25 Thread via GitHub
DaanHoogland commented on PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#issuecomment-1562528635 > > > > @weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us. > > > > > > > > > @DaanHoogland

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7524: secondary-storage: delete backedup snapshot dir on delete

2023-05-25 Thread via GitHub
DaanHoogland commented on code in PR #7524: URL: https://github.com/apache/cloudstack/pull/7524#discussion_r1205193638 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java: ## @@ -1997,6 +1997,17 @@ private

[GitHub] [cloudstack] blueorangutan commented on pull request #7524: secondary-storage: delete backedup snapshot dir on delete

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7524: URL: https://github.com/apache/cloudstack/pull/7524#issuecomment-1562515914 @DaanHoogland a [LL] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[cloudstack-www] branch docusaurus-staging updated (a8cc606a -> 044369c6)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from a8cc606a fix menus (hide while publishing blog) add 044369c6 use different config for blog

[cloudstack-www] branch docusaurus-staging updated (f5139729 -> a8cc606a)

2023-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from f5139729 new blog post: cseug 2023 roundup add a8cc606a fix menus (hide while publishing

[GitHub] [cloudstack] DaanHoogland commented on pull request #7524: secondary-storage: delete backedup snapshot dir on delete

2023-05-25 Thread via GitHub
DaanHoogland commented on PR #7524: URL: https://github.com/apache/cloudstack/pull/7524#issuecomment-1562513490 @blueorangutan LLtest rocky8 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall

2023-05-25 Thread via GitHub
blueorangutan commented on PR #7559: URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562506971 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6147 -- This is an

  1   2   >