Re: [PR] Fix: Update rootdisksize detail on restore VM [cloudstack]
blueorangutan commented on PR #8981: URL: https://github.com/apache/cloudstack/pull/8981#issuecomment-2078671521 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
abh1sar commented on code in PR #8947:
URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1580503575
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -839,6 +839,21 @@ protected String createLocalStoragePoolName(Host host,
StoragePoolInfo storagePo
return String.format("%s-%s-%s", StringUtils.trim(host.getName()),
"local", storagePoolInformation.getUuid().split("-")[0]);
}
+protected void checkNfsOptions(String nfsopts) throws
InvalidParameterValueException {
+String[] options = nfsopts.replaceAll("\\s", "").split(",");
+Map optionsMap = new HashMap<>();
+for (String option : options) {
+String[] keyValue = option.split("=");
+if (keyValue.length > 2) {
+throw new InvalidParameterValueException("Invalid value for
NFS option " + keyValue[0]);
+}
+if (optionsMap.containsKey(keyValue[0])) {
+throw new InvalidParameterValueException("Duplicate NFS option
values found for option " + keyValue[0]);
+}
+optionsMap.put(keyValue[0], null);
Review Comment:
That's a good point. Let me test this and get back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch main updated: Clean up `.asf.yaml` collaborators (#8982)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new b93a86c9da8 Clean up `.asf.yaml` collaborators (#8982) b93a86c9da8 is described below commit b93a86c9da8ce759d2821f2fac3ef06021b7ebfd Author: John Bampton AuthorDate: Fri Apr 26 15:41:25 2024 +1000 Clean up `.asf.yaml` collaborators (#8982) Remove `kiranchavala` now a committer https://github.com/kiranchavala --- .asf.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.asf.yaml b/.asf.yaml index 67b68a34223..507a0ca6dd5 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -51,7 +51,6 @@ github: collaborators: - acs-robot -- kiranchavala - rajujith - GaOrtiga - SadiJr
Re: [PR] Clean up `.asf.yaml` collaborators [cloudstack]
rohityadavcloud merged PR #8982: URL: https://github.com/apache/cloudstack/pull/8982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up `.asf.yaml` collaborators [cloudstack]
rohityadavcloud commented on PR #8982: URL: https://github.com/apache/cloudstack/pull/8982#issuecomment-2078670902 Thanks for the PR @jbampton -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix: Update rootdisksize detail on restore VM [cloudstack]
sureshanaparti commented on PR #8981: URL: https://github.com/apache/cloudstack/pull/8981#issuecomment-2078670358 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2078654228 [SF] Trillian test result (tid-10032) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48178 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8601-t10032-xenserver-71.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 342.70 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
sureshanaparti commented on code in PR #8980:
URL: https://github.com/apache/cloudstack/pull/8980#discussion_r1580492900
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -3341,8 +3343,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
_resourceLimitMgr.decrementResourceCount(networkFinal.getAccountId(),
ResourceType.network, networkFinal.getDisplayNetwork());
}
}
+return deletedVlans.second();
Review Comment:
ignore - this returns for _Transaction.execute()_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] When deploying node to Kubernetes it times out [cloudstack]
rohityadavcloud commented on issue #8975: URL: https://github.com/apache/cloudstack/issues/8975#issuecomment-2078651638 @PaX101 yes because you're listing the listVirtualMachinesMetrics API which by default returns VM stats (which slows down the API request). If you don't need all the details, you can pass details=min to the API response (or specific details you'd expect). If you're not able to control this API request, one way to address this could be to change the default behaviour that's change-able via global setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] OVS Netplan yaml config Ubuntu 22.04 documentation [cloudstack]
rohityadavcloud commented on issue #8983: URL: https://github.com/apache/cloudstack/issues/8983#issuecomment-2078648599 OVS related docs are here - https://docs.cloudstack.apache.org/en/4.19.0.1/plugins/ovs-plugin.html You're welcome also to contribute docs changes if you figure out setup instructions on Ubuntu. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Error code: Start system VM (v-375-VM) Fail to start system vm [cloudstack]
rohityadavcloud commented on issue #8984: URL: https://github.com/apache/cloudstack/issues/8984#issuecomment-2078647391 @priyanshusingh-in you'll need to read through the logs to see why is it failing, for example, you don't have enough VLANs or IP addresses, you don't have enough capacity (which could be CPU/RAM/disk space related) within the zone. Or some configuration related issues, which are specific to your environment. Since you've mentioned you've restarted your OS, is that the hypervisor host or your management server host? What has changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Error code: Start system VM (v-375-VM) Fail to start system vm [cloudstack]
boring-cyborg[bot] commented on issue #8984: URL: https://github.com/apache/cloudstack/issues/8984#issuecomment-2078639118 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Error code: Start system VM (v-375-VM) Fail to start system vm [cloudstack]
priyanshusingh-in opened a new issue, #8984: URL: https://github.com/apache/cloudstack/issues/8984 # ISSUE TYPE * Other # COMPONENT NAME ~~~ system VM ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0.0 ~~~ # CONFIGURATION # OS / ENVIRONMENT CentOS 7 # SUMMARY * Unable to start system VM after restarting my OS. * Able to launch instances. * Other Infrastructure is working fine.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
sureshanaparti commented on code in PR #8980:
URL: https://github.com/apache/cloudstack/pull/8980#discussion_r1580473624
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -3341,8 +3343,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
_resourceLimitMgr.decrementResourceCount(networkFinal.getAccountId(),
ResourceType.network, networkFinal.getDisplayNetwork());
}
}
+return deletedVlans.second();
Review Comment:
@vishesh92 seems this return skips publish events below, check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078615535 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
sureshanaparti commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078613964 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-terraform-provider) branch main updated: [StepSecurity] ci: Harden GitHub Actions (#103)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch main
in repository
https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git
The following commit(s) were added to refs/heads/main by this push:
new e4c9861 [StepSecurity] ci: Harden GitHub Actions (#103)
e4c9861 is described below
commit e4c986131f08ada761ea92c9f9e85c6dab5faa74
Author: StepSecurity Bot
AuthorDate: Thu Apr 25 21:26:41 2024 -0700
[StepSecurity] ci: Harden GitHub Actions (#103)
Signed-off-by: StepSecurity Bot
---
.github/workflows/build.yml | 3 +++
.github/workflows/testacc.yml | 3 +++
2 files changed, 6 insertions(+)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index f2acf05..0d13ff5 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -23,6 +23,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
cancel-in-progress: true
+permissions:
+ contents: read
+
jobs:
build:
runs-on: ubuntu-22.04
diff --git a/.github/workflows/testacc.yml b/.github/workflows/testacc.yml
index e2adc43..2534485 100644
--- a/.github/workflows/testacc.yml
+++ b/.github/workflows/testacc.yml
@@ -23,6 +23,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}-testacc
cancel-in-progress: true
+permissions:
+ contents: read
+
jobs:
testacc:
name: Acceptance Test
(cloudstack-terraform-provider) branch dependabot/go_modules/github.com/apache/cloudstack-go/v2-2.16.0 deleted (was cea1d18)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch dependabot/go_modules/github.com/apache/cloudstack-go/v2-2.16.0 in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git was cea1d18 Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.16.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [I] OVS Netplan yaml config Ubuntu 22.04 documentation [cloudstack]
boring-cyborg[bot] commented on issue #8983: URL: https://github.com/apache/cloudstack/issues/8983#issuecomment-2078416982 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] OVS Netplan yaml config Ubuntu 22.04 documentation [cloudstack]
Agility0493 opened a new issue, #8983:
URL: https://github.com/apache/cloudstack/issues/8983
# ISSUE TYPE
* Documentation Report
# COMPONENT NAME
~~~
OVS, openvswitch, Netplan, UI
~~~
# CLOUDSTACK VERSION
~~~
4.19.0.1
~~~
# CONFIGURATION
~~~
- Advanced Networking Mode
- KVM Hypervisor
- Openvswitch for network bridging
- We have 1 NIC to work with on this hypervisor host
~~~
# OS / ENVIRONMENT
~~~
Ubuntu 22.04 LTS
~~~
# SUMMARY
We are stuck and need your help with contributing to the docs
(https://docs.cloudstack.apache.org/en/4.19.0.1/installguide/hypervisor/kvm.html#configure-the-network-using-openvswitch).
The OVS section doesn't cover configuring networks on Ubuntu with Netplan.
Overall there is a lack of good documentation online. We are sharing our
research and starting this thread in hopes we can get unstuck and all can
contribute to the docs for future users as Debian based OS is very common.
# STEPS TO REPRODUCE
Everything up to the network configuration section in the docs has been
successfully configured and completed.
Our VLAN Schema:
~~~
Management: < 500
Public: 500 - 599
Guest (Private): 600 - 699
Guest (Public): 700 - 799
Project Specific: 900 - 999
Future Use: > 1000
~~~
**Commands used:**
1. Follow official OVS install docs: #
https://docs.openvswitch.org/en/latest/intro/install/distributions/#debian-ubuntu
The apt package includes all that's needed for Apache Cloudstack.
`sudo apt install openvswitch-switch`
3. Next disable native bridging to not interfere with OVS. To check status
of Bridge module:
`lsmod | grep bridge`
The "denylist" is called blacklist.conf on ubuntu, use this command to edit
it:
`sudo nano /etc/modprobe.d/blacklist.conf `
Add the lines:
`#turn off native bridging to not interfere with openVswitch
blacklist bridge
#turn off native bridging br_netfilter module
alias netfilter/bridge off`
4. Apply the changes:
`sudo depmod -a to apply`
5. remove modules br_netfilter and bridge. Note that br_netfilter is
dependent on bridge and has to be removed first.
`sudo rmmod br_netfilter`
`sudo rmmod bridge`
6. confirm removal:
`lsmod | grep bridge`
#https://developers.redhat.com/articles/2022/04/06/introduction-linux-bridging-commands-and-features#basic_bridge_commands
7. Linux Ubuntu has the ifup-ovs and ifdown-ovs scripts in the directory
/etc/network check to confirm they are there.
Our Current Network Strategy:
Assign VLAN 100 to "Management traffic", VLAN 500 to "public traffic", VLAN
700 to "guest public" and VLAN 101 to "storage."
8. Now that OVS is installed use the following commands:
```
$ sudo ovs-vsctl add-br cloudbr
$ sudo ovs-vsctl add-port cloudbr eth0
$ sudo ovs-vsctl set port cloudbr trunks=100,101,500,600
$ sudo ovs-vsctl add-br mgmt0 cloudbr 100
$ sudo ovs-vsctl add-br stor0 cloudbr 101
$ sudo ovs-vsctl add-br public0 cloudbr 500
$ sudo ovs-vsctl add-br guestpub0 cloudbr 700
```
We're not sure if the above plan translates to the Apache Cloudstack GUI
Zone configuration traffic labels or if our naming is best practice: mgmt0 =
"Management" , stor0 = "Storage", public0 = "Public", guestpub0 = "Guest".
Please confirm.
9. Once the configurations are in place for OVS you can confirm by using:
`$ sudo ovs-vsctl show`
10. Next we need to configure linux netplan to work with OVS. We've put
together the following yaml in /etc/netplan/01-netcfg.yaml.
~~~
network:
version: 2
renderer: networkd
ethernets:
eno1:
addresses: [/24]
openvswitch:
external-ids:
iface-id:
other-config:
disable-in-band: false
eno2: {}
bridges:
cloudbr:
addresses: [/24]
interfaces: [eno1]
openvswitch:
protocols: [OpenFlow10, OpenFlow11, OpenFlow12]
controller:
addresses: [unix:/var/run/openvswitch/ovs0.mgmt]
connection-mode: out-of-band
fail-mode: secure
mcast-snooping: true
external-ids:
iface-id: #not sure if hostname goes here.
other-config:
disable-in-band: true
mgmt0:
addresses: []
interfaces: [cloudbr 100]
openvswitch: {}
stor0:
addresses: []
interfaces: [cloudbr 101]
openvswitch: {}
public0:
addresses: []
interfaces: [cloudbr 500]
openvswitch: {}
guestpub0:
addresses: []
interfaces: [cloudbr 700]
openvswitch: {}
~~~
# EXPECTED RESULTS
~~~
Receive no errors when running:
sudo netplan try
Re: [PR] Clean up `.asf.yaml` collaborators [cloudstack]
codecov-commenter commented on PR #8982: URL: https://github.com/apache/cloudstack/pull/8982#issuecomment-2078407031 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8982?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.27%. Comparing base [(`cfdb33a`)](https://app.codecov.io/gh/apache/cloudstack/commit/cfdb33a052289ac4ff0410e6d8772942b0892bbd?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`d718a5e`)](https://app.codecov.io/gh/apache/cloudstack/pull/8982?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8982 +/- ## - Coverage 15.28% 4.27% -11.02% Files 5425 363 -5062 Lines474016 29549 -67 Branches 587525188-53564 - Hits 724411262-71179 + Misses 393519 28145 -365374 + Partials 8056 142 -7914 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8982/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8982/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.27% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8982/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8982?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]
blueorangutan commented on PR #8815: URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2078335427 [SF] Trillian test result (tid-10011) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 58395 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8815-t10011-vmware-67u3.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 360.73 | test_events_resource.py test_02_balanced_drs_algorithm | `Failure` | 141.19 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Limit `listRoles` API visibility [cloudstack]
blueorangutan commented on PR #8639: URL: https://github.com/apache/cloudstack/pull/8639#issuecomment-2078286456 [SF] Trillian test result (tid-10015) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54141 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8639-t10015-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 434.56 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] sanatise log in case multiple passwords have been passed [cloudstack]
blueorangutan commented on PR #8891: URL: https://github.com/apache/cloudstack/pull/8891#issuecomment-2078276219 [SF] Trillian test result (tid-10016) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52746 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8891-t10016-kvm-centos7.zip Smoke tests completed. 126 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 425.63 | test_events_resource.py test_08_arping_in_ssvm | `Failure` | 5.22 | test_diagnostics.py test_02_trigger_shutdown | `Failure` | 357.44 | test_safe_shutdown.py test_11_destroy_ssvm | `Error` | 3.22 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2078231719 [SF] Trillian test result (tid-10014) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 51258 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t10014-kvm-rocky8.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 444.16 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2078195656 [SF] Trillian test result (tid-10005) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 55775 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8968-t10005-vmware-67u3.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 346.17 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix ordering of secondary storages with the algorithm `firstfitleastconsumed` [cloudstack]
blueorangutan commented on PR #8557: URL: https://github.com/apache/cloudstack/pull/8557#issuecomment-2078188112 [SF] Trillian test result (tid-10013) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50003 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8557-t10013-kvm-centos7.zip Smoke tests completed. 126 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 312.05 | test_events_resource.py test_01_events_resource | `Error` | 312.06 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 94.86 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.50 | test_network_permissions.py test_hostha_enable_ha_when_host_disabled | `Error` | 4.99 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.10 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]
blueorangutan commented on PR #8815: URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2078174882 [SF] Trillian test result (tid-10010) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49526 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8815-t10010-xenserver-71.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 377.00 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078131248 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve migration of external VMware VMs into KVM cluster [cloudstack]
blueorangutan commented on PR #8815: URL: https://github.com/apache/cloudstack/pull/8815#issuecomment-2078123201 [SF] Trillian test result (tid-10012) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47347 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8815-t10012-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 424.03 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2078063086 @weizhouapache a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
weizhouapache commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2078062164 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix: Update rootdisksize detail on restore VM [cloudstack]
codecov-commenter commented on PR #8981: URL: https://github.com/apache/cloudstack/pull/8981#issuecomment-2078039176 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8981?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.31%. Comparing base [(`e409c6d`)](https://app.codecov.io/gh/apache/cloudstack/commit/e409c6d870a49762fb4e730ad118a3a836715cc5?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`dc41e2b`)](https://app.codecov.io/gh/apache/cloudstack/pull/8981?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #8981 +/- ## - Coverage 14.96% 4.31% -10.65% Files 5373 363 -5010 Lines468989 29171 -439818 Branches 610095089-55920 - Hits 701911260-68931 + Misses 391019 27770 -363249 + Partials 7779 141 -7638 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8981/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8981/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.31% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8981/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8981?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
codecov-commenter commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078028420 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8980?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.31%. Comparing base [(`e409c6d`)](https://app.codecov.io/gh/apache/cloudstack/commit/e409c6d870a49762fb4e730ad118a3a836715cc5?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`f6013a1`)](https://app.codecov.io/gh/apache/cloudstack/pull/8980?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #8980 +/- ## - Coverage 14.96% 4.31% -10.65% Files 5373 363 -5010 Lines468989 29171 -439818 Branches 610095089-55920 - Hits 701911260-68931 + Misses 391019 27770 -363249 + Partials 7779 141 -7638 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8980/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8980/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.31% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8980/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8980?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix: Update rootdisksize detail on restore VM [cloudstack]
vishesh92 opened a new pull request, #8981:
URL: https://github.com/apache/cloudstack/pull/8981
### Description
This PR fixes the below issue:
1. Register two VM templates, small and large.
2. Deploy VM using smaller template while overriding the rootdisksize
3. Start VM if not started
4. Stop VM
5. Reinstall VM to larger VM template
6. Observe new root is the size of old volume. This is happening because the
`rootdisksize` detail for VM overrides the template's size.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078016479 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
vishesh92 commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078013116 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix message publish in transaction [cloudstack]
vishesh92 opened a new pull request, #8980:
URL: https://github.com/apache/cloudstack/pull/8980
### Description
This PR fixes the below error log on deleting a shared network.
```java
2024-04-24 18:24:33,831 ERROR [o.a.c.f.m.MessageBusBase]
(API-Job-Executor-14:ctx-63de092f job-2044 ctx-d00db98a) (logid:107d5ed5) NO
EVENT PUBLISH CAN BE WRAPPED WITHIN DB TRANSAC
TION!
com.cloud.utils.exception.CloudRuntimeException: NO EVENT PUBLISH CAN BE
WRAPPED WITHIN DB TRANSACTION!
at
org.apache.cloudstack.framework.messagebus.MessageBusBase.publish(MessageBusBase.java:167)
at
com.cloud.configuration.ConfigurationManagerImpl.deleteVlanAndPublicIpRange(ConfigurationManagerImpl.java:5345)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
at com.sun.proxy.$Proxy156.deleteVlanAndPublicIpRange(Unknown Source)
at
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.deleteVlansInNetwork(NetworkOrchestrator.java:3368)
```
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Host HA not working even after configured oob-management [cloudstack]
spdinis commented on issue #7543: URL: https://github.com/apache/cloudstack/issues/7543#issuecomment-2077714357 Hi, We are preparing a transition from vmware to kvm and we are struggling to get HA to work with the same symptoms. We are using Cloudstack 4.19.0 we have few test clusters that have nfs mount for heartbeat and we will be using shared mount. for the case we tried with simple NFS and made no difference. We have the out of band enabled and when we power off the physical host via iDRAC, the host moves to fencing after a while and stays in that status and all VMs that were running on it, keep saying running. Once we declare manually that the host is degraded, VMs jump straight to another host. One of the surviving nodes agent logs shows it detects that the host is down as slavkap showed: 2024-04-25 15:34:11,406 WARN [kvm.resource.KVMHAChecker] (pool-636-thread-1:null) (logid:29cd972b) All checks with KVMHAChecker for host IP [10.250.9.154] in pools [e355eb3b-58eb-3ce2-890a-6a7b7263d896, b7f5ff6f-7233-3d79-aa1a-1c1bc233e1c8] considered it as dead. It may cause a shutdown of the host. So I presume the issue is related to the transition to another state after fencing. We will perform some additional tests using redfish for example, or by try to force some non power off failure, see if it is an issue with the agent detecting that the IPMI is actually off assuming it was a voluntary action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
rohityadavcloud commented on PR #8974: URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077703569 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
blueorangutan commented on PR #8974: URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077705259 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
blueorangutan commented on PR #8974: URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077583606 [SF] Trillian Build Failed (tid-10031) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
blueorangutan commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2077563680 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Wrong API call from the UI on the 'Network > VNF appliances' page [cloudstack]
weizhouapache commented on issue #8979: URL: https://github.com/apache/cloudstack/issues/8979#issuecomment-2077503056 @vladimirpetrov thanks for reporting this seems to be caused by he change in my pr #8668 let me fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077498151 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Adding S3 secondary storage fails with NPE [cloudstack]
philtreF commented on issue #8956: URL: https://github.com/apache/cloudstack/issues/8956#issuecomment-2077491556 Got the exact same issue with 4.18.1 I am using Ceph as a storage backend. As a side-note I also tried Swift, ends with a SQL error : ``` Failed to add data store: DB Exception on: com.mysql.cj.jdbc.ClientPreparedStatement: INSERT INTO image_store_details (image_store_details.store_id, image_store_details.name, image_store_details.value, image_store_details.display) VALUES [...] ``` NFS works but once I put NFS into production I will be stuck with NFS for this region as far as I understood... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2077478988 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Wrong API call from the UI on the 'Network > VNF appliances' page [cloudstack]
vladimirpetrov opened a new issue, #8979: URL: https://github.com/apache/cloudstack/issues/8979 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19.1 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY The 'VNF appliances' view generates an error on loading. # STEPS TO REPRODUCE ~~~ Go to Network > VNF appliances. You can also click 'Refresh' to see the error again. ~~~ # EXPECTED RESULTS ~~~ No error message. ~~~ # ACTUAL RESULTS ~~~ The following error is displayed: "Unable to execute API command listtemplates due to missing parameter templatefilter" Here is the actual API call sent by the UI: listall=true=servoff,tmpl,nics=true=1=20=listVnfTemplates=json ~~~  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2077439881 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
blueorangutan commented on PR #8974: URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077438502 @rohityadavcloud a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
rohityadavcloud commented on PR #8974: URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077433882 @blueorangutan test alma8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
blueorangutan commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2077416040 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8978 (QA-JID-322) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.18 updated: explanatory error message on delete attempt of default system offering (#8883)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.18 by this push:
new eead2710f81 explanatory error message on delete attempt of default
system offering (#8883)
eead2710f81 is described below
commit eead2710f81858ff889f526c6d1955d0b91cca5f
Author: dahn
AuthorDate: Thu Apr 25 16:45:42 2024 +0200
explanatory error message on delete attempt of default system offering
(#8883)
Co-authored-by: Gabriel Pordeus Santos
---
.../src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
index 080bb83253c..f0e7522bc79 100644
--- a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -4204,7 +4204,7 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
}
if (offering.getDefaultUse()) {
-throw new InvalidParameterValueException("Default service
offerings cannot be deleted");
+throw new InvalidParameterValueException(String.format("The system
service offering [%s] is marked for default use and cannot be deleted",
offering.getDisplayText()));
}
final User user = _userDao.findById(userId);
Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]
DaanHoogland merged PR #8883: URL: https://github.com/apache/cloudstack/pull/8883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Keyboard Shortcut(s) [cloudstack]
vladimirpetrov commented on PR #8250: URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2077365412 Hi @apurv-1, I tested the feature but it seems that the 'r' shortcut doesn't work on the following pages: - 'Domains' page - 'Infrastructure' summary page - 'Infrastructure' - CPU sockets page - 'Infrastructure' - DB/Usage server page - 'Configuration' - Global Settings - 'Tools' - Import-Export Instances -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
blueorangutan commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2077351941 @BryanMLima a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null host tags while creating a zone [cloudstack]
codecov-commenter commented on PR #8976: URL: https://github.com/apache/cloudstack/pull/8976#issuecomment-2077351808 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8976?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 15.28%. Comparing base [(`a5508ac`)](https://app.codecov.io/gh/apache/cloudstack/commit/a5508acc54d1638ba469f4d7ce9898b81b5209d0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`4f72cb6`)](https://app.codecov.io/gh/apache/cloudstack/pull/8976?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 627 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#8976 +/- ## = + Coverage 13.17% 15.28%+2.11% - Complexity 921411524 +2310 = Files 2725 5425 +2700 Lines258235 474016 +215781 Branches 4024957669+17420 = + Hits 3401372446+38433 - Misses 219913 393513 +173600 - Partials 4309 8057 +3748 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8976/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8976/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.27% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8976/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `16.01% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8976?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
BryanMLima commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2077350080 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
codecov-commenter commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077347864 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `1 lines` in your changes are missing coverage. Please review. > Project coverage is 15.67%. Comparing base [(`e409c6d`)](https://app.codecov.io/gh/apache/cloudstack/commit/e409c6d870a49762fb4e730ad118a3a836715cc5?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`fb496dc`)](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8977?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fvm%2FUserVmManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8977?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#8977 +/- ## + Coverage 14.96% 15.67% +0.70% - Complexity1099510997 +2 Files 5373 5010 -363 Lines468989 439818 -29171 Branches 6100955977-5032 - Hits 7019168945-1246 + Misses 391019 363230 -27789 + Partials 7779 7643 -136 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8977/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8977/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8977/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `15.67% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
weizhouapache commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2077343937 test kvm-alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
codecov-commenter commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2077331262 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8898?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `54 lines` in your changes are missing coverage. Please review. > Project coverage is 12.24%. Comparing base [(`f731fe8`)](https://app.codecov.io/gh/apache/cloudstack/commit/f731fe882c5b8459a14da9a13269a8360df2743e?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`7c9b467`)](https://app.codecov.io/gh/apache/cloudstack/pull/8898?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 34 commits behind head on 4.18. | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8898?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...cloudstack/storage/image/store/TemplateObject.java](https://app.codecov.io/gh/apache/cloudstack/pull/8898?src=pr=tree=engine%2Fstorage%2Fimage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fstorage%2Fimage%2Fstore%2FTemplateObject.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3N0b3JhZ2UvaW1hZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9pbWFnZS9zdG9yZS9UZW1wbGF0ZU9iamVjdC5qYXZh) | 0.00% | [47 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8898?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...e/cloudstack/storage/volume/VolumeServiceImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8898?src=pr=tree=engine%2Fstorage%2Fvolume%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fstorage%2Fvolume%2FVolumeServiceImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3N0b3JhZ2Uvdm9sdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2Uvdm9sdW1lL1ZvbHVtZVNlcnZpY2VJbXBsLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8898?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.18#8898 +/- ## = - Coverage 13.16% 12.24%-0.93% - Complexity 9203 9290 +87 = Files 2724 4698 +1974 Lines258130 414260 +156130 Branches 4023253320+13088 = + Hits 3398950706+16717 - Misses 219833 357253 +137420 - Partials 4308 6301 +1993 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8898/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8898/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `12.24% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8898?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2077319597 [SF] Trillian Build Failed (tid-10029) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
blueorangutan commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2077263585 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077268490 code looks good @vishesh92 Can you add 1-2 lines to one of the existing integration tests to cover this test case (restore vm twice)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [UI] Storage menu not showing even with API permissions [cloudstack]
winterhazel commented on issue #8730: URL: https://github.com/apache/cloudstack/issues/8730#issuecomment-2077261084 Hey everyone, I've implemented @BryanMLima's idea in #8978. The filtering still works as an AND operator for routes that correspond to a page; however, I have changed so that routes corresponding to sections get shown if the user has access to any of its pages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
winterhazel commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2077257273 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
blueorangutan commented on PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#issuecomment-2077255654 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Show menu section if user has access to at least one of its pages [cloudstack]
winterhazel opened a new pull request, #8978:
URL: https://github.com/apache/cloudstack/pull/8978
### Description
As reported in
https://github.com/apache/cloudstack/pull/8713#issuecomment-1969866705, the
Storage section in the sidebar is not displayed to users when they do not have
permission to the API `listVolumesMetrics`. However, roles can have permissions
to other APIs, such as `listBackups` and `listSnapshots`, in which case the
section should be displayed. This situation is not exclusive to the Storage
section.
This PR fixes this issue by changing how the routes are filtered. Now,
sections will be shown if they have at least one visible child. For other
routes, the previous logic is still applied.
Closes #8730.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Here's how the menu looks like before (left) and after the changes (right)
for a user that does not have permission for `listVolumesMetrics`:
### How Has This Been Tested?
1. I created a role `v` that had access to `listSnapshots` and
`listBuckets`, but did not have to `listVolumesMetrics`;
2. I created an account `v` using role `v`;
3. I accessed the UI using account `v`;
4. I verified that the Storage section was shown, having the Volume
Snapshots and Buckets pages;
5. I verified that the other sections did not change;
6. I clicked the Storage section and verified that I was redirected to the
Volume Snapshots page;
7. I denied `listSnaphots` and `listBuckets` for role `v`;
8. I logged out, cleared my cache and logged in again. I verified that the
Storage section was not shown anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
vishesh92 commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077233309 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077234570 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix restore VM with allocated root disk [cloudstack]
vishesh92 opened a new pull request, #8977:
URL: https://github.com/apache/cloudstack/pull/8977
### Description
This PR fixes the following issues
1. Try to restore a VM twice in stopped state, it will throw an error.
2. Fix the default template selection in reinstallVM modal.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2077212221 [SF] Trillian Build Failed (tid-10028) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]
codecov-commenter commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2077180048 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8919?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.26%. Comparing base [(`a5508ac`)](https://app.codecov.io/gh/apache/cloudstack/commit/a5508acc54d1638ba469f4d7ce9898b81b5209d0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`9fcc187`)](https://app.codecov.io/gh/apache/cloudstack/pull/8919?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 627 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8919 +/- ## - Coverage 13.17% 4.26%-8.91% Files 2725 364 -2361 Lines258235 29573 -228662 Branches 402495213-35036 - Hits 340131262-32751 + Misses 219913 28169 -191744 + Partials 4309 142 -4167 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8919/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8919/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.26% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8919?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable defining a network as redundant during restart through the UI [cloudstack]
JoaoJandre commented on PR #7405: URL: https://github.com/apache/cloudstack/pull/7405#issuecomment-2077178685 > @DaanHoogland @borisstoyanov @weizhouapache @andrijapanicsb @rohityadavcloud @alexandremattioli @NuxRo > > I see that the comunity has mixed opinions regarding this functionality, however, I still believe we should maintain conformity on the API and the UI. In order to achieve this without raising further discussions, I propose that we create a global configuration with default value `false` that dictates whether this parameter can be used (both on the UI and the API). If set to false, it will not show up on the UI and trying to use it on the API will generate an exception. > > This would give operators the flexibility to remove this feature from the backend if they see it as harmful, or leave it both on the backend and the frontend if they see it as helpful. > > Would this implementation be enough to offset your concerns regarding this feature? @GaOrtiga The problem with the proposed solution is that this is **breaking backwards compatibility**. When users update to 4.20, they'll start to get an exception when informing this parameter on the API. This kind of change should only be made when changing major versions. Last month I made a proposal for a release schedule that would let us do this kind of change (see https://lists.apache.org/thread/o6o9h3qp8gqrpq4v7o81tl6vp51tkjhg) but sadly it got almost no traction; there is a new discussion thread about it now (https://github.com/apache/cloudstack/discussions/8970), I hope we can advance it this time. As the project stands right now, this proposal should not be accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix null host tags while creating a zone [cloudstack]
GaOrtiga opened a new pull request, #8976:
URL: https://github.com/apache/cloudstack/pull/8976
### Description
In the UI, during zone creation, if a new host is created without specifying
host tags, ACS adds the 'null' tag to it automatically.
This behaviour has been fixed, making it so that no host tags are added in
this situation
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### How Has This Been Tested?
I created a zone through the UI without specifying host tags and verified
that no tags were added.
I also created while specifying host tags and verified that they were added
accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]
codecov-commenter commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2077170484 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8624?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `2 lines` in your changes are missing coverage. Please review. > Project coverage is 30.95%. Comparing base [(`0d36098`)](https://app.codecov.io/gh/apache/cloudstack/commit/0d36098c76833ad3f7510f72e54ece3f3d7f3ba2?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`9855c1c`)](https://app.codecov.io/gh/apache/cloudstack/pull/8624?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 137 commits behind head on 4.19. > :exclamation: Current head 9855c1c differs from pull request most recent head 89cb8a4. Consider uploading reports for the commit 89cb8a4 to get more accurate results | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8624?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...src/main/java/com/cloud/api/ApiResponseHelper.java](https://app.codecov.io/gh/apache/cloudstack/pull/8624?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fapi%2FApiResponseHelper.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9BcGlSZXNwb25zZUhlbHBlci5qYXZh) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8624?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#8624 +/- ## + Coverage 30.75% 30.95% +0.20% - Complexity3396434220 +256 Files 5346 5346 Lines375435 375447 +12 Branches 5460354606 +3 + Hits 115460 116218 +758 + Misses 244742 243914 -828 - Partials 1523315315 +82 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8624/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8624/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `24.85% <0.00%> (+0.33%)` | :arrow_up: | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8624/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8624/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `16.54% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8624?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2077170022 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
blueorangutan commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-2077166741 [SF] Trillian Build Failed (tid-10027) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
blueorangutan commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2077166383 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]
blueorangutan commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2077150395 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8919 (QA-JID-321) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add logs to CPVM connection process [cloudstack]
winterhazel commented on code in PR #8924:
URL: https://github.com/apache/cloudstack/pull/8924#discussion_r1578602401
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java:
##
@@ -93,23 +93,24 @@ public void initClient(ConsoleProxyClientParam param) {
client = new NoVncClient();
connectionAlive = true;
this.sessionUuid = param.getSessionUuid();
+String clientSourceIp = param.getClientIp();
+logger.debug("Initializing client from IP {}", clientSourceIp);
Review Comment:
```suggestion
logger.debug("Initializing client from IP {}.", clientSourceIp);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]
blueorangutan commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2077119147 @BryanMLima a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]
BryanMLima commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2077118355 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]
BryanMLima commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2077117612 > Did some more testing @BryanMLima the illusive "Request failed." actually happens when selecting a domain in your dialog that doesn't contain any account/users. Nice catch, I fixed this issue in the last commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
blueorangutan commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2077107548 [SF] Trillian Build Failed (tid-10024) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]
DaanHoogland commented on issue #8967: URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2077094467 > We are currently waiting for the 4.18.2.0 to be released as our next upgrade candidate. it has been released ;) As for how to prevent it, I have no ready answer. When creating the situation at fault, does cloudstack in its DB have any proof of the double assignment? - We can make sure that VRs are being convergently reconfigured when/if the situation is found. - Another solution would be a system wide lock, which is a performance hog and I would advise against. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2077087742 [SF] Trillian Build Failed (tid-10023) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
blueorangutan commented on PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#issuecomment-2077083287 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
sureshanaparti commented on PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#issuecomment-2077081874 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
sureshanaparti commented on code in PR #8947:
URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1579396700
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -839,6 +839,21 @@ protected String createLocalStoragePoolName(Host host,
StoragePoolInfo storagePo
return String.format("%s-%s-%s", StringUtils.trim(host.getName()),
"local", storagePoolInformation.getUuid().split("-")[0]);
}
+protected void checkNfsOptions(String nfsopts) throws
InvalidParameterValueException {
+String[] options = nfsopts.replaceAll("\\s", "").split(",");
+Map optionsMap = new HashMap<>();
+for (String option : options) {
+String[] keyValue = option.split("=");
+if (keyValue.length > 2) {
+throw new InvalidParameterValueException("Invalid value for
NFS option " + keyValue[0]);
+}
+if (optionsMap.containsKey(keyValue[0])) {
+throw new InvalidParameterValueException("Duplicate NFS option
values found for option " + keyValue[0]);
+}
+optionsMap.put(keyValue[0], null);
Review Comment:
(re-)mount may fail with incorrect options, hope the relevant message is
thrown to the operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
sureshanaparti commented on code in PR #8947:
URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1579394028
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -654,20 +654,54 @@ public KVMStoragePool createStoragePool(String name,
String host, int port, Stri
} catch (LibvirtException e) {
s_logger.error("Failure in attempting to see if an existing
storage pool might be using the path of the pool to be created:" + e);
}
+}
+
+List nfsopts = null;
+if (type == StoragePoolType.NetworkFilesystem) {
+if (details != null && details.containsKey("nfsopts")) {
+nfsopts =
Arrays.asList(details.get("nfsopts").replaceAll("\\s", "").split(","));
+}
+
+if (sp != null && nfsopts != null) {
+try {
+LibvirtStoragePoolDef poolDef = getStoragePoolDef(conn,
sp);
+Map poolNfsOptsMap = poolDef.getNfsOpts();
+boolean optionsDiffer = false;
+if (poolNfsOptsMap.size() != nfsopts.size()) {
+optionsDiffer = true;
+} else {
+for (String nfsopt : nfsopts) {
+if (!poolNfsOptsMap.containsKey(nfsopt)) {
Review Comment:
Ok, I'm assuming` key=vers` & `value=4.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2077061894 @rohityadavcloud a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2077059529 @blueorangutan test alma8 kvm-alma8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Backroll Plugin [cloudstack]
PeterBackroll opened a new pull request, #8251:
URL: https://github.com/apache/cloudstack/pull/8251
### Description
This is the pull request for Backroll Plugin (a backup & restore plugin).
This plugin allows users to use Backroll as backup provider inside
Cloudstack.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
DaanHoogland closed pull request #8251: Backroll Plugin URL: https://github.com/apache/cloudstack/pull/8251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
rajujith commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-2077010179 @PeterBackroll I would like to try backroll with CloudStack, could you provide some documents to configure it with cloudstack. If could respond to the changes recommended above I would test it after you have made any changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
winterhazel commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2077007474 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
blueorangutan commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2077008276 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076998747 @rohityadavcloud a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076996339 @blueorangutan test alma8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
