[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical

2023-01-18 Thread GitBox
blueorangutan commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386681785 @davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland merged pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-18 Thread GitBox
DaanHoogland merged PR #7073: URL: https://github.com/apache/cloudstack/pull/7073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] DaanHoogland commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-18 Thread GitBox
DaanHoogland commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1386680795 tested in a lab env :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical

2023-01-18 Thread GitBox
davidjumani commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386680255 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7075: UI: add filter user/all to list user/all volumes

2023-01-18 Thread GitBox
blueorangutan commented on PR #7075: URL: https://github.com/apache/cloudstack/pull/7075#issuecomment-1386669391 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on pull request #7075: UI: add filter user/all to list user/all volumes

2023-01-18 Thread GitBox
DaanHoogland commented on PR #7075: URL: https://github.com/apache/cloudstack/pull/7075#issuecomment-1386668603 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6924: [Draft] User two factor authentication

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1386663621 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication

2023-01-18 Thread GitBox
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1386655757 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5303 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

2023-01-18 Thread GitBox
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386650187 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

2023-01-18 Thread GitBox
DaanHoogland commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386649043 I'd say ready for merge, but one last pass @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7061: Rollback of changes with errors during the VM assign

2023-01-17 Thread GitBox
weizhouapache commented on code in PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#discussion_r1073196190 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -7052,525 +7051,766 @@ public VirtualMachine migrateVirtualMachineWithVolume(Long vmId,

[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #7102: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec when building cloudstack from source

2023-01-17 Thread GitBox
boring-cyborg[bot] commented on issue #7102: URL: https://github.com/apache/cloudstack/issues/7102#issuecomment-1386630221 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] mail2lawi opened a new issue, #7102: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec when building cloudstack from source

2023-01-17 Thread GitBox
mail2lawi opened a new issue, #7102: URL: https://github.com/apache/cloudstack/issues/7102 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386625240 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication

2023-01-17 Thread GitBox
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1386605271 @harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6924: [Draft] User two factor authentication

2023-01-17 Thread GitBox
harikrishna-patnala commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1386604262 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] weizhouapache commented on issue #6865: A running vm cannot dynamically scale cpu and memory. It can be expanded when stopped

2023-01-17 Thread GitBox
weizhouapache commented on issue #6865: URL: https://github.com/apache/cloudstack/issues/6865#issuecomment-1386556512 > Hello @1450793561 @weizhouapache > > KVM requires defining ranges for CPU and memory in the VM XML to allow the VM to be dynamically scaled. Currently, those ranges

[GitHub] [cloudstack] weizhouapache commented on pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
weizhouapache commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1386551978 @rohityadavcloud The trillian failures are not related, no worries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-17 Thread GitBox
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1386530087 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5301 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
blueorangutan commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1386530088 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5300 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7061: Rollback of changes with errors during the VM assign

2023-01-17 Thread GitBox
blueorangutan commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1386530089 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5302 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7100: api/server: add project id/name in ssh keypair response

2023-01-17 Thread GitBox
blueorangutan commented on PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386524782 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5299 -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
rohityadavcloud commented on code in PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#discussion_r1073103958 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -19,6 +19,10 @@ -- Schema upgrade from 4.17.2.0 to 4.18.0.0 --; +-- Add

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1386503101 @rohityadavcloud a Trillian-Jenkins test job (ubuntu20 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
rohityadavcloud commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1386502975 @blueorangutan test ubuntu20 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #7061: Rollback of changes with errors during the VM assign

2023-01-17 Thread GitBox
blueorangutan commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1386502525 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-17 Thread GitBox
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1386502496 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-17 Thread GitBox
rohityadavcloud commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1386502294 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7061: Rollback of changes with errors during the VM assign

2023-01-17 Thread GitBox
rohityadavcloud commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1386501801 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
blueorangutan commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1386499853 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
rohityadavcloud commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1386499547 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7100: api/server: add project id/name in ssh keypair response

2023-01-17 Thread GitBox
blueorangutan commented on PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386496714 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7100: api/server: add project id/name in ssh keypair response

2023-01-17 Thread GitBox
rohityadavcloud commented on PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386496452 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud merged pull request #7091: .github: run all gha on ubuntu latest

2023-01-17 Thread GitBox
rohityadavcloud merged PR #7091: URL: https://github.com/apache/cloudstack/pull/7091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] rahulbcn27 commented on issue #6855: UI: make display elements optional

2023-01-17 Thread GitBox
rahulbcn27 commented on issue #6855: URL: https://github.com/apache/cloudstack/issues/6855#issuecomment-1386450786 Thanks @rohityadavcloud .Working on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-17 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1386388350 Trillian test result (tid-5878) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48427 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-17 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1386356511 Trillian test result (tid-5879) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44969 seconds Marvin logs:

[GitHub] [cloudstack] GutoVeronezi commented on issue #6865: A running vm cannot dynamically scale cpu and memory. It can be expanded when stopped

2023-01-17 Thread GitBox
GutoVeronezi commented on issue #6865: URL: https://github.com/apache/cloudstack/issues/6865#issuecomment-1386334137 Hello @1450793561 @weizhouapache KVM requires defining ranges for CPU and memory in the VM XML to allow the VM to be dynamically scaled. Currently, those ranges are

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-17 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1386329029 Trillian test result (tid-5877) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44025 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-17 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1386298966 Trillian test result (tid-5876) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41982 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1386247617 Trillian test result (tid-5874) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server u20 Total time taken: 49664 seconds Marvin logs:

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386079381 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
weizhouapache commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072817262 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,16 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
GutoVeronezi commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072786938 ## server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java: ## @@ -303,6 +310,16 @@ private ConsoleEndpoint

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
GutoVeronezi commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072763279 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,16 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

2023-01-17 Thread GitBox
weizhouapache commented on code in PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072572879 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java: ## @@ -33,7 +35,7 @@ public class KVMHABase { private long

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

2023-01-17 Thread GitBox
stephankruggg commented on code in PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072549527 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java: ## @@ -33,7 +35,7 @@ public class KVMHABase { private long

[GitHub] [cloudstack] nvazquez commented on pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
nvazquez commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385787949 @GutoVeronezi thanks for the refactor, you are right I have now checked that the lastUsedTime on the ConsoleProxyLoadReportCommand keeps being updated even when the session is not

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
weizhouapache commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072541492 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,16 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385750812 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-17 Thread GitBox
DaanHoogland commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385691406 retested in qa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads and IO driver policy

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385627335 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] codecov[bot] commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-17 Thread GitBox
codecov[bot] commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385560598 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] weizhouapache commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2023-01-17 Thread GitBox
weizhouapache commented on PR #6386: URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1385546049 anyone has tested this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] codecov[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-17 Thread GitBox
codecov[bot] commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1385542392 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6973: conditional logging for prio

2023-01-17 Thread GitBox
github-actions[bot] commented on PR #6973: URL: https://github.com/apache/cloudstack/pull/6973#issuecomment-1385539340 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6012: Add volume group handling

2023-01-17 Thread GitBox
github-actions[bot] commented on PR #6012: URL: https://github.com/apache/cloudstack/pull/6012#issuecomment-1385539293 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7100: api/server: add project id/name in ssh keypair response

2023-01-17 Thread GitBox
weizhouapache commented on code in PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#discussion_r1072300454 ## api/src/main/java/org/apache/cloudstack/api/response/SSHKeyPairResponse.java: ## @@ -46,6 +46,14 @@ public class SSHKeyPairResponse extends

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

2023-01-17 Thread GitBox
weizhouapache commented on code in PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072258310 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java: ## @@ -33,7 +35,7 @@ public class KVMHABase { private long

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385478982 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] blueorangutan commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-17 Thread GitBox
blueorangutan commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385471705 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7067 (QA-JID-30) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] blueorangutan commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-17 Thread GitBox
blueorangutan commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385462500 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-17 Thread GitBox
DaanHoogland commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385461270 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7091: .github: run all gha on ubuntu latest

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1385453892 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1385447208 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7100: api/server: add project id/name in ssh keypair response

2023-01-17 Thread GitBox
DaanHoogland commented on code in PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#discussion_r1072226672 ## api/src/main/java/org/apache/cloudstack/api/response/SSHKeyPairResponse.java: ## @@ -46,6 +46,14 @@ public class SSHKeyPairResponse extends

[GitHub] [cloudstack] DaanHoogland merged pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2023-01-17 Thread GitBox
DaanHoogland merged PR #6386: URL: https://github.com/apache/cloudstack/pull/6386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
weizhouapache commented on code in PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#discussion_r1072206782 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -19,6 +19,10 @@ -- Schema upgrade from 4.17.2.0 to 4.18.0.0 --; +-- Add

[GitHub] [cloudstack] codecov[bot] commented on pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
codecov[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385416900 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] weizhouapache closed issue #7101: Compute offering for VR provider specified in network offering is ignored when using web interface

2023-01-17 Thread GitBox
weizhouapache closed issue #7101: Compute offering for VR provider specified in network offering is ignored when using web interface URL: https://github.com/apache/cloudstack/issues/7101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] weizhouapache commented on issue #7101: Compute offering for VR provider specified in network offering is ignored when using web interface

2023-01-17 Thread GitBox
weizhouapache commented on issue #7101: URL: https://github.com/apache/cloudstack/issues/7101#issuecomment-1385411877 Hi @tbudx thanks for your report. this issue has been recently fixed by #7057 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] weizhouapache commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

2023-01-17 Thread GitBox
weizhouapache commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385400537 @rohityadavcloud @DaanHoogland I made some changes for envs wth multiple zones with different types. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6938: Create API to reassign volume

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #6938: URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1385379064 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-17 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1385372910 @borisstoyanov a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is

[GitHub] [cloudstack] borisstoyanov commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-17 Thread GitBox
borisstoyanov commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1385372291 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385346000 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
GutoVeronezi commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072115961 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1036,9 +1036,9 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`,

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
GutoVeronezi commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072115452 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,10 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE

[GitHub] [cloudstack] GutoVeronezi commented on pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
GutoVeronezi commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385309721 @DaanHoogland @nvazquez @rohityadavcloud @weizhouapache I redesigned the table `console_session` to store more data, based on the idea in

[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads and IO driver policy

2023-01-17 Thread GitBox
slavkap commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385291913 Thanks, @wido! A lot has changed from the initial idea, but I think it's ready for review -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads and IO driver policy

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385291199 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
rohityadavcloud commented on code in PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#discussion_r1072092572 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -19,6 +19,10 @@ -- Schema upgrade from 4.17.2.0 to 4.18.0.0 --; +-- Add

[GitHub] [cloudstack] slavkap commented on a diff in pull request #6909: KVM support of iothreads and IO driver policy

2023-01-17 Thread GitBox
slavkap commented on code in PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1072088093 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java: ## @@ -3185,12 +3199,32 @@ protected String

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7059: guestos: add el9 distros

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #7059: URL: https://github.com/apache/cloudstack/pull/7059#issuecomment-1385254134 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #7101: Compute offering for VR provider specified in network offering is ignored when using web interface

2023-01-17 Thread GitBox
boring-cyborg[bot] commented on issue #7101: URL: https://github.com/apache/cloudstack/issues/7101#issuecomment-1385103008 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] tbudx opened a new issue, #7101: Compute offering for VR provider specified in network offering is ignored when using web interface

2023-01-17 Thread GitBox
tbudx opened a new issue, #7101: URL: https://github.com/apache/cloudstack/issues/7101 # ISSUE TYPE * Bug Report # COMPONENT NAME Network offering # CLOUDSTACK VERSION 4.17.1.0, 4.17.2.0, earlier versions not tested #

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1385089386 @weizhouapache a Trillian-Jenkins test job (ubuntu20 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #7046: Add support for vSphere 8.0

2023-01-17 Thread GitBox
weizhouapache commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1385087533 @blueorangutan test ubuntu20 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] weizhouapache commented on issue #6865: A running vm cannot dynamically scale cpu and memory. It can be expanded when stopped

2023-01-17 Thread GitBox
weizhouapache commented on issue #6865: URL: https://github.com/apache/cloudstack/issues/6865#issuecomment-1385076840 @1450793561 as @DaanHoogland mentioned, this is a known limitation, introduced by #4878 the UI change was introduced in #5923 ``` if

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7100: api/server: add project id/name in ssh keypair response

2023-01-17 Thread GitBox
weizhouapache opened a new pull request, #7100: URL: https://github.com/apache/cloudstack/pull/7100 ### Description This fixes #7096 ### Types of changes - [ ] Breaking change (fix or feature that would cause

[GitHub] [cloudstack] rohityadavcloud opened a new issue, #7099: Add Github Action support to other repos

2023-01-17 Thread GitBox
rohityadavcloud opened a new issue, #7099: URL: https://github.com/apache/cloudstack/issues/7099 Migrate from Travis to Github Actions: https://github.com/apache/cloudstack-cloudmonkey (https://github.com/apache/cloudstack-cloudmonkey/issues/120)

[GitHub] [cloudstack] rohityadavcloud commented on issue #6855: UI: make display elements optional

2023-01-17 Thread GitBox
rohityadavcloud commented on issue #6855: URL: https://github.com/apache/cloudstack/issues/6855#issuecomment-1384997473 with @rahulbcn27 attempting it cc @DaanHoogland @weizhouapache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7091: .github: run all gha on ubuntu latest

2023-01-17 Thread GitBox
rohityadavcloud commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1384993699 @DaanHoogland I think the ubuntu-latest is buggy in how Github Actions interprets it, it's better to be specific and move everything to ubuntu-22.04. -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-17 Thread GitBox
rohityadavcloud commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1071872532 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1036,9 +1036,9 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`,

[GitHub] [cloudstack] wido commented on pull request #6909: KVM support of iothreads

2023-01-16 Thread GitBox
wido commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1384902598 > Ok, great! This PR is very much welcome. Looking forward to the changes so I can do an additional review. Ping @Rubueno and @BartJM to get them onboard as well. --

[GitHub] [cloudstack] blueorangutan commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2023-01-16 Thread GitBox
blueorangutan commented on PR #6386: URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1384842266 Trillian test result (tid-5872) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48783 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

2023-01-16 Thread GitBox
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384828744 Trillian test result (tid-5873) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43162 seconds Marvin logs:

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7094: Handle console session in multiple management servers

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1384822915 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-16 Thread GitBox
GutoVeronezi commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1071704746 ## server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java: ## @@ -151,11 +156,16 @@ public boolean isSessionAllowed(String

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-16 Thread GitBox
nvazquez commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1071697570 ## server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java: ## @@ -151,11 +156,16 @@ public boolean isSessionAllowed(String

<    1   2   3   4   5   6   7   8   9   10   >