[GitHub] [cloudstack] weizhouapache commented on issue #7021: Fix Github Actions Simulator CI Failures

2023-01-13 Thread GitBox
weizhouapache commented on issue #7021: URL: https://github.com/apache/cloudstack/issues/7021#issuecomment-1382144717 All are good now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1382114777 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7095: fix guestOsMapper and move mapping code to latest upgrade

2023-01-13 Thread GitBox
DaanHoogland opened a new pull request, #7095: URL: https://github.com/apache/cloudstack/pull/7095 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-13 Thread GitBox
nvazquez commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1069655387 ## engine/schema/src/main/java/com/cloud/vm/AllowedConsoleSessionVo.java: ## @@ -0,0 +1,64 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [cloudstack] blueorangutan commented on pull request #7094: Handle console session in multiple management servers

2023-01-13 Thread GitBox
blueorangutan commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1382077538 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5269 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1382070521 Trillian Build Failed (tid-5841) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads

2023-01-13 Thread GitBox
slavkap commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1382059190 > > @wido, if you are talking about the IO policy, it could be set there, yes. But if the VM has a mixed type of volumes, probably it's a better option for each of them the IO policy

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7094: Handle console session in multiple management servers

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1382044169 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1382042430 Trillian Build Failed (tid-5840) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] DaanHoogland commented on pull request #7084: kvm: make UEFI host check to support both Ubuntu and EL

2023-01-13 Thread GitBox
DaanHoogland commented on PR #7084: URL: https://github.com/apache/cloudstack/pull/7084#issuecomment-1382036165 > @DaanHoogland only if you insist, I prefer to set cmd to the default case (and not null; just the style to having less branching read better to me). I think it may not need

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7084: kvm: make UEFI host check to support both Ubuntu and EL

2023-01-13 Thread GitBox
weizhouapache commented on code in PR #7084: URL: https://github.com/apache/cloudstack/pull/7084#discussion_r1069599267 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReadyCommandWrapper.java: ## @@ -42,18 +42,21 @@ public final class

[GitHub] [cloudstack] blueorangutan commented on pull request #7094: Handle console session in multiple management servers

2023-01-13 Thread GitBox
blueorangutan commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1382019233 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on pull request #7094: Handle console session in multiple management servers

2023-01-13 Thread GitBox
DaanHoogland commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1382018599 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-13 Thread GitBox
DaanHoogland commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1069570415 ## engine/schema/src/main/java/com/cloud/vm/AllowedConsoleSessionVo.java: ## @@ -0,0 +1,64 @@ +// +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7094: Handle console session in multiple management servers

2023-01-13 Thread GitBox
weizhouapache commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1069585271 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,10 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2023-01-13 Thread GitBox
rohityadavcloud commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1382010312 Slightly concerned on changes outside of the commit/hook that I couldn't fully test/review, but LGTM. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] soreana commented on issue #7074: VMs without uuid are not listing in the list virtual machines api call when ids parameter used.

2023-01-13 Thread GitBox
soreana commented on issue #7074: URL: https://github.com/apache/cloudstack/issues/7074#issuecomment-1382008631 @weizhouapache That is cool, I didn't know that, thanks  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] weizhouapache commented on issue #7074: VMs without uuid are not listing in the list virtual machines api call when ids parameter used.

2023-01-13 Thread GitBox
weizhouapache commented on issue #7074: URL: https://github.com/apache/cloudstack/issues/7074#issuecomment-1382002406 @soreana good you have solved the issue. actually it can be done by a simple sql `UPDATE vm_instance SET uuid=UUID() WHERE uuid=CAST(id AS CHAR);`

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7084: kvm: make UEFI host check to support both Ubuntu and EL

2023-01-13 Thread GitBox
rohityadavcloud commented on PR #7084: URL: https://github.com/apache/cloudstack/pull/7084#issuecomment-1382001450 @DaanHoogland only if you insist, I prefer to set cmd to the default case (and not null; just the style to having less branching read better to me). I think it may not need

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7084: kvm: make UEFI host check to support both Ubuntu and EL

2023-01-13 Thread GitBox
rohityadavcloud commented on code in PR #7084: URL: https://github.com/apache/cloudstack/pull/7084#discussion_r1069573955 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReadyCommandWrapper.java: ## @@ -42,18 +42,21 @@ public final

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1381999157 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] soreana commented on issue #7074: VMs without uuid are not listing in the list virtual machines api call when ids parameter used.

2023-01-13 Thread GitBox
soreana commented on issue #7074: URL: https://github.com/apache/cloudstack/issues/7074#issuecomment-1381994424 @weizhouapache We followed the following procedure, which solved our issue. 0. Create a database backup 1. Get the VMs data in a (id, uuid, account_id,

[GitHub] [cloudstack] soreana closed issue #7074: VMs without uuid are not listing in the list virtual machines api call when ids parameter used.

2023-01-13 Thread GitBox
soreana closed issue #7074: VMs without uuid are not listing in the list virtual machines api call when ids parameter used. URL: https://github.com/apache/cloudstack/issues/7074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] GutoVeronezi opened a new pull request, #7094: Handle console session in multiple management servers

2023-01-13 Thread GitBox
GutoVeronezi opened a new pull request, #7094: URL: https://github.com/apache/cloudstack/pull/7094 ### Description PR #6577 introduced a new mechanism of validation of console sessions, which makes the access tokens one time usable in order to avoid reply attacks and prevent access

[GitHub] [cloudstack] codecov[bot] commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
codecov[bot] commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381934832 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7090?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6924: [Draft] User two factor authentication

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1381903925 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] weizhouapache commented on issue #6941: Xcp-ng 8.2.1 - issues reverting to vm snapshot

2023-01-13 Thread GitBox
weizhouapache commented on issue #6941: URL: https://github.com/apache/cloudstack/issues/6941#issuecomment-1381902658 @AlexanderKgr guest os mappings for 'Ubuntu 20.04 LTS" are missing for xenserver and vmware. please update the template guest os type to "Ubuntu 18.04 LTS" and retry.

[GitHub] [cloudstack] weizhouapache commented on pull request #7091: .github: run all gha on ubuntu latest

2023-01-13 Thread GitBox
weizhouapache commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1381878274 > > @DaanHoogland I remember @rohityadavcloud changed from latest to 22.04 in some yaml files. > > I think it is better to use 22.04. For now, ubuntu:latest is same as 22.04,

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381863227 Trillian Build Failed (tid-5837) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication

2023-01-13 Thread GitBox
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1381863193 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5267 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381860389 Trillian Build Failed (tid-5838) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381860293 Trillian Build Failed (tid-5836) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] DaanHoogland commented on pull request #7091: .github: run all gha on ubuntu latest

2023-01-13 Thread GitBox
DaanHoogland commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1381843279 > @DaanHoogland I remember @rohityadavcloud changed from latest to 22.04 in some yaml files. > > I think it is better to use 22.04. For now, ubuntu:latest is same as

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381842568 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] DaanHoogland commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
DaanHoogland commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381841566 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] codecov[bot] commented on pull request #7091: .github: run all gha on ubuntu latest

2023-01-13 Thread GitBox
codecov[bot] commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1381807706 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7091?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6924: [Draft] User two factor authentication

2023-01-13 Thread GitBox
harikrishna-patnala commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1381806473 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication

2023-01-13 Thread GitBox
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1381807084 @harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[GitHub] [cloudstack] codecov[bot] commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false

2023-01-13 Thread GitBox
codecov[bot] commented on PR #7092: URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381810565 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7092?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-13 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1381790710 Trillian test result (tid-5826) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44200 seconds Marvin logs:

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381784187 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication

2023-01-13 Thread GitBox
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1381776371 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID

[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false

2023-01-13 Thread GitBox
blueorangutan commented on PR #7092: URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381768545 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5265 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication

2023-01-13 Thread GitBox
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1381763074 @harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6924: [Draft] User two factor authentication

2023-01-13 Thread GitBox
harikrishna-patnala commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1381762230 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381759741 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381757569 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5262 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-13 Thread GitBox
blueorangutan commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1381757574 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID

[GitHub] [cloudstack] weizhouapache closed pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
weizhouapache closed pull request #7090: KVM: revert libvirtd config and retry if fail to add a host URL: https://github.com/apache/cloudstack/pull/7090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] weizhouapache commented on pull request #7091: run all gha on ubuntu latest

2023-01-13 Thread GitBox
weizhouapache commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1381720835 @DaanHoogland I remember @rohityadavcloud changed from latest to 22.04 in some yaml files. I think it is better to use 22.04. For now, ubuntu:latest is same as 22.04,

[GitHub] [cloudstack] blueorangutan commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false

2023-01-13 Thread GitBox
blueorangutan commented on PR #7092: URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381718313 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false

2023-01-13 Thread GitBox
weizhouapache commented on PR #7092: URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381716743 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-13 Thread GitBox
blueorangutan commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-138166 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] shwstppr commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-13 Thread GitBox
shwstppr commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1381699513 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7091: run all gha on ubuntu latest

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1381698522 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7092: URL: https://github.com/apache/cloudstack/pull/7092#issuecomment-1381696380 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-13 Thread GitBox
DaanHoogland commented on code in PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#discussion_r1069261131 ## server/src/main/java/com/cloud/user/DomainManager.java: ## @@ -51,4 +51,6 @@ public interface DomainManager extends DomainService { public static final

[GitHub] [cloudstack] blueorangutan commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-13 Thread GitBox
blueorangutan commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1381691199 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] shwstppr commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-13 Thread GitBox
shwstppr commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1381690497 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381687181 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
DaanHoogland commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381686326 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland closed pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
DaanHoogland closed pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC URL: https://github.com/apache/cloudstack/pull/6442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1381630901 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] davidjumani opened a new issue, #7093: Record still left in snapshot_store_ref after primary storage has been removed causing 530 when listSanpshots is called

2023-01-13 Thread GitBox
davidjumani opened a new issue, #7093: URL: https://github.com/apache/cloudstack/issues/7093 # ISSUE TYPE * Bug Report # COMPONENT NAME Storage # CLOUDSTACK VERSION 4.17.2 (maybe before as well) # OS / ENVIRONMENT VMware 6.7.3

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7092: api: fix new password is applied on host when update host password with update_passwd_on_host=false

2023-01-13 Thread GitBox
weizhouapache opened a new pull request, #7092: URL: https://github.com/apache/cloudstack/pull/7092 ### Description This PR fixes that issue new password is applied on host when update host password with update_passwd_on_host=false

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7091: run all gha on ubuntu latest

2023-01-13 Thread GitBox
DaanHoogland opened a new pull request, #7091: URL: https://github.com/apache/cloudstack/pull/7091 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing

[GitHub] [cloudstack] blueorangutan commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
blueorangutan commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381596717 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
weizhouapache commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381595453 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] codecov[bot] commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
codecov[bot] commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1381590972 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7089?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] DaanHoogland closed pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
DaanHoogland closed pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC URL: https://github.com/apache/cloudstack/pull/6442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#issuecomment-1381552258 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381543011 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] DaanHoogland closed pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
DaanHoogland closed pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/7089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
blueorangutan commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381533800 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5261 -- This is an

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1381530427 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1381519126 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #7029: URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1381488137 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
blueorangutan commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381486458 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
weizhouapache commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381485426 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
blueorangutan commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381474681 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
weizhouapache commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381473637 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
weizhouapache opened a new pull request, #7090: URL: https://github.com/apache/cloudstack/pull/7090 ### Description This PR fixes #6716 If a KVM host has been added to cloudstack environment before, then we reset agent.properties to original file

[GitHub] [cloudstack] DaanHoogland closed pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
DaanHoogland closed pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/7089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] DaanHoogland closed pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
DaanHoogland closed pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC URL: https://github.com/apache/cloudstack/pull/6442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
DaanHoogland opened a new pull request, #7089: URL: https://github.com/apache/cloudstack/pull/7089 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing

[GitHub] [cloudstack] DaanHoogland closed pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
DaanHoogland closed pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/6991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1381428554 Trillian test result (tid-5820) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 52841 seconds Marvin logs:

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7081: enable to create VPC porfowarding rules with source cidr

2023-01-12 Thread GitBox
weizhouapache commented on code in PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1069033684 ## systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py: ## @@ -339,6 +339,9 @@ def to_str(self, delete=False): printable =

[GitHub] [cloudstack] weizhouapache commented on pull request #7081: enable to create VPC porfowarding rules with source cidr

2023-01-12 Thread GitBox
weizhouapache commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-1381423356 Hi @RodrigoDLopez Have you tested - create with a list of cidrs ? - same operation on isolated networks ? - create port forwarding rule with same public and same

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381399062 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6840: infra: edge zones

2023-01-12 Thread GitBox
DaanHoogland commented on code in PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1068995052 ## plugins/hypervisors/simulator/src/main/java/com/cloud/agent/manager/MockAgentManagerImpl.java: ## @@ -106,7 +111,13 @@ public class MockAgentManagerImpl

[GitHub] [cloudstack] blueorangutan commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
blueorangutan commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1381389165 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] DaanHoogland commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1381388955 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1381372757 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6840: infra: edge zones

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1381364060 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
blueorangutan commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1381357919 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5260 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones

2023-01-12 Thread GitBox
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1381357920 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5259 -- This is an

[GitHub] [cloudstack] DaanHoogland closed pull request #7087: Fix spelling

2023-01-12 Thread GitBox
DaanHoogland closed pull request #7087: Fix spelling URL: https://github.com/apache/cloudstack/pull/7087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [cloudstack] DaanHoogland commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381353438 note: components/test_affinity_groups_project.py failed in gha. might need attention. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1381334266 Trillian test result (tid-5819) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45091 seconds Marvin logs:

<    4   5   6   7   8   9   10   11   12   13   >