[GitHub] [cloudstack] weizhouapache commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
weizhouapache commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381485426 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] blueorangutan commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
blueorangutan commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381474681 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] weizhouapache commented on pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
weizhouapache commented on PR #7090: URL: https://github.com/apache/cloudstack/pull/7090#issuecomment-1381473637 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7090: KVM: revert libvirtd config and retry if fail to add a host

2023-01-13 Thread GitBox
weizhouapache opened a new pull request, #7090: URL: https://github.com/apache/cloudstack/pull/7090 ### Description This PR fixes #6716 If a KVM host has been added to cloudstack environment before, then we reset agent.properties to original file (./agent/conf/agent.propert

[GitHub] [cloudstack] DaanHoogland closed pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
DaanHoogland closed pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/7089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] DaanHoogland closed pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC

2023-01-13 Thread GitBox
DaanHoogland closed pull request #6442: Possibility to choose the initial IP address on a isolated network or VPC URL: https://github.com/apache/cloudstack/pull/6442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
DaanHoogland opened a new pull request, #7089: URL: https://github.com/apache/cloudstack/pull/7089 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing function

[GitHub] [cloudstack] DaanHoogland closed pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-13 Thread GitBox
DaanHoogland closed pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/6991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1381428554 Trillian test result (tid-5820) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 52841 seconds Marvin logs: https://github.com/blu

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7081: enable to create VPC porfowarding rules with source cidr

2023-01-12 Thread GitBox
weizhouapache commented on code in PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#discussion_r1069033684 ## systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py: ## @@ -339,6 +339,9 @@ def to_str(self, delete=False): printable = printable.replace('!_-'

[GitHub] [cloudstack] weizhouapache commented on pull request #7081: enable to create VPC porfowarding rules with source cidr

2023-01-12 Thread GitBox
weizhouapache commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-1381423356 Hi @RodrigoDLopez Have you tested - create with a list of cidrs ? - same operation on isolated networks ? - create port forwarding rule with same public and same p

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381399062 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6840: infra: edge zones

2023-01-12 Thread GitBox
DaanHoogland commented on code in PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1068995052 ## plugins/hypervisors/simulator/src/main/java/com/cloud/agent/manager/MockAgentManagerImpl.java: ## @@ -106,7 +111,13 @@ public class MockAgentManagerImpl exte

[GitHub] [cloudstack] blueorangutan commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
blueorangutan commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1381389165 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] DaanHoogland commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1381388955 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1381372757 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6840: infra: edge zones

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1381364060 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
blueorangutan commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1381357919 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5260 -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones

2023-01-12 Thread GitBox
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1381357920 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5259 -- This is an automated

[GitHub] [cloudstack] DaanHoogland closed pull request #7087: Fix spelling

2023-01-12 Thread GitBox
DaanHoogland closed pull request #7087: Fix spelling URL: https://github.com/apache/cloudstack/pull/7087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] DaanHoogland commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381353438 note: components/test_affinity_groups_project.py failed in gha. might need attention. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1381334266 Trillian test result (tid-5819) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45091 seconds Marvin logs: https://github.com/blu

[GitHub] [cloudstack] DaanHoogland commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381334230 this needs a regression test and some monkey testing on createVPC in the UI, in spite of just being spelling corrections. @blueorangutan test keepEnv -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
blueorangutan commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381334522 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-12 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1381331193 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] DaanHoogland commented on pull request #7046: Add support for vSphere 8.0

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1381330381 just to be sure @blueorangutan test centos7 vmware-60u2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] shwstppr commented on pull request #6840: infra: edge zones

2023-01-12 Thread GitBox
shwstppr commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1381328637 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] blueorangutan commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
blueorangutan commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1381328940 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones

2023-01-12 Thread GitBox
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1381328924 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] DaanHoogland commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1381328556 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #7029: URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1381328475 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1381328460 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] DaanHoogland merged pull request #7080: updates roles read-only

2023-01-12 Thread GitBox
DaanHoogland merged PR #7080: URL: https://github.com/apache/cloudstack/pull/7080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7080: updates roles read-only

2023-01-12 Thread GitBox
DaanHoogland commented on code in PR #7080: URL: https://github.com/apache/cloudstack/pull/7080#discussion_r1068935302 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -998,6 +998,38 @@ BEGIN CALL `cloud`.`IDEMPOTENT_ADD_KEY`('i_user_ip_address_s

[GitHub] [cloudstack] DaanHoogland commented on issue #5803: User from domain can't deploy VM in pod dedicated to that domain

2023-01-12 Thread GitBox
DaanHoogland commented on issue #5803: URL: https://github.com/apache/cloudstack/issues/5803#issuecomment-1381324439 @edikevich @Hudratronium with one weeks before code freeze I have no clear idea on what to do on this yet. I will move this to "unplanned". Please let's define the required f

[GitHub] [cloudstack] blueorangutan commented on pull request #7080: updates roles read-only

2023-01-12 Thread GitBox
blueorangutan commented on PR #7080: URL: https://github.com/apache/cloudstack/pull/7080#issuecomment-1381322065 Trillian test result (tid-5817) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47840 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
blueorangutan commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381319877 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5258 -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1381318527 Trillian test result (tid-5821) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43378 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] DaanHoogland merged pull request #7086: server: allow expunging VMs in Expunging state

2023-01-12 Thread GitBox
DaanHoogland merged PR #7086: URL: https://github.com/apache/cloudstack/pull/7086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland commented on pull request #7084: kvm: make UEFI host check to support both Ubuntu and EL

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7084: URL: https://github.com/apache/cloudstack/pull/7084#issuecomment-1381306852 @rohityadavcloud, will this require extra testing? Will you apply my suggestion? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] DaanHoogland commented on issue #6992: Volumes fail to detach on VMware VM imported in CloudStack which has space in its name

2023-01-12 Thread GitBox
DaanHoogland commented on issue #6992: URL: https://github.com/apache/cloudstack/issues/6992#issuecomment-1381305255 fixed by #6989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] DaanHoogland closed issue #6992: Volumes fail to detach on VMware VM imported in CloudStack which has space in its name

2023-01-12 Thread GitBox
DaanHoogland closed issue #6992: Volumes fail to detach on VMware VM imported in CloudStack which has space in its name URL: https://github.com/apache/cloudstack/issues/6992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] blueorangutan commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
blueorangutan commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381297198 @davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] davidjumani commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
davidjumani commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381296898 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] davidjumani commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
davidjumani commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381296572 @blueoranguran package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] davidjumani commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
davidjumani commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1381292947 @blueoranguran package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7086: server: allow expunging VMs in Expunging state

2023-01-12 Thread GitBox
blueorangutan commented on PR #7086: URL: https://github.com/apache/cloudstack/pull/7086#issuecomment-1381292743 Trillian test result (tid-5816) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45611 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-12 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1381244872 Trillian test result (tid-5811) Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 57433 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #7082: allow filtering of listDiskOffering and listServiceOffering APIs by account or project

2023-01-12 Thread GitBox
blueorangutan commented on PR #7082: URL: https://github.com/apache/cloudstack/pull/7082#issuecomment-1381218126 Trillian test result (tid-5815) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43845 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6989: vmware: encode disk path for URL based access

2023-01-12 Thread GitBox
blueorangutan commented on PR #6989: URL: https://github.com/apache/cloudstack/pull/6989#issuecomment-1381191153 Trillian test result (tid-5813) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 42808 seconds Marvin logs: https://github.com/blu

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1381117529 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1381117073 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1381114396 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1381112690 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5253 -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-12 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1381105394 Trillian test result (tid-5809) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47957 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
stephankruggg commented on code in PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#discussion_r1068768238 ## server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java: ## @@ -872,6 +867,16 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws ResourceA

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
stephankruggg commented on code in PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#discussion_r1068768238 ## server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java: ## @@ -872,6 +867,16 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws ResourceA

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
stephankruggg commented on code in PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#discussion_r1068768238 ## server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java: ## @@ -872,6 +867,16 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws ResourceA

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #7073: storage: validate disk size range of custom disk offering when resize volume

2023-01-12 Thread GitBox
stephankruggg commented on code in PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#discussion_r1068768238 ## server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java: ## @@ -872,6 +867,16 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws ResourceA

[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0

2023-01-12 Thread GitBox
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1381085985 Trillian test result (tid-5810) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43932 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1381083169 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1381082633 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] blueorangutan commented on pull request #7084: kvm: make UEFI host check to support both Ubuntu and EL

2023-01-12 Thread GitBox
blueorangutan commented on PR #7084: URL: https://github.com/apache/cloudstack/pull/7084#issuecomment-1380973573 Trillian test result (tid-5807) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45264 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380969060 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380963615 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5252 -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #7084: kvm: make UEFI host check to support both Ubuntu and EL

2023-01-12 Thread GitBox
blueorangutan commented on PR #7084: URL: https://github.com/apache/cloudstack/pull/7084#issuecomment-1380950223 Trillian test result (tid-5808) Environment: kvm-ubuntu20 (x2), Advanced Networking with Mgmt server u20 Total time taken: 42215 seconds Marvin logs: https://github.com/b

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380916873 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380915978 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380915587 Thanks @GutoVeronezi I've addressed your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
nvazquez commented on code in PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#discussion_r1068559924 ## services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java: ## @@ -235,8 +262,61 @@ public byte[] encodePassword(byte[] challenge, S

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380907776 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5251 -- This is an automated

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1380905626 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1380904021 Trillian Build Failed (tid-5825) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380902969 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] codecov[bot] commented on pull request #7087: Fix spelling

2023-01-12 Thread GitBox
codecov[bot] commented on PR #7087: URL: https://github.com/apache/cloudstack/pull/7087#issuecomment-1380896273 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So

[GitHub] [cloudstack] weizhouapache commented on issue #6743: CPU speed in compute offering is not a MHz speed when using KVM and libvirt.

2023-01-12 Thread GitBox
weizhouapache commented on issue #6743: URL: https://github.com/apache/cloudstack/issues/6743#issuecomment-1380895803 this looks like a polishing a better name might be "CPU weight factor" maybe we can fix it together with #6744 -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical

2023-01-12 Thread GitBox
blueorangutan commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1380866390 Trillian test result (tid-5806) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41933 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380852704 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380852373 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7088: errorprone

2023-01-12 Thread GitBox
DaanHoogland opened a new pull request, #7088: URL: https://github.com/apache/cloudstack/pull/7088 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing function

[GitHub] [cloudstack] jbampton opened a new pull request, #7087: Fix spelling

2023-01-12 Thread GitBox
jbampton opened a new pull request, #7087: URL: https://github.com/apache/cloudstack/pull/7087 ### Description This PR fixes some spelling. ### Types of changes - [ ] Breaking change (fix or feature that would cause

[GitHub] [cloudstack] weizhouapache commented on issue #6179: Cloudstack XCP-NG and OVS GRE plugin

2023-01-12 Thread GitBox
weizhouapache commented on issue #6179: URL: https://github.com/apache/cloudstack/issues/6179#issuecomment-1380792750 @furyflash777 this seems to be same as #6727 the vxlan VNI range is not passed when you created the zone. this is fixed by #7038 -- This is an automated mes

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1380789142 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7065: Tungsten integration

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7065: URL: https://github.com/apache/cloudstack/pull/7065#issuecomment-1380777195 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7065: Tungsten integration

2023-01-12 Thread GitBox
blueorangutan commented on PR #7065: URL: https://github.com/apache/cloudstack/pull/7065#issuecomment-1380731973 Trillian Build Failed (tid-5818) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1380719483 Trillian Build Failed (tid-5824) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1380719839 Trillian Build Failed (tid-5823) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1380716945 Trillian Build Failed (tid-5822) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1380711416 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland merged pull request #7076: UI: do not show FW/LB/PF tabs for CKS cluster in advanced network with SG

2023-01-12 Thread GitBox
DaanHoogland merged PR #7076: URL: https://github.com/apache/cloudstack/pull/7076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland closed pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
DaanHoogland closed pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce URL: https://github.com/apache/cloudstack/pull/7003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1380694966 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] blueorangutan commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
blueorangutan commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1380694731 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] DaanHoogland commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
DaanHoogland commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1380693804 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1380693445 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1380692080 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] DaanHoogland commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
DaanHoogland commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1380692286 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-01-12 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1380682859 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5250 -- This is an automated

[GitHub] [cloudstack] DaanHoogland closed pull request #7065: Tungsten integration

2023-01-12 Thread GitBox
DaanHoogland closed pull request #7065: Tungsten integration URL: https://github.com/apache/cloudstack/pull/7065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [cloudstack] weizhouapache commented on pull request #6978: simulator: use ubuntu 22.04 in Dockerfile

2023-01-12 Thread GitBox
weizhouapache commented on PR #6978: URL: https://github.com/apache/cloudstack/pull/6978#issuecomment-1380641701 @rohityadavcloud yes, I have finished the POC, it worked please check https://github.com/weizhouapache/cloudstack-new/actions/workflows/docker-cloudstack-simulator.yml

<    5   6   7   8   9   10   11   12   13   14   >