[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534850580 LGTM, tests LGTM as well. Using lgtms from the original PR, merging this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534421461 CentOS7 job failed, rekicking @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-532968167 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-532961706 (el6 failure expected) @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-531423413 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-531416384 Thanks @fmaximus I'll kick a build @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-530018217 @fmaximus thanks for self assigning, can you help fix the conflict? I'll try and help you to get this merge now that master is not frozen anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-519037899 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-517594071 @fmaximus please see https://github.com/apache/cloudstack/pull/3537, we'll need to revert your PR #3152 for this purpose I've reopened your PR from the original branch. Kindly help test and fix regressions discovered in your branch, esp around registration and upload of archived templates and iso (templates/isos that are extractable liike *.bz2, *gz etc). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
