[GitHub] DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing

2018-03-20 Thread GitBox
DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for 
response object breaking response parsing
URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-374505072
 
 
   Good experiment @marcaurele , I have no stress test env at my disposal so i 
can not verify. I am worried that my question is blocking your fix. Let's try 
to separate the fix and the improvement.
   Is the transaction failing as a solution to the bug if the isolation level 
isn't changed as well?
   * If it is, let's merge as is.
   * If it isn't (but performing badly) let's merge it as transaction.
   In both cases we can create a ticket to track it further, ok?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing

2018-03-18 Thread GitBox
DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for 
response object breaking response parsing
URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-374039766
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for 
response object breaking response parsing
URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-372735409
 
 
   nice find, dirty hack, though maybe justified. Isn't the proper solution to 
put both queries in a transaction, @marcaurele ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services