[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring
webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-492978827 Hey Daan, thanks for your feedback. This is not compareable to jquery update, because it's not an upgrade of any Framework Version. New compiled CSS remains CSS. It's an refactoring of old technology. I didn't changed the code at all here but I generated a way to better work with it. The CSS script is full of redundant and outdated rules. We need to fix that anytime in future and we should begin right now. There will be no warranty, that no issues and mistakes were done by me here, but it wont be that complicated to fix small issues and I am pretty experienced by what I'm doing. Max This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring
webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-492978827 Hey Daan, thanks for feedback. This is not compareable to jquery update, because it's not an upgrade of any Framework Version. New compiled CSS remains CSS. It's an refactoring of old technology. I didn't changed the code at all here but I generated a way to better work with it. The CSS script is full of redundant and outdated rules. We need to fix that anytime in future and we should begin right now. Their will be no garantee that no issues and mistakes where done by me here, but it wont be that complicated to fix small issues and I am very experienced by what I'm doing. Max This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring
webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-49057 Hey, this PR may seem confusing in first moment. The most interesting file of those 86 is "_cloudstack3.css_" **All other files** are just the source to compile this final 13000 lines css-file now and may be ignored in this PR. Later we can use those new smaller scss-files to adjust styles more safety and faster. Max This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring
webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-49057 Hey, this PR may seem confusing in first moment. The most interesting file of those 86 is "_cloudstack3.css_" **All other files** are just the source to compile this final 13000 lines css-file now and may be ignored in this PR. Later we can use those new smaller scss-files to adjust styles more safty and faster. Max This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
