[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-23 Thread via GitHub
DaanHoogland commented on code in PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#discussion_r1083764684 ## server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java: ## @@ -715,11 +716,22 @@ public Pair, Integer> listVpcOfferings(ListVPCOfferi

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-23 Thread via GitHub
DaanHoogland commented on code in PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#discussion_r1083764684 ## server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java: ## @@ -715,11 +716,22 @@ public Pair, Integer> listVpcOfferings(ListVPCOfferi

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6748: server: fix listnetworkofferings with domain, refactor listvpofferings

2023-01-13 Thread GitBox
DaanHoogland commented on code in PR #6748: URL: https://github.com/apache/cloudstack/pull/6748#discussion_r1069261131 ## server/src/main/java/com/cloud/user/DomainManager.java: ## @@ -51,4 +51,6 @@ public interface DomainManager extends DomainService { public static final