[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7153: Introducing concept of domain VPCs

2023-05-08 Thread via GitHub
DaanHoogland commented on code in PR #7153: URL: https://github.com/apache/cloudstack/pull/7153#discussion_r1187176420 ## server/src/main/java/com/cloud/network/IpAddressManagerImpl.java: ## @@ -1476,7 +1476,8 @@ public IPAddressVO associateIPToGuestNetwork(long ipId, long

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7153: Introducing concept of domain VPCs

2023-04-28 Thread via GitHub
DaanHoogland commented on code in PR #7153: URL: https://github.com/apache/cloudstack/pull/7153#discussion_r1180042689 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -2534,7 +2534,12 @@ public NetworkResponse createNetworkResponse(ResponseView view,

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7153: Introducing concept of domain VPCs

2023-02-23 Thread via GitHub
DaanHoogland commented on code in PR #7153: URL: https://github.com/apache/cloudstack/pull/7153#discussion_r1115387048 ## server/src/main/java/com/cloud/network/IpAddressManagerImpl.java: ## @@ -1476,7 +1476,8 @@ public IPAddressVO associateIPToGuestNetwork(long ipId, long

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7153: Introducing concept of domain VPCs

2023-02-01 Thread via GitHub
DaanHoogland commented on code in PR #7153: URL: https://github.com/apache/cloudstack/pull/7153#discussion_r1093127563 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -2490,7 +2490,11 @@ public NetworkResponse createNetworkResponse(ResponseView view,