GabrielBrascher opened a new pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190


   ## Description
   <!--- Describe your changes in detail -->
   
   This PR sets properly Broadcast URI to `vxlan://vxlan_id` when the physical 
network is of VXLAN.
   
   Fixes: #3040
   
   Description of issue #3040:
   > Advanced Network zone with VXLAN is created. When creating a guest network 
and setting the VNI this is set for the network:
   >     broadcast_uri: vlan://1000
   >     isolation_uri: vlan://1000
   > 
   > STEPS TO REPRODUCE
   > 
   >     Create a Advanced Zone with VXLAN
   >     Create a guest network
   >     See that broadcast is set to vlan and not vxlan
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   **Prior to the fix:**
   
![image](https://user-images.githubusercontent.com/5025148/86156620-9f83ae00-badc-11ea-972a-6e54cc3141c0.png)
   
   **After the fix:**
   
![image](https://user-images.githubusercontent.com/5025148/86156657-ad393380-badc-11ea-86dc-146fa15eece1.png)
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   
   1. Create a Advanced Zone with VXLAN
   2. Create a guest network
   3. See that broadcast uri is set to vxlan
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to