Pearl1594 commented on a change in pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#discussion_r448112372



##########
File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/acl/UpdateRoleCmd.java
##########
@@ -67,13 +63,6 @@ public String getRoleName() {
         return roleName;
     }
 
-    public RoleType getRoleType() {
-        if (!Strings.isNullOrEmpty(roleType)) {
-            return RoleType.fromString(roleType);
-        }
-        return null;
-    }
-
     public String getRoleDescription() {

Review comment:
       Since roleType and roleDescription have been moved to RoleCmd class, can 
we not remove getRoleDescription() from this class?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to