anuragaw commented on a change in pull request #3335: kvm: disable cpu features
if feature starts with '-'
URL: https://github.com/apache/cloudstack/pull/3335#discussion_r285849457
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
##########
@@ -1360,7 +1360,11 @@ public String toString() {
if (_features != null) {
for (String feature : _features) {
- modeBuilder.append("<feature policy='require' name='" +
feature + "'/>");
+ if (feature.startsWith("-")) {
Review comment:
minor suggestion - trim to remove accidental spaces if we are checking
prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
