[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-12 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-510785128 Ah that makes sense. So can we fix that as separate PR and move ahead on this merge @rhtyd since these also break on master?

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-12 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-510782799 @rhtyd - is it possible that the router lifecycle tests are also broken on master as per this comment from blueorangutan -

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-12 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-510777928 The tests having errors also have errors on master - https://github.com/apache/cloudstack/pull/3476#issuecomment-510770328

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-08 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-509097979 @blueorangutan test This is an automated message from the Apache

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-07 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-509088588 I've tried replicating to run tests locally but they succeed. Looks like runtime issue. @rhtyd , @shwstppr - can one of you

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-03 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-507963567 Will check later today @rhtyd This is an automated message from

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506605778 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506605483 You assessment was correct @rhtyd . I have verified the changes on untagged and VLANs with specific IDs and it seems accurate. For

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506308486 Copy @rhtyd This is an automated message from the Apache Git

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506218732 ping for review - @rhtyd , @shwstppr , @andrijapanic , @PaulAngus

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506218577 @blueorangutan package This is an automated message from the