[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12
rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264533511 ## File path: packaging/systemd/cloudstack-usage.default ## @@ -15,8 +15,18 @@ # specific language governing permissions and limitations # under the License. -JAVA_OPTS="-Dpid=$$ -Xms256m -Xmx2048m" Review comment: Btw, this without quotes would work This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12
rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264533385 ## File path: packaging/systemd/cloudstack-usage.service ## @@ -24,7 +24,9 @@ After=network.target network-online.target [Service] Type=simple EnvironmentFile=/etc/default/cloudstack-usage -ExecStart=/usr/bin/java $JAVA_OPTS -cp $CLASSPATH $JAVA_CLASS Review comment: Comment: this would need to be fixed for 4.11 as well, let me send a quick fix instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12
rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264533298 ## File path: packaging/systemd/cloudstack-usage.service ## @@ -24,7 +24,9 @@ After=network.target network-online.target [Service] Type=simple EnvironmentFile=/etc/default/cloudstack-usage -ExecStart=/usr/bin/java $JAVA_OPTS -cp $CLASSPATH $JAVA_CLASS Review comment: Put this and this would fix the pid issue: ``` Environment=JAVA_PID=$$ ExecStart=/usr/bin/java $JAVA_DEBUG -Dpid=$JAVA_PID $JAVA_OPTS -cp $CLASSPATH $JAVA_CLASS ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12
rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264533039 ## File path: packaging/systemd/cloudstack-usage.default ## @@ -15,8 +15,18 @@ # specific language governing permissions and limitations # under the License. -JAVA_OPTS="-Dpid=$$ -Xms256m -Xmx2048m" Review comment: Nevermind, re-read the description. Alright keep this change, I'll advise you a simpler fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12
rhtyd commented on a change in pull request #3207: Fix #3203 usage server broken in 4.11/4.12 URL: https://github.com/apache/cloudstack/pull/3207#discussion_r264532941 ## File path: packaging/systemd/cloudstack-usage.default ## @@ -15,8 +15,18 @@ # specific language governing permissions and limitations # under the License. -JAVA_OPTS="-Dpid=$$ -Xms256m -Xmx2048m" Review comment: @GabrielBrascher What's the issue, this should work? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
