[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-07-08 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-509095413 @borisstoyanov @anuragaw @shwstppr can you review based on regression test results?

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-07-05 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-508818907 Closed reopened PR to rekick Travis. @richardlawley can you provide details or summary of tests you performed

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-07-04 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-508463034 @blueorangutan test This is an automated message

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-07-04 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-508408640 Thanks @richardlawley I'll kick some tests. @blueorangutan package

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-07-03 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-507960853 On hold until @richardlawley confirm changes and testing.

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-06-26 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-505870159 Okay @richardlawley let me know when you're done with your changes. I'll help kick regression tests.

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-06-25 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-505409457 @richardlawley can you rebase against latest master? To the wider community - do we know any srx users/devs who

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-06-25 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-505408896 Our smoketests don't run the srx at all, so no smoketests against vmware/kvm/xenserver are needed. We can merge based