[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-15 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-511366970 Ping @borisstoyanov @PaulAngus @shwstppr This is an automated

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-15 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-511366459 Ping This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-12 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-510855684 cc @shwstppr can you help with a review? This is an automated message

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-12 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-510855572 @borisstoyanov @PaulAngus can you test and review? This is an

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-12 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-510784361 You're testing against KVM and not vmware, it could be a vmware related issue @anuragaw

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-12 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-510779578 Looks like router lifecycle tests fail. We'll have to fix the bug and revisit this to ensure we don't end up adding a regression.

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-08 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-509099361 @blueorangutan test centos7 vmware-65u2 This is an automated

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-03 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-507962871 Looks like the changes break router/network related smoke tests. Can you check @anuragaw

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506610744 @blueorangutan test centos7 vmware-65u2 This is an automated message

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-06-27 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506226397 cc @PaulAngus - do you think for public network overlapping vlan-trunking/range be allowed to be added by the admin?