[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-12-07 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-562891094 @pbankonier @svenvogel - with primate in, kindly close this. Let's move all major UI development work in Primate. Thanks.

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-11-11 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-552519058 @pbankonier @svenvogel - do you think we can close this now that we have Primate?

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-07-03 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-508095165 Thanks for explaining @pbankonier I would have asked for a complete design document for all sorts of UI changes that are coming because

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-07-03 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-507970381 @webermaximilian92 I see some large css files removed, I don't understand if we're removing them how does that affect our build/usage?

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-07-01 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-507269720 Thanks @svenvogel but I still see several large changes and file renames and I'm not sure I understand what is intended to be here. I

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-06-28 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506650335 @svenvogel I'll readded this PR to 4.13.0.0 milestone on your remark. Keep us posted, thanks.

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506447817 In the present form renaming ui folder just because it feels like may not be encouraged because it will cause conflicts for so many

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

2019-06-27 Thread GitBox
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506398641 Can you explain why move the ui directory to client? This is an