shwstppr commented on code in PR #7455:
URL: https://github.com/apache/cloudstack/pull/7455#discussion_r1190708512


##########
plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ConfigTungstenFabricServiceCmd.java:
##########
@@ -132,6 +135,21 @@ public void doInTransactionWithoutResult(final 
TransactionStatus status) {
 
     private void persistDefaultSystemNetwork() {
         Transaction.execute(new TransactionCallbackNoReturn() {
+
+            private void persistNetworkServiceMapAvoidingDuplicates(Network 
network,
+                                                                    
Network.Service service,
+                                                                    
Network.Provider provider,
+                                                                    
NetworkServiceMapVO mapVO) {

Review Comment:
   @nvazquez isn't mapVO here already providing the service and provider? Do we 
need service and provider as an argument?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to