[GitHub] [cloudstack] slavkap commented on a diff in pull request #6909: KVM support of iothreads and IO driver policy

[GitBox]

slavkap commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1073975173


##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -3055,24 +3073,34 @@ protected String getIoUringCheckCommand() {
  * (i) Qemu >= 5.0;
  * (ii) Libvirt >= 6.3.0
  */
-protected void setDiskIoDriver(DiskDef disk) {
-if (enableIoUring) {
-disk.setIoDriver(DiskDef.IoDriver.IOURING);
+public void setDiskIoDriver(DiskDef disk, IoDriverPolicy ioDriver) {
+s_logger.debug(String.format("Disk IO driver policy [%s]. The host 
supports the io_uring policy [%s]", ioDriver, enableIoUring));
+if (ioDriver != null) {
+if (IoDriverPolicy.IOURING != ioDriver) {

Review Comment:
   discussed it offline



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] slavkap commented on a diff in pull request #6909: KVM support of iothreads and IO driver policy

[GitBox]

slavkap commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1072088093


##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -3185,12 +3199,32 @@ protected String getIoUringCheckCommand() {
  * (i) Qemu >= 5.0;
  * (ii) Libvirt >= 6.3.0
  */
-protected void setDiskIoDriver(DiskDef disk) {
-if (enableIoUring) {
+public void setDiskIoDriver(DiskDef disk, boolean iothreadsEnabled, 
IoDriver ioDriver) {
+if (iothreadsEnabled) {
+disk.setIothreads(iothreadsEnabled);
+if (!enableIoUring && IoDriver.IOURING == ioDriver) {

Review Comment:
   @wido, I think it's good to leave the check if the OS supports the 
`io_uring` option. I've just removed it from the `agent.properties` file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org