[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-06-05 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1576936549 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-06-05 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1576795962 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-06-05 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1576427803 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-12 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1545901698 @shwstppr I have updated this PR by reverting some changes and adding a small change now it looks like

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1544309899 > > @weizhouapache can you please look into it and make the necessary changes? I'm happy to both close this or if you want make changes in this PR @shwstppr sure,

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543936209 > @weizhouapache Currently, we don't link IPs when they are used by a system VM or VR. Without having changes that update IpAddress record for system vm, VRs it would mean

[GitHub] [cloudstack] weizhouapache commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

2023-05-11 Thread via GitHub
weizhouapache commented on PR #7403: URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1543897200 @shwstppr I had a quick look at the code changes just now. can we fix it without changes in user_ip_address ? from what I understand, we just need to add the vm name