[GitHub] DaanHoogland commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
DaanHoogland commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-353060783 > What I am against is something that we see sometimes, where people use one commit per file/change. Then, a single issue that is being tackled in a PR becomes 100+ commits? Guilty as charged. I like working that way. but we can certainly try and change me (:-1:) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
DaanHoogland commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-353053323 @rafaelweingartner in general I am against squashing and rebasing but rather tired of the argument. I think we should definitely keep any individual commits where they address separate issues (i.e. CLOUDSTACK- prefixed) So I don't agree for this PR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services