[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-11-22 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-441163098 ok @GabrielBrascher , so *maybe* this one is good to go. I still don't like it :wink: This is an

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-11-21 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-440813429 @GabrielBrascher, no it gets deleted automatically. I will have to see about creating an env with this code and debug the test.

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-11-21 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-440599172 still don't see how the remaining two are related. This is an automated message from the Apache

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-11-20 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-440179505 these errors are ip related and might be consequential to this PR, but then wouldn't be expected to be the only errors and failures. restarting to see if these

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-11-19 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-439920856 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-11-19 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-439880578 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-09-21 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-423470837 I think it can be merged, @rohit, though further work on macaddresses will be needed it is out of scope here.

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-08-20 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-414253501 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-08-20 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-414239995 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-07-26 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-408058575 surely 'squash and merge' @wido This is an automated message from the Apache Git Service. To

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-06-14 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-391391316 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-23 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-391405450 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-23 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-391311922 @rhtyd as marked in the initial comment this is only cleanup so far. It applies to all older versions. as work continues we might want to add code to unify and

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-23 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-391391316 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-23 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-391329378 ah, got it This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-23 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-391329146 show me the money This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-23 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-391329089 wtf did i do wrong now? This is an automated message from the Apache Git Service. To respond to

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-23 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-391311922 @rhtyd as marked in the initial comment this is only cleanup so far. It applies to all older versions. as work continues we might want to add code to unify and

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-22 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390947600 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-22 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390932472 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-22 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390932472 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-05-22 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390910499 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the