[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2018-09-21 Thread GitBox
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-423618461 @rhtyd all checks have passed.

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2018-09-20 Thread GitBox
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-423305729 @rhtyd rebased against latest master. Sorry for taking too long.

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2017-12-18 Thread GitBox
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-352618587 @rhtyd I am checking them, thanks.

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2017-12-11 Thread GitBox
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-350781228 @rhtyd I will check on that.

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2017-11-10 Thread GitBox
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-343506872 I will check these failures.

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2017-09-27 Thread git
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-332481936 Refactored using ConfigKey, as you suggested @rhtyd. Thanks for all the feedback!

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2017-09-19 Thread git
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-330608678 Sorry for the delay @rhtyd. I will work on that when possible.

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2017-07-19 Thread git
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-316574072 Thanks for the feedback @rafaelweingartner. I updated the SQL from file schema-4930to41000.sql

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

2017-07-19 Thread git
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-316574072 Thanks for the feedback @rafaelweingartner. I updated the SQL from file schema-4930to41000.sql