[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355647317 @rhtyd I don't think the failed tests are related to the change. The change was in attaching ISO. Can you re-run the test? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355141248 @rafaelweingartner I don't know if we can have a clusters/hosts with different XS versions, but in any case I changed it again as follow - register only *one* iso with `name` of **xs-tools.iso** and `display_text` of **XenServer Tools Installer ISO (xen-pv-drv-iso)** - get the actual iso name (either _xs-tools.iso_ or _guest-tools.is_) on the fly based on `product_version` of `com.xensource.xenapi.Host.Record` in the future, if the name of iso changes again, only another `else` block will be needed in `CitrixResourceBase#actualIsoTemplate` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355141248 @rafaelweingartner I don't know if we can have a clusters/hosts with different XS versions, but in any case I changed it again as follow - register only *one* iso with `name` of **xs-tools.iso** and `display_text` of **XenServer Tools Installer ISO (xen-pv-drv-iso)** - get the actual iso name (either _xs-tools.iso_ or _guest-tools.is_) on the fly based on version of `com.xensource.xenapi.Host.Record` in the future, if the name of iso changes again, only another `else` block will be needed in `CitrixResourceBase#actualIsoTemplate` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355141248 @rafaelweingartner I don't know if we can have a clusters/hosts with different XS versions, but in any case I changed it again as follow - register only *one* iso with `name` of **xs-tools.iso** and `display_text` of **XenServer Installer ISO (xen-pv-drv-iso)** - get the actual iso name (either _xs-tools.iso_ or _guest-tools.is_) on the fly based on version of `com.xensource.xenapi.Host.Record` in the future, if the name of iso changes again, only another `else` block will be needed in `CitrixResourceBase#actualIsoTemplate` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355073616 @rhtyd @rafaelweingartner the new change: - registers both iso names at `ComponentLifecycle`#`configure` time - and later on `createServerResource` removes the _wrong_ one Any comments, suggestions? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-354478446 @rhtyd I will, I'm trying to figure out a good way to do it. Let you know when done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-353156142 @rhtyd should be fine now, there was a code-style issue which I fixed it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-352816862 @rhtyd damn! I haven't seen that link!!! thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-352810031 @rhtyd is there a way to see the error log? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
