[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
mike-tutkowski commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355708764 I've read through the code and the existing comments about it. I don't think I have anything to add above and beyond what's already been discussed here. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
mike-tutkowski commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-351507718 @rhtyd I haven't actually examined the code for this PR. I was serving mainly as a source of answers for questions regarding how this feature might interact with managed storage. Let me know if we still need reviewers. At the time being, I've been racing pretty hard to finish up another project, so I probably couldn't spend the necessary time until, say, mid next week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.
mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344790167 Correct, if the XenServer cluster supports UUID resigning (per the cloud.cluster_details supportsResign property), then all hosts in that cluster should support UUID resigning. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.
mike-tutkowski commented on issue #2315: A comprehensive solution for
#CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344772522
I?m looking at the logic in StorageSystemSnapshotStrategy.java and it
actually flows like this:
if (volumeInfo.getFormat() == ImageFormat.VHD) {
HostVO hostVO = getHost(volumeInfo.getId());
computeClusterSupportsVolumeClone =
clusterDao.getSupportsResigning(hostVO.getClusterId());
}
else if (volumeInfo.getFormat() == ImageFormat.OVA || volumeInfo.getFormat()
== ImageFormat.QCOW2) {
computeClusterSupportsVolumeClone = true;
}
else {
throw new CloudRuntimeException("Unsupported format");
}
From: Rafael Weing?rtner
Reply-To: apache/cloudstack
Date: Wednesday, November 15, 2017 at 2:59 PM
To: apache/cloudstack
Cc: "Tutkowski, Mike" , Mention
Subject: Re: [apache/cloudstack] A comprehensive solution for
#CLOUDSTACK-9025. (#2315)
@mike-tutkowski I am now taking into
consideration if the storage pool is managed or not.
I first load the storage pool where the volume of the snapshot is storage,
and then I look for a host that I can use to execute the operation. If the
storage pool is of managed type, I am going to check the parameter you
mentioned (?supportsResign?) in the cluster_details table; I am also expecting
that property to be set as true if the host supports resign UUIDs.
Thanks for your help here ;)
P.S. As you mentioned, this changes only affect snapshots in XenServer
environments.
?
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub,
or mute the
thread.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.
mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344724604 @rafaelweingartner Yes, you are correct: Use the 'managed' property of the storage pool in question. Also, the supportsResign property is really only relevant for XenServer. All versions of ESXi support UUID resigning by default and KVM doesn't require such support. (Note: Managed storage is only currently supported for XenServer, VMware, and KVM). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025.
mike-tutkowski commented on issue #2315: A comprehensive solution for #CLOUDSTACK-9025. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-344724604 @rafaelweingartner Yes, you are correct: Use the 'managed' property of the storage pool in question. Also, the supportsResign property is really only relevant for XenServer. All versions of ESXi supports UUID resigning by default and KVM doesn't require such support. (Note: Managed storage is only currently supported for XenServer, VMware, and KVM). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
