[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2018-01-04 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355473885 Test failure are due tounable to ssh and is not related to the change and can be ignored

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2018-01-04 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355473885 Test failure are due to unable to ssh and is not related to the change and can be ignored

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2018-01-03 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-354999754 Added refactoring changes This

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2018-01-01 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-354706959 @rhtyd, can this be merged?

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-353919345 @rhtyd , can you please review the changes

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-21 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-353294101 Update with the changes suggested

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-11-13 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-343848027 @rhtyd Could this be merged? This

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-11-09 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-343376245 tag:This is Ready to Merge This

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-10-11 Thread git
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-335734678 [results.txt](https://github.com/apache/cloudstack/files/1374814/results.txt)

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-10-11 Thread git
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-335734678 [results.txt](https://github.com/apache/cloudstack/files/1374814/results.txt)