[GitHub] nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents
nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-344801052 @rhtyd listeners for global settings update and new hosts added. Also shuffle is back to "normal" behavior. Lists will be propagated to agents only when 'hosts' or 'connected.agent.mslb.algorithm' values change or new hosts added, using new command-answer pattern instead of `ReadyCommand`. Please kindly review changes This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents
nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-344112446 @rhtyd thanks for your valuable review! I refactored code addressing most of your comments. There are quite few in which I think we should get aligned on and once we get aligned I could refactor as well! Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents
nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-343694472 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents
nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-343692671 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents
nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-343691188 @rhtyd @borisstoyanov please find new additions, kindly review/test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents
nvazquez commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-342554649 Thanks @rhtyd for pointing out pattern for persistent properties, I've addressed your comments This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
