rafaelweingartner commented on issue #2211: CLOUDSTACK-10013: Migrate
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-353059274
@Daan, @rohit there is no need to squash.
I like the idea/philosophy of self-contained commits. This means, one commit
per issue, which is normally the case of PRs. This PR, however, is a different
case. Frankly speaking, when I talked about squashing, I only saw the number
`23` in the commits tab, but I did not open it. Looking at the commits I do
think that it is good this way. It is my bad that I did not notice this before.
What I am against is something that we see sometimes, where people use one
commit per file/change. Then, a single issue that is being tackled in a PR
becomes 100+ commits?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
