rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-431879233
what ACS version are you using?
This is an automated mess
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372515754
@borisstoyanov do you have the tests results for this PR?
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371684587
@DaanHoogland would you like to run the integration tests before we merge
this one? Now everything seems to be ready for t
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371280867
Everything seems to be ok. I would leave the commits separated to facilitate
reviews.
---
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370844139
Please do the honors and delete it :)
This is an automat
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370733584
Regarding the version thing
@khos2ow what about deleting that `version.java` class and using only the
"CloudStackVe
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370732885
@khos2ow I will test the package generation in both centoOs7 and CentOs6. I
see that @DaanHoogland already started some ot
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370586983
Well.. that version.java was changed, and I think that affects ACS rode when
it deals with system VMs. What do you think?
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370528832
@DaanHoogland thanks for the update here. So, should we update for you to
run the tests as well?
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370528832
@DaanHoogland thanks for the update here. So, should we wait for you to run
the tests as well?
--
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370160810
@khos2ow thanks for the explanations. So, you needed to change that because
of the changes you did on packaging, which wou
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369332416
@rhtyd the other changes you were talking about, are they one "Version.java"?
@khos2ow can you explain them further?
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369332416
@rhtyd the other changes you were talking about, are they on "Version.java"?
@khos2ow can you explain them further?
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-367851868
@rhtyd what is your stance here?
This is an automated mes
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-366974604
Thansk @khos2ow!
Are we waiting for something else here? Everything seems to be in order.
-
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363757488
@rhtyd I believe it should be consistent across different OSs. This looks
like a "bug". @khos2ow can you take a look into
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363519607
Well I already approved this PR. For me it is everything ok. It is even
nicer that you provided more features and extensio
17 matches
Mail list logo
