rhtyd commented on a change in pull request #1933: CLOUDSTACK-9569: add
router.aggregation.command.each.timeout to agent?
URL: https://github.com/apache/cloudstack/pull/1933#discussion_r129548829
##########
File path:
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
##########
@@ -272,7 +272,10 @@ public boolean configure(final String name, final
Map<String, Object> params) th
_port = NumbersUtil.parseInt(value, 3922);
value = (String)params.get("router.aggregation.command.each.timeout");
- _eachTimeout = Duration.standardSeconds(NumbersUtil.parseInt(value,
10));
+ _eachTimeout = Duration.standardSeconds(NumbersUtil.parseInt(value,
(int)VRScripts.VR_SCRIPT_EXEC_TIMEOUT.getStandardSeconds()));
Review comment:
@borisstoyanov however this fix makes sense to use the default value when
not parse-able.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
