[GitHub] rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate

2017-08-04 Thread git
rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after 
vRouter reboot or recreate
URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-320324502
 
 
   LGTM, merging based on your feedback @Slair1 and my assessment of the code, 
and test results.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate

2017-08-02 Thread git
rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after 
vRouter reboot or recreate
URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-319815845
 
 
   Ping, any discussions/reviews?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate

2017-07-28 Thread git
rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after 
vRouter reboot or recreate
URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-318594347
 
 
   I'm not in position to decide merging this one, needs an additional review 
from one of the VPN gurus @swill @JayapalUradi and others
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate

2017-07-23 Thread git
rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after 
vRouter reboot or recreate
URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-317245467
 
 
   Regression tests have no new error (except known intermittent failures)
   @Slair1 @swill @kiwiflyer any comment, can this break if we fwd-merge on 
4.10+? Has anyone tested this, advise on merging this?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate

2017-07-22 Thread git
rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after 
vRouter reboot or recreate
URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-317177009
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate

2017-07-22 Thread git
rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after 
vRouter reboot or recreate
URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-317168549
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services