[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354956980 Test LGTM, the new migration test passes as well. I'll merge this based on code reviews and test results. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354697964 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354647185 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354645605 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354265497 Thanks @fmaximus Trillian uses it's own test_data. I'll move your test data changes to https://github.com/shapeblue/Trillian/blob/master/Ansible/roles/marvin/templates/test_data.py.j2 before running the next test round. It is advisable to include test data with the test and leave merging changes to the marvin test_data. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353926773 Additional review requested - @borisstoyanov @nvazquez @DaanHoogland @wido @rafaelweingartner @marcaurele and others, thanks. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353769047 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353723200 @fmaximus can you add the new marvin test to Travis (see the .travis.yml file) if it is hardware/hypervisor agnostic and also check/fix the failure in the last run. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353623802 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353618966 @krissterckx sure, already did. I'll help kick some tests now, first building packages. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353617778 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
