weizhouapache commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1921321296
> > @DaanHoogland I think this is a very small fix without any risk. I have
cherry-picked the commit to 4.18 branch and pushed to the github repository. It
will be in
BryanMLima commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1921267911
> @DaanHoogland I think this is a very small fix without any risk. I have
cherry-picked the commit to 4.18 branch and pushed to the github repository. It
will be in
weizhouapache commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1920885944
> @BryanMLima @lucas-a-martins , as @nvazquez said and hopefully it will be
on 4.20 ;) but if you need it in a mainstream release before, please backport.
> A revert will
DaanHoogland commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1920835536
@BryanMLima @lucas-a-martins , as @nvazquez said and hopefully it will be on
4.20 ;) but if you need it in a mainstream release before, please backport.
A revert will prevent
weizhouapache commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1920587867
We can backport to 4.18, then merge forward to 4.19 and main
@shwstppr @nvazquez @DaanHoogland @JoaoJandre
--
This is an automated message from the Apache Git Service.
To
shwstppr commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1920457497
Good catch @nvazquez. If we want it in 4.19.1 I guess either we need to
revert and merge again in 4.19 branch once 4.19 release is done or we would
need to backport the commit. Any
nvazquez commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1920408519
Hi guys, I think in case 4.19.0 RC4 makes it to be the final release this
fix won't be on 4.19.1 as the milestone states, but will be present only on the
future 4.20. @BryanMLima
weizhouapache commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1919123029
> @DaanHoogland @shwstppr, my mistake, I can revert the merge commit if it
is required.
No need to revert, I think
@BryanMLima
--
This is an automated message from
BryanMLima commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1919115376
@DaanHoogland @shwstppr, my mistake, I can revert the merge commit if it is
required.
--
This is an automated message from the Apache Git Service.
To respond to the message,
DaanHoogland commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1919102863
Hm @BryanMLima , we were still in freeze. don't think it will be a problem
though. cc @shwstppr .
--
This is an automated message from the Apache Git Service.
To respond to the
boring-cyborg[bot] commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1919097357
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
BryanMLima merged PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BryanMLima commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1919097043
Merging this based on four approvals and manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
DaanHoogland commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1885023273
> > clgtm @lucas-a-martins why did you close #8480 in favour of this PR?
they seem to do the same.
>
> @DaanHoogland thanks for your review. About the #8480, it was my
lucas-a-martins commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1885020025
> clgtm @lucas-a-martins why did you close #8480 in favour of this PR? they
seem to do the same.
@DaanHoogland thanks for your review. About the #8480, it was my first
blueorangutan commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1884413659
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1884310497
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It
will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep
you posted as I make
sureshanaparti commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1884310040
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov[bot] commented on PR #8482:
URL: https://github.com/apache/cloudstack/pull/8482#issuecomment-1884275484
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8482?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
All
lucas-a-martins opened a new pull request, #8482:
URL: https://github.com/apache/cloudstack/pull/8482
### Description
Currently, when starting the Agent, ACS checks if the `cryptsetup` command
can be used by using the command's `help`; the output of the command is printed
in the
lucas-a-martins closed pull request #8480: Change the check for the existence
of `cryptsetup` command
URL: https://github.com/apache/cloudstack/pull/8480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
boring-cyborg[bot] commented on PR #8480:
URL: https://github.com/apache/cloudstack/pull/8480#issuecomment-1883695160
Congratulations on your first Pull Request and welcome to the Apache
CloudStack community! If you have any issues or are unsure about any anything
please check our
lucas-a-martins opened a new pull request, #8480:
URL: https://github.com/apache/cloudstack/pull/8480
### Description
Currently, when starting the Agent, ACS checks if the `cryptsetup` command
can be used by using the command's `help`; the output of the command is printed
in the
23 matches
Mail list logo
