NUMBERS-20: Add unit tests for SmallPrimes.
Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/9e54e498 Tree: http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/9e54e498 Diff: http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/9e54e498 Branch: refs/heads/master Commit: 9e54e498d16400fdfcf7930ea4f60c42a9f10c85 Parents: 09dc016 Author: Ray DeCampo <r...@decampo.org> Authored: Thu Apr 20 18:25:10 2017 -0400 Committer: Ray DeCampo <r...@decampo.org> Committed: Thu Apr 20 18:25:10 2017 -0400 ---------------------------------------------------------------------- .../commons/numbers/primes/SmallPrimesTest.java | 143 +++++++++++++++++++ 1 file changed, 143 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/9e54e498/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java ---------------------------------------------------------------------- diff --git a/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java b/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java new file mode 100644 index 0000000..4aa784b --- /dev/null +++ b/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.numbers.primes; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import org.junit.Assert; +import org.junit.Test; + +public class SmallPrimesTest { + + // Primes larger than the small PRIMES array in SmallPrimes + private static final int[] LARGE_PRIME = {3673, 3677}; + + @Test + public void smallTrialDivision_smallComposite() { + final List<Integer> factors = new ArrayList<Integer>(); + final int result = SmallPrimes.smallTrialDivision(3*7*23, factors); + Assert.assertEquals(1, result); + Assert.assertEquals(Arrays.asList(3, 7, 23), factors); + } + + @Test + public void smallTrialDivision_repeatedFactors() { + final List<Integer> factors = new ArrayList<Integer>(); + final int result = SmallPrimes.smallTrialDivision(2*2*3*3*3, factors); + Assert.assertEquals(1, result); + Assert.assertEquals(Arrays.asList(2, 2, 3, 3, 3), factors); + } + + @Test + public void smallTrialDivision_oneFactor() { + final List<Integer> factors = new ArrayList<Integer>(); + final int result = SmallPrimes.smallTrialDivision(59, factors); + Assert.assertEquals(1, result); + Assert.assertEquals(Collections.singletonList(59), factors); + } + + @Test + public void smallTrialDivision_BoundaryPrimes() { + final List<Integer> factors = new ArrayList<Integer>(); + final int penultimatePrime = SmallPrimes.PRIMES[SmallPrimes.PRIMES.length-2]; + final int result = SmallPrimes.smallTrialDivision(penultimatePrime*SmallPrimes.PRIMES_LAST, factors); + Assert.assertEquals(1, result); + Assert.assertEquals(Arrays.asList(penultimatePrime, SmallPrimes.PRIMES_LAST), factors); + } + + @Test + public void smallTrialDivision_largeComposite() { + final List<Integer> factors = new ArrayList<Integer>(); + final int result = SmallPrimes.smallTrialDivision(2*5*LARGE_PRIME[0], factors); + Assert.assertEquals(LARGE_PRIME[0], result); + Assert.assertEquals(Arrays.asList(2, 5), factors); + } + + @Test + public void smallTrialDivision_noSmallPrimeFactors() { + final List<Integer> factors = new ArrayList<Integer>(); + final int result = SmallPrimes.smallTrialDivision(LARGE_PRIME[0]*LARGE_PRIME[1], factors); + Assert.assertEquals(LARGE_PRIME[0]*LARGE_PRIME[1], result); + Assert.assertEquals(Collections.<Integer>emptyList(), factors); + } + + @Test + public void boundedTrialDivision_twoDifferentFactors() { + final List<Integer> factors = new ArrayList<Integer>(); + final int result = SmallPrimes.boundedTrialDivision(LARGE_PRIME[0]*LARGE_PRIME[1], Integer.MAX_VALUE, factors); + Assert.assertEquals(LARGE_PRIME[1], result); + Assert.assertEquals(Arrays.asList(LARGE_PRIME[0], LARGE_PRIME[1]), factors); + } + + @Test + public void boundedTrialDivision_square() { + final List<Integer> factors = new ArrayList<Integer>(); + final int result = SmallPrimes.boundedTrialDivision(LARGE_PRIME[0]*LARGE_PRIME[0], Integer.MAX_VALUE, factors); + Assert.assertEquals(LARGE_PRIME[0], result); + Assert.assertEquals(Arrays.asList(LARGE_PRIME[0], LARGE_PRIME[0]), factors); + } + + @Test + public void trialDivision_smallComposite() { + final List<Integer> factors = SmallPrimes.trialDivision(5*11*29*103); + Assert.assertEquals(Arrays.asList(5, 11, 29, 103), factors); + } + + @Test + public void trialDivision_repeatedFactors() { + final List<Integer> factors = SmallPrimes.trialDivision(2*2*2*2*5*5); + Assert.assertEquals(Arrays.asList(2, 2, 2, 2, 5, 5), factors); + } + + @Test + public void trialDivision_oneSmallFactor() { + final List<Integer> factors = SmallPrimes.trialDivision(101); + Assert.assertEquals(Collections.singletonList(101), factors); + } + + @Test + public void trialDivision_largeComposite() { + final List<Integer> factors = SmallPrimes.trialDivision(2*3*LARGE_PRIME[0]); + Assert.assertEquals(Arrays.asList(2, 3, LARGE_PRIME[0]), factors); + } + + @Test + public void trialDivision_veryLargeComposite() { + final List<Integer> factors = SmallPrimes.trialDivision(2*LARGE_PRIME[0]*LARGE_PRIME[1]); + Assert.assertEquals(Arrays.asList(2, LARGE_PRIME[0], LARGE_PRIME[1]), factors); + } + + @Test + public void millerRabinPrimeTest_primes() { + for (final int n : PrimesTest.PRIMES) { + if (n % 2 == 1) { + Assert.assertTrue(SmallPrimes.millerRabinPrimeTest(n)); + } + } + } + + @Test + public void millerRabinPrimeTest_composites() { + for (final int n : PrimesTest.NOT_PRIMES) { + if (n %2 == 1) { + Assert.assertFalse(SmallPrimes.millerRabinPrimeTest(n)); + } + } + } +}
