[commons-net] branch master updated: Make private static classes final

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git


The following commit(s) were added to refs/heads/master by this push:
     new 1a7a8dd4 Make private static classes final
1a7a8dd4 is described below

commit 1a7a8dd49765635fba183e5beeff1beb96ef56d6
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue Oct 10 17:21:36 2023 -0400

    Make private static classes final
---
 .../java/org/apache/commons/net/examples/mail/IMAPExportMbox.java     | 2 +-
 src/main/java/org/apache/commons/net/ftp/FTPClient.java               | 4 ++--
 src/main/java/org/apache/commons/net/util/KeyManagerUtils.java        | 4 ++--
 src/main/java/org/apache/commons/net/util/TrustManagerUtils.java      | 2 +-
 src/test/java/org/apache/commons/net/ftp/FTPClientTest.java           | 4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/net/examples/mail/IMAPExportMbox.java 
b/src/main/java/org/apache/commons/net/examples/mail/IMAPExportMbox.java
index 0208dec9..fa54cf56 100644
--- a/src/main/java/org/apache/commons/net/examples/mail/IMAPExportMbox.java
+++ b/src/main/java/org/apache/commons/net/examples/mail/IMAPExportMbox.java
@@ -80,7 +80,7 @@ import org.apache.commons.net.imap.IMAPReply;
  */
 public final class IMAPExportMbox {
 
-    private static class MboxListener implements IMAPChunkListener {
+    private static final class MboxListener implements IMAPChunkListener {
 
         private final BufferedWriter bufferedWriter;
         volatile AtomicInteger total = new AtomicInteger();
diff --git a/src/main/java/org/apache/commons/net/ftp/FTPClient.java 
b/src/main/java/org/apache/commons/net/ftp/FTPClient.java
index 7b89d46c..617def64 100644
--- a/src/main/java/org/apache/commons/net/ftp/FTPClient.java
+++ b/src/main/java/org/apache/commons/net/ftp/FTPClient.java
@@ -244,7 +244,7 @@ import org.apache.commons.net.util.NetConstants;
 public class FTPClient extends FTP implements Configurable {
 
     // @since 3.0
-    private static class CSL implements CopyStreamListener {
+    private static final class CSL implements CopyStreamListener {
 
         private final FTPClient parent;
         private final long idleMillis;
@@ -337,7 +337,7 @@ public class FTPClient extends FTP implements Configurable {
         }
     }
 
-    private static class PropertiesSingleton {
+    private static final class PropertiesSingleton {
 
         static final Properties PROPERTIES;
 
diff --git a/src/main/java/org/apache/commons/net/util/KeyManagerUtils.java 
b/src/main/java/org/apache/commons/net/util/KeyManagerUtils.java
index f2e64c2e..fe0e6493 100644
--- a/src/main/java/org/apache/commons/net/util/KeyManagerUtils.java
+++ b/src/main/java/org/apache/commons/net/util/KeyManagerUtils.java
@@ -65,7 +65,7 @@ import org.apache.commons.net.io.Util;
  */
 public final class KeyManagerUtils {
 
-    private static class ClientKeyStore {
+    private static final class ClientKeyStore {
 
         private final X509Certificate[] certChain;
         private final PrivateKey key;
@@ -93,7 +93,7 @@ public final class KeyManagerUtils {
         }
     }
 
-    private static class X509KeyManager extends X509ExtendedKeyManager {
+    private static final class X509KeyManager extends X509ExtendedKeyManager {
 
         private final ClientKeyStore keyStore;
 
diff --git a/src/main/java/org/apache/commons/net/util/TrustManagerUtils.java 
b/src/main/java/org/apache/commons/net/util/TrustManagerUtils.java
index 9efa550c..91da9d21 100644
--- a/src/main/java/org/apache/commons/net/util/TrustManagerUtils.java
+++ b/src/main/java/org/apache/commons/net/util/TrustManagerUtils.java
@@ -32,7 +32,7 @@ import javax.net.ssl.X509TrustManager;
  */
 public final class TrustManagerUtils {
 
-    private static class TrustManager implements X509TrustManager {
+    private static final class TrustManager implements X509TrustManager {
 
         private final boolean checkServerValidity;
 
diff --git a/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java 
b/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java
index 5576b393..a9c898f6 100644
--- a/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java
@@ -28,7 +28,7 @@ import junit.framework.TestCase;
 
 public class FTPClientTest extends TestCase {
 
-    private static class LocalClient extends FTPClient {
+    private static final class LocalClient extends FTPClient {
 
         private String systemType;
 
@@ -42,7 +42,7 @@ public class FTPClientTest extends TestCase {
         }
     }
 
-    private static class PassiveNatWorkAroundLocalClient extends FTPClient {
+    private static final class PassiveNatWorkAroundLocalClient extends 
FTPClient {
         private final String passiveModeServerIP;
 
         public PassiveNatWorkAroundLocalClient(final String 
passiveModeServerIP) {