This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git
commit 0f58ab2b6322e694dcd5c68849b2aad0e30e156b Author: Pascal Schumacher <pascalschumac...@gmx.net> AuthorDate: Fri Dec 20 13:55:52 2019 +0100 CosineSimilarity#dot: Avoid potential overflow in int multiplication. --- src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java b/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java index 7405feb..21550f2 100644 --- a/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java +++ b/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java @@ -94,7 +94,7 @@ public class CosineSimilarity { final Set<CharSequence> intersection) { long dotProduct = 0; for (final CharSequence key : intersection) { - dotProduct += leftVector.get(key) * rightVector.get(key); + dotProduct += leftVector.get(key) * (long) rightVector.get(key); } return dotProduct; }