Author: simonetripodi Date: Wed Sep 7 20:21:04 2011 New Revision: 1166383 URL: http://svn.apache.org/viewvc?rev=1166383&view=rev Log: fixed checkstyle violations: '4' is a magic number.
Modified: commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryPredicate.java Modified: commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryPredicate.java URL: http://svn.apache.org/viewvc/commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryPredicate.java?rev=1166383&r1=1166382&r2=1166383&view=diff ============================================================================== --- commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryPredicate.java (original) +++ commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryPredicate.java Wed Sep 7 20:21:04 2011 @@ -45,6 +45,9 @@ public final class ConditionalBinaryPred * serialVersionUID declaration. */ private static final long serialVersionUID = -4511946801764080748L; + + /** Base hash integer used to shift hash */ + private static final int HASH_SHIFT = 4; // attributes // ------------------------------------------------------------------------ private final BinaryPredicate<? super L, ? super R> ifPred; @@ -104,15 +107,15 @@ public final class ConditionalBinaryPred public int hashCode() { int hash = "ConditionalBinaryPredicate".hashCode(); if (null != ifPred) { - hash <<= 4; + hash <<= HASH_SHIFT; hash ^= ifPred.hashCode(); } if (null != thenPred) { - hash <<= 4; + hash <<= HASH_SHIFT; hash ^= thenPred.hashCode(); } if (null != elsePred) { - hash <<= 4; + hash <<= HASH_SHIFT; hash ^= elsePred.hashCode(); } return hash;