[2/2] commons-compress git commit: fix whitespace - closes #50

2017-08-18 Thread bodewig
fix whitespace - closes #50 Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/083dd8ca Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/083dd8ca Diff:

[1/2] commons-compress git commit: Missing Test Case for octal to binary conversion

2017-08-18 Thread bodewig
Repository: commons-compress Updated Branches: refs/heads/master e00ea6c15 -> 083dd8ca0 Missing Test Case for octal to binary conversion In order to ensure that there is at least one test that will enter the octal string conversion, we added a test that for value = Long.MAX\_VALUE with an

commons-csv git commit: Better ivar name.

2017-08-18 Thread ggregory
Repository: commons-csv Updated Branches: refs/heads/master 431f8236e -> 259812ec0 Better ivar name. Project: http://git-wip-us.apache.org/repos/asf/commons-csv/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-csv/commit/259812ec Tree:

Re: commons-csv git commit: Better ivar name.

2017-08-18 Thread Benedikt Ritter
Hello, I don't think this is a better name. In my opinion it's bad style to add types to variable names. How about recordContents or simply content/s ? Regards, Benedikt schrieb am Fr. 18. Aug. 2017 um 17:02: > Repository: commons-csv > Updated Branches: >

[commons-csv] Git Push Summary

2017-08-18 Thread ggregory
Repository: commons-csv Updated Branches: refs/heads/CSV-216 [created] 259812ec0

commons-csv git commit: [CSV-216] Allow for mutable CSV records.

2017-08-18 Thread ggregory
Repository: commons-csv Updated Branches: refs/heads/CSV-216 259812ec0 -> b23f963e8 [CSV-216] Allow for mutable CSV records. Project: http://git-wip-us.apache.org/repos/asf/commons-csv/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-csv/commit/b23f963e Tree:

commons-dbcp git commit: No need to set ivars to null in declarations.

2017-08-18 Thread ggregory
Repository: commons-dbcp Updated Branches: refs/heads/master ab2c8a886 -> 712a207bf No need to set ivars to null in declarations. Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/712a207b Tree:

commons-dbcp git commit: Remove now useless SVN @version Id tag.

2017-08-18 Thread ggregory
Repository: commons-dbcp Updated Branches: refs/heads/master 712a207bf -> 6c5e19846 Remove now useless SVN @version Id tag. Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/6c5e1984 Tree: