[GitHub] janpio closed pull request #250: [CB-13861] Update TargetPlatformVersion

janpio closed pull request #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250 This is an automated message from the Apache Git Service. To respond to the message, please log

[cordova-windows] branch janpio-CB-13834 updated: VSINSTALLDIR as proper env var

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-CB-13834 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-CB-13834 by this push: new 0a0cfe2

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365446627 #254 is now in a state to be tested and reviewed. This is an automated

[GitHub] janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests URL: https://github.com/apache/cordova-windows/pull/254#issuecomment-365446432 Fixed by making sure the `index.html` is present (by copying from a folder where it exists). This is

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: add legacy

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-more_env_info_on_appveyor in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-more_env_info_on_appveyor by this

[cordova-windows] branch janpio-prepare_script_in_e2e updated: fix www source folder

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-prepare_script_in_e2e in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-prepare_script_in_e2e by this push:

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: add where

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-more_env_info_on_appveyor in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-more_env_info_on_appveyor by this

[cordova-windows] branch janpio-prepare_script_in_e2e updated: less minimal

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-prepare_script_in_e2e in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-prepare_script_in_e2e by this push:

[cordova-windows] branch janpio-CB-13834 updated: escape

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-CB-13834 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-CB-13834 by this push: new 2a47b6b escape

[cordova-windows] branch janpio-prepare_script_in_e2e updated: minimal config.xml

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-prepare_script_in_e2e in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-prepare_script_in_e2e by this push:

[GitHub] janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests URL: https://github.com/apache/cordova-windows/pull/254#issuecomment-365390984 The missing `index.html` in the test project is causing issues now: ``` EXEC : warning : Start page

[GitHub] janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests URL: https://github.com/apache/cordova-windows/pull/254#discussion_r167985739 ## File path: template/cordova/prepare ## @@ -0,0 +1,61 @@ +#!/usr/bin/env

[cordova-windows] branch janpio-CB-13817 updated: add missing space

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-CB-13817 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-CB-13817 by this push: new ea28080 add missing

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365388649 See https://github.com/apache/cordova-windows/pull/254 as a replacement. Would be nice if you could check that out and run it locally to

[GitHub] janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests URL: https://github.com/apache/cordova-windows/pull/254#discussion_r167985739 ## File path: template/cordova/prepare ## @@ -0,0 +1,61 @@ +#!/usr/bin/env

[GitHub] janpio opened a new pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

janpio opened a new pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests URL: https://github.com/apache/cordova-windows/pull/254 ? to prepare project files (based on `clean` and some terrible code to build a `project` object) also adds default

[cordova-windows] branch janpio-prepare_script_in_e2e updated (6dde4eb -> 9100723)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-prepare_script_in_e2e in repository https://gitbox.apache.org/repos/asf/cordova-windows.git. discard 6dde4eb add `prepare` script that can be called in e2e tests to prepare project

[cordova-windows] 01/01: CB-13875 add `prepare` script that can be called in e2e tests to prepare project files (based on `clean` and some terrible code to build a `project` object) also adds default

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-prepare_script_in_e2e in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit 910072309ff06266797f6ea9a4ee8e28feb9685c Author: Jan Piotrowski

[cordova-windows] 01/01: add `prepare` script that can be called in e2e tests to prepare project files (based on `clean` and some terrible code to build a `project` object) also adds default `config.x

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-prepare_script_in_e2e in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit 6dde4ebeb56d51f0d12fedc854baaed53505c4d5 Author: Jan Piotrowski

[cordova-windows] branch janpio-prepare_script_in_e2e created (now 6dde4eb)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-prepare_script_in_e2e in repository https://gitbox.apache.org/repos/asf/cordova-windows.git. at 6dde4eb add `prepare` script that can be called in e2e tests to prepare project

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365383160 Problem is that `prepare` is not available on the command line... so I had to implement that. Will open an issue and PR later.

[GitHub] janpio commented on issue #253: CB-13870 change default from UAP to 10.0

janpio commented on issue #253: CB-13870 change default from UAP to 10.0 URL: https://github.com/apache/cordova-windows/pull/253#issuecomment-365382904 Yes, this is actually required for `cordova requirements` not to explode (which happened after the change to `UAP`).

[GitHub] purplecabbage commented on issue #250: [CB-13861] Update TargetPlatformVersion

purplecabbage commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365382091 Yeah, I believe prepare is the right place for this to happen. Consider this pr dead.

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365357575 So I installed my branch which is giving me errors on running the test. On `cordova platform add ...` it creates a

[GitHub] codecov-io commented on issue #356: Fix prototype declaration warnings

codecov-io commented on issue #356: Fix prototype declaration warnings URL: https://github.com/apache/cordova-ios/pull/356#issuecomment-365354329 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #356: Fix prototype declaration warnings

codecov-io commented on issue #356: Fix prototype declaration warnings URL: https://github.com/apache/cordova-ios/pull/356#issuecomment-365354329 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=h1) Report > Merging

[cordova-windows] 03/03: output path to used MSBuildTools in during build

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-rework_MSBuildTools in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit 2014e205e28b7ea76766c5df54b5436b028bf53b Author: Jan Piotrowski

[cordova-windows] branch janpio-rework_MSBuildTools created (now 2014e20)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-rework_MSBuildTools in repository https://gitbox.apache.org/repos/asf/cordova-windows.git. at 2014e20 output path to used MSBuildTools in during build This branch includes the

[cordova-windows] 02/03: move getLatestMSBuild over to MSBuildTools

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-rework_MSBuildTools in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit 2bed15493bd5458a850e6b8f0068e5d9f365f8f8 Author: Jan Piotrowski

[cordova-windows] 01/03: notes on method usage

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-rework_MSBuildTools in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit 0ecda20cd0716ed1e8e01c6fe5c55780d03d1b7a Author: Jan Piotrowski

[GitHub] nrbrook opened a new pull request #356: Fix prototype declaration warnings

nrbrook opened a new pull request #356: Fix prototype declaration warnings URL: https://github.com/apache/cordova-ios/pull/356 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ]

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365348748 Can confirm, I currently only have `10.0.16299.0` (newest) installed. These tests only succeed if I change it to that version. Let

[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion

brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345897 > Is this maybe related to the actually installed local versions of Windows SDK? I would think so > Could you both please

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345308 Unfortunately I can not confirm that changing the value to `...10586...` fixes the issue: ``` C:\Program Files (x86)\Microsoft

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365344461 I can now confirm this error message with (only) Visual Studio 2017 installed: ``` C:\Program Files (x86)\Microsoft Visual

[GitHub] janpio commented on issue #251: CB-13817 Add new alias `uwp` for `--appx` param including tests

janpio commented on issue #251: CB-13817 Add new alias `uwp` for `--appx` param including tests URL: https://github.com/apache/cordova-windows/pull/251#issuecomment-365313201 Test failures are identical to current `master`.

[GitHub] janpio opened a new pull request #253: CB-13870 change default from UAP to 10.0

janpio opened a new pull request #253: CB-13870 change default from UAP to 10.0 URL: https://github.com/apache/cordova-windows/pull/253 ### What does this PR do? ... which means the same but works for check_reqs as well. This is an "update" to

[cordova-windows] 01/01: CB-13870 change default from UAP to 10.0 which means the same but works for check_reqs as well

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-CB-13870_2 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit f7a5450e235ebe0888bd417abb612f6d27c9ce95 Author: Jan Piotrowski AuthorDate:

[cordova-windows] branch janpio-CB-13870_2 created (now f7a5450)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-CB-13870_2 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git. at f7a5450 CB-13870 change default from UAP to 10.0 which means the same but works for check_reqs

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: more "

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-more_env_info_on_appveyor in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-more_env_info_on_appveyor by this

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: remove which

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-more_env_info_on_appveyor in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-more_env_info_on_appveyor by this

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666 The error message you posted contains `VisualStudio\v14.0` which is Visual Studio 2015. https://issues.apache.org/jira/browse/CB-13861

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666 The error message you posted contains `VisualStudio\v14.0` which is Visual Studio 2015. https://issues.apache.org/jira/browse/CB-13861

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: maybe now?

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-more_env_info_on_appveyor in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-more_env_info_on_appveyor by this

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: now?

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-more_env_info_on_appveyor in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/janpio-more_env_info_on_appveyor by this

[cordova-windows] 01/01: more env information about msbuild and visual studio on appveyor

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-more_env_info_on_appveyor in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit 6a2ea4ae424099735029112109a5d49968ddd8df Author: Jan Piotrowski

[cordova-windows] branch janpio-more_env_info_on_appveyor created (now 6a2ea4a)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-more_env_info_on_appveyor in repository https://gitbox.apache.org/repos/asf/cordova-windows.git. at 6a2ea4a more env information about msbuild and visual studio on appveyor This