[GitHub] purplecabbage commented on issue #166: CB-14091: fix tests code for stream url and remove browser

purplecabbage commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398621808 my song is really just 8 bars repeating for 60 seconds ... the word 'song' may be a bit of stretch ...

[GitHub] knight9999 commented on issue #166: CB-14091: fix tests code for stream url and remove browser

knight commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398621259 Thanks shazron and purplecabbage, I have updated the tests code to use BlueZedEx.mp3 file for each test.

[GitHub] purplecabbage edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser

purplecabbage edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398614641 Why you not like song? Is it rock too hard? jk . I can change the format if that is the issue.

[GitHub] purplecabbage commented on issue #166: CB-14091: fix tests code for stream url and remove browser

purplecabbage commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398614641 Why you no like song? Is it rock too hard?

[GitHub] shazron commented on issue #166: CB-14091: fix tests code for stream url and remove browser

shazron commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398613643 Sorry to be a stickler on this -- just because something is in the Wayback Machine, does not mean that it lacks

[GitHub] knight9999 opened a new pull request #168: CB-12849: check state in destroy and move file by stream

knight opened a new pull request #168: CB-12849: check state in destroy and move file by stream URL: https://github.com/apache/cordova-plugin-media/pull/168 ### Platforms affected android ### What does this PR do? Resolving recording audio issue. 1.

[GitHub] knight9999 edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser

knight edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398590691 I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org.

[GitHub] knight9999 edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser

knight edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398590691 I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org.

[GitHub] knight9999 edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser

knight edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398590691 I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org.

[GitHub] knight9999 commented on issue #166: CB-14091: fix tests code for stream url and remove browser

knight commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398590691 I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org.

[GitHub] knight9999 closed pull request #166: CB-14091: fix tests code for stream url and remove browser

knight closed pull request #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] knight9999 opened a new pull request #166: CB-14091: fix tests code for stream url and remove browser

knight opened a new pull request #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166 ### Platforms affected Tests code only Browser (test) iOS (test) ### What does this PR do?

[cordova-coho] branch master updated (e48fbbf -> dff309d)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. from e48fbbf CB-14122: Updating knownIssues.json for devDeps add 5c4fa85 tests working again (with 1 test

[GitHub] brodybits closed pull request #173: CB-14145: package.json updates to resolve npm audit warnings

brodybits closed pull request #173: CB-14145: package.json updates to resolve npm audit warnings URL: https://github.com/apache/cordova-coho/pull/173 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] brodybits opened a new pull request #173: CB-14145: package.json updates to resolve npm audit warnings

brodybits opened a new pull request #173: CB-14145: package.json updates to resolve npm audit warnings URL: https://github.com/apache/cordova-coho/pull/173 ### Platforms affected All ### What does this PR do? - tests working again - package.json updates to

[GitHub] codecov-io edited a comment on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit issues in patch release

codecov-io edited a comment on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=h1)

[GitHub] codecov-io edited a comment on issue #454: Mark 7.1.1-dev via coho

codecov-io edited a comment on issue #454: Mark 7.1.1-dev via coho URL: https://github.com/apache/cordova-android/pull/454#issuecomment-398520550 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/454?src=pr=h1) Report > Merging

[GitHub] brodybits closed pull request #156: 4.2.3 node_modules for cordova-coho only - DO NOT MERGE

brodybits closed pull request #156: 4.2.3 node_modules for cordova-coho only - DO NOT MERGE URL: https://github.com/apache/cordova-js/pull/156 This is an automated message from the Apache Git Service. To respond to the

[cordova-android] branch 7.1.x updated (3a83b5e -> 0bd3309)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch 7.1.x in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 3a83b5e package.json mark 7.1.1-dev add 4aeb892 Revert "package.json mark 7.1.1-dev" add

[GitHub] brodybits closed pull request #454: Mark 7.1.1-dev via coho

brodybits closed pull request #454: Mark 7.1.1-dev via coho URL: https://github.com/apache/cordova-android/pull/454 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] codecov-io commented on issue #454: Mark 7.1.1-dev via coho

codecov-io commented on issue #454: Mark 7.1.1-dev via coho URL: https://github.com/apache/cordova-android/pull/454#issuecomment-398520550 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/454?src=pr=h1) Report > Merging

[GitHub] brodybits opened a new pull request #454: Mark 7.1.1-dev via coho

brodybits opened a new pull request #454: Mark 7.1.1-dev via coho URL: https://github.com/apache/cordova-android/pull/454 ### Platforms affected Android ### What does this PR do? Set version to `7.1.1-dev` in `7.1.x` branch via cordova-coho NOTE: I had to

[GitHub] brodybits opened a new pull request #156: 4.2.3 node_modules for cordova-coho only - DO NOT MERGE

brodybits opened a new pull request #156: 4.2.3 node_modules for cordova-coho only - DO NOT MERGE URL: https://github.com/apache/cordova-js/pull/156 cordova-coho will show this hash per platform DO NOT INCLUDE IN master branch ### Platforms affected All

[GitHub] codecov-io edited a comment on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit issues in patch release

codecov-io edited a comment on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=h1)

[cordova-android] branch 7.1.x updated: package.json mark 7.1.1-dev

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch 7.1.x in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/7.1.x by this push: new 3a83b5e package.json mark 7.1.1-dev

svn commit: r1833860 [1/2] - in /cordova/site/public: blog/index.html feed.xml news/2018/06/04/common-release.html news/2018/06/19/ news/2018/06/19/common-release-2.2.4.html sitemap.xml static/js/inde

Author: steven Date: Tue Jun 19 17:37:49 2018 New Revision: 1833860 URL: http://svn.apache.org/viewvc?rev=1833860=rev Log: Updated docs Added: cordova/site/public/news/2018/06/19/ cordova/site/public/news/2018/06/19/common-release-2.2.4.html Modified:

svn commit: r1833860 [2/2] - in /cordova/site/public: blog/index.html feed.xml news/2018/06/04/common-release.html news/2018/06/19/ news/2018/06/19/common-release-2.2.4.html sitemap.xml static/js/inde

Modified: cordova/site/public/static/js/plugins.js URL: http://svn.apache.org/viewvc/cordova/site/public/static/js/plugins.js?rev=1833860=1833859=1833860=diff == --- cordova/site/public/static/js/plugins.js (original) +++

[GitHub] codecov-io edited a comment on issue #451: CB-14145: Minor release with cordova-common@2.2.x update, etc. WIP

codecov-io edited a comment on issue #451: CB-14145: Minor release with cordova-common@2.2.x update, etc. WIP URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=h1) Report > Merging

[GitHub] brodybits closed pull request #832: CB-14138: add cordova-common@2.2.4 blog post

brodybits closed pull request #832: CB-14138: add cordova-common@2.2.4 blog post URL: https://github.com/apache/cordova-docs/pull/832 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[cordova-docs] branch master updated: CB-14138: add cordova-common@2.2.4 blog post

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new 3d3fbc1 CB-14138: add

[cordova-common] tag rel/2.2.4 created (now 494eddd)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to tag rel/2.2.4 in repository https://gitbox.apache.org/repos/asf/cordova-common.git. at 494eddd (commit) No new revisions were added by this update.

svn commit: r27565 - /dev/cordova/CB-14138/

Author: brodybits Date: Tue Jun 19 16:34:09 2018 New Revision: 27565 Log: CB-14138 remove cordova-common release candidate from dist/dev Removed: dev/cordova/CB-14138/ - To unsubscribe, e-mail:

svn commit: r27564 - /release/cordova/tools/

Author: brodybits Date: Tue Jun 19 16:33:07 2018 New Revision: 27564 Log: CB-14138 publish cordova-common@2.2.3 tools release to dist Added: release/cordova/tools/cordova-common-2.2.4.tgz (with props) release/cordova/tools/cordova-common-2.2.4.tgz.asc

[GitHub] brodybits commented on issue #832: CB-14138: add cordova-common@2.2.4 blog post

brodybits commented on issue #832: CB-14138: add cordova-common@2.2.4 blog post URL: https://github.com/apache/cordova-docs/pull/832#issuecomment-398447331 I just pushed an update with some rewording (with updated _post filename)

[GitHub] shazron commented on issue #166: CB-14091: fix tests code for stream url and remove browser

shazron commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398434930 I'm not sure we have the copyright, any files we put on Apache need to have the right license (Apache 2.0 or one

[GitHub] codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1) Report > Merging

[GitHub] erisu commented on issue #448: CB-13685 android: Adaptive Icon Support

erisu commented on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398370194 @raphinesse Thank you for pointing out improvements to my test spec. I have updated the test and reduced the line count. I also removed the

[GitHub] codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1) Report > Merging

[GitHub] knight9999 commented on issue #166: CB-14091: fix tests code for stream url and remove browser

knight commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398335725 I have removed tests of streaming for Android 4.4. Remark that I have used one test mp3 file

[GitHub] raphinesse commented on a change in pull request #448: CB-13685 android: Adaptive Icon Support

raphinesse commented on a change in pull request #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#discussion_r196332233 ## File path: spec/unit/prepare.spec.js ## @@ -0,0 +1,935 @@ +/** +Licensed to the Apache

[GitHub] raphinesse commented on a change in pull request #448: CB-13685 android: Adaptive Icon Support

raphinesse commented on a change in pull request #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#discussion_r196332956 ## File path: spec/unit/prepare.spec.js ## @@ -0,0 +1,935 @@ +/** +Licensed to the Apache

[GitHub] raphinesse commented on issue #448: CB-13685 android: Adaptive Icon Support

raphinesse commented on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398313362 Sorry, I know very little about the Android build, so I can't really review this. Maybe @dpogue or @infiloop.

[GitHub] erisu commented on issue #448: CB-13685 android: Adaptive Icon Support

erisu commented on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398297321 @raphinesse I rebased with the latest master now that the #442 PR has been merged. Do you think this is ready to merge?